Overlapping button and 'show more' dropdown in split bill flow [FIXED: solution included]

bobby-beers commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

this is a followup to another issue, describing an additional bug found while fixing this: https://github.com/Expensify/App/issues/25562#issuecomment-1691673586

Action Performed:

In the 'split bill' flow, when 5 or more people are added, if the window is sized to the minimum height, the button overlaps the "show more" dropdown above it.

incorrect handling of window resizing by the objects mentioned above. Adding too many (more than 5) recipients shrinks the available space, and brings up issues with how the window handles and prioritizes the elements.

Expected Result:

The buttons should not overlap one another

Actual Result:

the buttons overlap

Workaround:

Yes, the user can still use the app.

Solution

we can actually just add .flex0 to the same line. When we do this, the show more button stacks on top of the item above it, as shown here:

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ x] MacOS / Chrome / Safari
[x ] MacOS / Desktop

Version Number: "1.3.56-21" Reproducible in staging?: yes Reproducible in production?: yes If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: Slack conversation:

View all open jobs on GitHub

melvin-bot[bot] commented 1 year ago

📣 @byobeers! 📣 Please report bugs or suggest features in the #expensify-open-source Slack channel, don't directly open issues in this repo! Instructions here to join the channel 📖

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Expensify / App