search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.51k stars 2.86k forks source link

[$2000] Toggle switch fails to toggle back when tapped again on preferences page #25880

Closed kavimuru closed 10 months ago

kavimuru commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Open settings
  2. Open preferences
  3. tap on Toggle to ON/OFF

    Expected Result:

    Toggle switch should switch to ON/OFF when it is tapped again

Actual Result:

The toggle switch only works once and does not respond to subsequent taps

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: needs reproduction Reproducible in staging?: needs reproduction Reproducible in production?: needs reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/43996225/771bd7e9-d0ba-4312-ad36-10d25f37a9c8

Expensify/Expensify Issue URL: Issue reported by:@jo-ui Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692040308927449

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d30a31388a44c81c
  • Upwork Job ID: 1696550383851593728
  • Last Price Increase: 2023-12-19
melvin-bot[bot] commented 1 year ago

@strepanier03, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

strepanier03 commented 1 year ago

We're okay Melvin. @ShogunFire is working on a more specific proposal as well.

melvin-bot[bot] commented 1 year ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

mvtglobally commented 1 year ago

Issue not reproducible during KI retests. (Second week)

strepanier03 commented 1 year ago

Thank you @mvtglobally 👍

melvin-bot[bot] commented 1 year ago

@strepanier03, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!

strepanier03 commented 1 year ago

@ShogunFire - Do you still plan to submit a more specific proposal for this? Or did you submit it and I missed it somehow?

@thesahindia - Do you think we should continue to hold for more proposals here or raise the price?

melvin-bot[bot] commented 1 year ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

thesahindia commented 1 year ago

@thesahindia - Do you think we should continue to hold for more proposals here or raise the price?

We haven't got any update from @ShogunFire, so let's increase the price.

ShogunFire commented 1 year ago

Proposal

Updated

Sorry for the delay, I have this proposal that works by changing lottie code, otherwise we can wait https://github.com/Expensify/App/issues/16660 which will remove the fork of react-native-web and allow us to use setDeadline

thesahindia commented 1 year ago

otherwise we can wait #16660 which will remove the fork of react-native-web and allow us to use setDeadline

I think we should wait.

Let's put this on hold @strepanier03

strepanier03 commented 1 year ago

Got it! I'll put this on hold and move to Weekly. When we're ready to move forward we can change this back to Daily.

strepanier03 commented 1 year ago

Still on hold, the linked PR is open and we're waiting on that.

strepanier03 commented 12 months ago

Still holding for PR merge.

strepanier03 commented 11 months ago

Still on hold.

shubham1206agra commented 11 months ago

@strepanier03 I think PR has already merged. We can safely get this off hold.

strepanier03 commented 11 months ago

Great, I've taken this off hold and moved it back to Daily.

melvin-bot[bot] commented 11 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

thesahindia commented 11 months ago

@ShogunFire, can we move forward now?

strepanier03 commented 11 months ago

Friendly bump @ShogunFire, thanks!

melvin-bot[bot] commented 11 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

strepanier03 commented 10 months ago

Still waiting for proposals, all good melvin.

mvtglobally commented 10 months ago

Issue not reproducible during KI retests. (third week)

melvin-bot[bot] commented 10 months ago

@strepanier03, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!

strepanier03 commented 10 months ago

I'll test this again today or tomorrow.

melvin-bot[bot] commented 10 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 10 months ago

@strepanier03, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Tony-MK commented 10 months ago

It seems to work on Andriod 10. However, there is a problem with Android 12.

@strepanier03 Could you please retest this again?

melvin-bot[bot] commented 10 months ago

@strepanier03, @thesahindia 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] commented 10 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

strepanier03 commented 10 months ago

Was out of the office. Working on this now.

strepanier03 commented 10 months ago

Here's what I found:

@Tony-MK - Can you add a screencast of your repro and a bit more about your testing device so I can try to emulate your testing parameters?

Tony-MK commented 10 months ago

@strepanier03, Since you couldn't reproduce the bug on Android 12, could this other problem only apply to me?

Listed devices from left to right respectively:

1) Pixel 6 Pro - Android 13.0 2) Pixel 7 Pro - Android 12.0 3) Pixel 7 Pro - Android 12L 4) Pixel 6 - Android 12L

Staging

Staging Screenshot

Production

Production Screenshot

mvtglobally commented 10 months ago

Issue not reproducible during KI retests. (Fourth week)

strepanier03 commented 10 months ago

@Tony-MK - I guess it could be specific to you, but I'm not 100% sure.

I'll do another round of testing and if I still can't repro we can close this out until it becomes relevant again, at which point we can reopen.

strepanier03 commented 10 months ago

Testing results

Android Chrome

Okay, so I think at this point we close. I've tested on various Android versions and can't reproduce this any longer.

Tony-MK commented 10 months ago

Thanks a lot for the confirmation.