Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

[HOLD for payment 2023-10-18] [$1000] IOU - Not all Split bills are registered when leaving offline mode #25925

Closed lanitochka17 closed 1 year ago

lanitochka17 commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open a New Expensify application
  2. Disable the internet connection in the device
  3. From the global create menu +, select Split bill
  4. Select any 3 participants and complete the IOU
  5. Repeat steps 3-4 2 times with the same participants
  6. Enable the Internet connection on your device

This bug also occurs in this workflow:

  1. Login as User A and User B in front of you at the same time.
  2. As User A requests Money from User B ( make sure it works by avoiding the bugs around the IOU feature Now )
  3. As User A go offline ( go to settings > preferences > turn on the offline mode ) - don't go offline as User B.
  4. As User A Send another Money request.
  5. As User B, Pay the first money request elsewhere.
  6. Back to User A and Go online again.
  7. Notice the Money request message for both users.

Expected Result:

All Split bills created in offline mode must be registered when you enable online mode

Actual Result:

When creating several Split bills for the same participants in offline mode, only the first Split bill is registered when going online, all others give an error

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.57-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/78819774/837a0945-96cf-4b2f-a19f-df119789e5d3

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team / @eusalazar

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692057275536929

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010990d7cb2b15ce9f
  • Upwork Job ID: 1696572786341081088
  • Last Price Increase: 2023-09-19
tsa321 commented 1 year ago

@zanyrenney me too, I have an error accepting the offer. Exactly same as @aimane-chnaif above...

aimane-chnaif commented 1 year ago

It seems issue on upwork. I am also not able to accept another offer from other GH.

zanyrenney commented 1 year ago

Okay, let's hang tight for now then and see if this self-resolves. I am seeing currently on the status page they are having issues: https://status.upwork.com/

zanyrenney commented 1 year ago

sorry about the delay in paying this out, but it is out of my control if upwork is dodgy!

tsa321 commented 1 year ago

Don't worry @zanyrenney and thank you for the on time payment attempt

aimane-chnaif commented 1 year ago

sorry about the delay in paying this out, but it is out of my control if upwork is dodgy!

No problem at all. Upwork issue is now fixed and accepted offer. Thanks

eusalazar commented 1 year ago

Excuse me, my payment will also be made today for RP.?

melvin-bot[bot] commented 1 year ago

📣 @eusalazar! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
eusalazar commented 1 year ago

eugeniasalazar745@gmail.com

zanyrenney commented 1 year ago

We need your upwork profile, not just an email @eusalazar

eusalazar commented 1 year ago

https://www.upwork.com/freelancers/~01b78d40a285cc88ab eugeniasalazar745@gmail.com

zanyrenney commented 1 year ago

Please apply to the job @eusalazar - I am not finding you on Upwork.

zanyrenney commented 1 year ago

payment summary

C+ - @aimane-chnaif requires payment - PAID $1500 (INC. $500 urgency) C - @tsa321 requires payment - PAID $1500 (INC. $500 urgency) Reporter @eusalazar - needs payment but needs to apply to job on upwork

eusalazar commented 1 year ago

Hello, I already applied! thank you

tsa321 commented 1 year ago

Thank you very much @zanyrenney

zanyrenney commented 1 year ago

brilliant, thank you @eusalazar - please accept my offer so we can move forward!

zanyrenney commented 1 year ago

paid @eusalazar $250 for bug report as it was before price change. All payments complete - closing!