[HOLD for payment 2023-10-16] [$500] Assign Task - Assignee field active in offline mode while assigning task, should be greyed out

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open a chat
2. Navigate to the "Assign task" section
3. Create a task by entering a title
4. Enable offline mode from Preferences
5. Select a user from the assignee field
6. Notice assignee field is not greyed out

Expected Result:

During offline mode, the assignee field should appear greyed out to indicate its inactivity while assigning a task

Actual Result:

The assignee field remains active and doesn't turn grey while assigning a task in offline mode

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [ ] Android / Chrome
• [ ] iOS / native
• [ ] iOS / Safari
• [x] Windows / Chrome
• [ ] MacOS / Desktop

Version Number: 1.3.57-4

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/78819774/6116d6f9-8352-4a2d-abf6-6c3a97791687

https://github.com/Expensify/App/assets/78819774/dd482945-027e-4ed7-9c97-a584289095de

Expensify/Expensify Issue URL:

Issue reported by: @ayazhussain79

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691792826667939

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cb180f9f96ed4319
• Upwork Job ID: 1697586364732370944
• Last Price Increase: 2023-09-15

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Assignee field active in offline mode while assigning task, should be greyed out

What is the root cause of that problem?

We don't set pendingField when editing assignee https://github.com/Expensify/App/blob/c435734d8cf360e964e20eea1fb54c541f6fa7ea/src/libs/actions/Task.js#L511

What changes do you think we should make in order to solve the problem?

In optimistic report data https://github.com/Expensify/App/blob/c435734d8cf360e964e20eea1fb54c541f6fa7ea/src/libs/actions/Task.js#L526-L531 we should add pending field managerID: update like this

pendingFields: {
        ...(assigneeAccountID && {managerID: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE}),
},

We also need to remove pendingFields when updating successful

What alternative solutions did you explore? (Optional)

[esh-g]

Proposal

Please re-state the problem we are trying to solve

The task assignee field is doesn't get greyed out when changed offline.

What is the root cause of this problem?

This was introduced in this PR: https://github.com/Expensify/App/pull/22778 We are not setting the pendingField for managerID while editing task assignee in optimistic data https://github.com/Expensify/App/blob/a03a21d25832760cf9db4235b0fbc88cc08bd490/src/libs/actions/Task.js#L525-L534

Therefore, the pending field for managerID is always null and it never gets greyed out.

What changes do you think we should make in order to solve the problem?

1. We should add the pendingField to the optimistic data while editing task assignee like this:

   {
   onyxMethod: Onyx.METHOD.MERGE,
   key: `${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`,
   value: {
       reportName,
       managerID: assigneeAccountID || report.managerID,
       managerEmail: assigneeEmail || report.managerEmail,
       pendingFields: {managerID: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE}, // add this line
   },
   },

2. In success data, we should add the following to clear out the pending fields

   {
   onyxMethod: Onyx.METHOD.MERGE,
   key: `${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`,
   value: {pendingFields: {managerID: null}}
   }

This is the same approach we follow editTaskAndNavigate function.

[melvin-bot[bot]]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot[bot]]

@michaelhaxhiu Whoops! This issue is 2 days overdue. Let's get this updated quick!

[michaelhaxhiu]

@allroundexperts - do you think this bug report & problem is a dupe of https://github.com/Expensify/App/issues/23200? Would love your input!

[michaelhaxhiu]

Yep this feels and looks like a dupe, and the other GH is addressing it. Closing.

[ayazhussain79]

@michaelhaxhiu This bug https://github.com/Expensify/App/issues/23200 PR merged but https://github.com/Expensify/App/issues/25956 is still reproducible @allroundexperts can you please also check this one

[michaelhaxhiu]

Hmm let's see what's suggested on https://github.com/Expensify/App/issues/23200 from those involved. You may be due a bug reporting bounty if this is indeed "separate" and thus unique.

[michaelhaxhiu]

But firstly I want to ensure this is fixed. If it's not fixed, there is no bug bounty to pay. That's the pre-requisite.

[michaelhaxhiu]

https://github.com/Expensify/App/pull/22778#issuecomment-1701261268

Commented here for team input on how to best proceed. This is a valid bug and still occurring based on latest testing, so we do need to fix it. But I want to check if we should draft a new PR or amend/update the PR that caused it.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01cb180f9f96ed4319

[melvin-bot[bot]]

Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[michaelhaxhiu]

cc'ing @thienlnam @Santhosh-Sellavel

[michaelhaxhiu]

this is a regression from https://github.com/Expensify/App/pull/22778

[michaelhaxhiu]

might make sense for @abdulrahuman5196 to trade this GH to @Santhosh-Sellavel since he was involved in the parent regression, though it's not necessary. I'll let yall decide.

[Rachit-pul]

Hello Team, here from the upwork job link.

Proposal

Please re-state the problem we are trying to solve

The task assignee field is doesn't get greyed out when changed offline.

What is the root cause of this problem?

This seems like a simple rendering issue where in the field does not have the logic to be greyed out. I am assuming in the previous fixed the forced online variable is accessible here.

Two scenarios I could come up with,

1. If force_offline is already true, before the user reaches here. The field is greyed out. In this case the new change from false -> true is not synced with the switch
2. It is never greyed out regardless of the switch

What changes do you think we should make in order to solve the problem?

In both cases, the solution would simply be in 2 parts,

1. Adding the logic to check force_offline before rendering.
2. On every switch between true/false we update the following page. This would require a little deeper understanding of the codebase to see how these chat instances are stored and if the GUI objects are available post rendering.

There seems to be a flag as enabledWhenOffline and it seems by simply disabling the field by checking this would be enough for a fix

This was just a cursory look, But from the problem statement and video this is what I could predict.

Thanks!

Rachit Pulhani https://www.upwork.com/freelancers/~01167d06dbad3ad324 rachit2510pulhani@gmail.com

[melvin-bot[bot]]

📣 @Rachit-pul! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Format:

   Contributor details
   Your Expensify account email: <REPLACE EMAIL HERE>
   Upwork Profile Link: <REPLACE LINK HERE>

[akdevndesign]

Proposal

Please re-state the problem we are trying to solve The task assignee field doesn't get greyed out (or block user from accessing assignee menu) while offline.

What is the root cause of this problem? There is no existing logic to update state of assignee field when online status is set to offline.

What changes do you think we should make in order to solve the problem? To begin, I would start in the NewTaskPage component. Looks like there is an enabledWhenOffline prop already used with other components - so I would check it's compatibility with the "task asignee" field. Depending on the functionality of the enabledWhenOffline prop, I may have to create a custom style to handle the opacity changes while offline and create some sort of logic to disable while offline.

Thanks!

Contributor details Your Expensify account email: ajkelsey53@gmail.com Upwork Profile Link: (https://www.upwork.com/freelancers/aaronk10)

[melvin-bot[bot]]

📣 @akdevndesign! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Format:

   Contributor details
   Your Expensify account email: <REPLACE EMAIL HERE>
   Upwork Profile Link: <REPLACE LINK HERE>

[Rachit-pul]

Contributor details Your Expensify account email: rachit2510pulhani@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/~01167d06dbad3ad324

[melvin-bot[bot]]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot[bot]]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[akdevndesign]

Contributor details Your Expensify account email: ajkelsey53@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/aaronk10

[melvin-bot[bot]]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot[bot]]

@michaelhaxhiu, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[abdulrahuman5196]

I can review this issue. The linked regression bug is like a month old so this should be fine.

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@michaelhaxhiu, @abdulrahuman5196 Huh... This is 4 days overdue. Who can take care of this?

[michaelhaxhiu]

Waiting for review by @abdulrahuman5196. Let us know when you anticipate having a chance to prioritize!

[melvin-bot[bot]]

@michaelhaxhiu @abdulrahuman5196 this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[abdulrahuman5196]

Sorry for the delay. Will cover over the weekend

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@michaelhaxhiu, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[michaelhaxhiu]

Bump, any update here?

[melvin-bot[bot]]

@michaelhaxhiu @abdulrahuman5196 this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot[bot]]

Current assignee @abdulrahuman5196 is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot[bot]]

@michaelhaxhiu, @abdulrahuman5196 Eep! 4 days overdue now. Issues have feelings too...

[akdevndesign]

I know this isn't the process but if you still need someone to squash this - still happy to assist! I can knock out ASAP.

[abdulrahuman5196]

TAL now

[abdulrahuman5196]

Proposal from @DylanDylann here https://github.com/Expensify/App/issues/25956#issuecomment-1693608602 looks good and works well.

🎀 👀 🎀 C+ Reviewed

[melvin-bot[bot]]

Triggered auto assignment to @tylerkaraszewski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot[bot]]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[michaelhaxhiu]

I'm re-assigning this to another BZ as part of my preparation for Sabbatical (starting Friday).

Next steps:

• Sherpa this forward with @abdulrahuman5196
• After the PR is finalized, pay the bug reporter / contributor / C+ (based on timestamp, the payouts will honor our old price points btw context)

[abdulrahuman5196]

Pending on @tylerkaraszewski review.

[DylanDylann]

@abdulrahuman5196 The PR is ready for review: https://github.com/Expensify/App/pull/28378

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.79-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/28378

If no regressions arise, payment will be issued on 2023-10-16. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter
• [ ] Contributor that fixed the issue
• [ ] Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment
• @DylanDylann requires payment
• @ayazhussain79 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@abdulrahuman5196] Determine if we should create a regression test for this bug.
• [ ] [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [x] [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/326926