[HOLD for payment - Sept 28th] [$1000] Notification not receiving on iOS when long message is sent

izarutskaya commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Login on iOS Native app
Login another account on another platform
Paste below text in composer -> Hit send

QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty QWERTY qwerty

Expected Result:

iOS should receive notification

Actual Result:

iOS native not receiving notification when message is long

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[x] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: v1.3.57-5

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/115492554/c1b8742c-a229-43a4-af10-1a7888632d24

https://github.com/Expensify/App/assets/115492554/48073533-4192-4d4e-9181-c265b3237ca1

Expensify/Expensify Issue URL:

Issue reported by: @DinalJivani

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692129779665229

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0139b0dc94f812c234
Upwork Job ID: 1696149809907351552
Last Price Increase: 2023-08-28

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

[x] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[x] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[x] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[x] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[x] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

tamdao commented 1 year ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Notification not receiving on iOS when long message is sent

What is the root cause of that problem?

The maximum payload size of notification:

For Voice over Internet Protocol (VoIP) notifications, the maximum payload size is 5 KB (5120 bytes).
For all other remote notifications, the maximum payload size is 4 KB (4096 bytes).

You can take a look the document here

So that's why it didn't send the notification with long message, because the payload of notification over the limit size.

What changes do you think we should make in order to solve the problem?

You need to update backend to make sure the payload of notification not over the limit size, that mean you need to reduce the number of characters of title and body of notification

melvin-bot[bot] commented 1 year ago

📣 @tamdao! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Format:
```
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
```

joekaufmanexpensify commented 1 year ago

Not overdue

joekaufmanexpensify commented 1 year ago

I can reproduce this. However, if this is an apple limitation, I'm not sure we'd do anything. Curious if others agree though.

melvin-bot[bot] commented 1 year ago

Job added to Upwork: https://www.upwork.com/jobs/~0139b0dc94f812c234

melvin-bot[bot] commented 1 year ago

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

joekaufmanexpensify commented 1 year ago

@0xmiroslav curious for your thoughts on this , when you have a chance?

joekaufmanexpensify commented 1 year ago

Still pending insight from Miroslav.

0xmiros commented 1 year ago

I think this is internal issue. Push notification only works on real device where contributors can't test because they don't have access to apple cert and provisioning profile.

joekaufmanexpensify commented 1 year ago

Sounds good. Making this internal!

melvin-bot[bot] commented 1 year ago

Current assignee @0xmiroslav is eligible for the Internal assigner, not assigning anyone new.

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

joekaufmanexpensify commented 1 year ago

@Gonals We're thinking this bug needs to be internal. Let us know if you agree!

DinalJivani commented 1 year ago

I can reproduce this. However, if this is an apple limitation, I'm not sure we'd do anything. Curious if others agree though.

I know this is Apple limitation. But also other chat apps like Whatsapp, Instagram can send as long message you want and notifications still works... Not sure what mechanisms they will be using 🧐

@joekaufmanexpensify @0xmiroslav

melvin-bot[bot] commented 1 year ago

@Gonals, @joekaufmanexpensify, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Gonals commented 1 year ago

I think this is internal issue. Push notification only works on real device where contributors can't test because they don't have access to apple cert and provisioning profile.

I agree, but I can't really work on it either. I don't have an apple device to test on! 😆

joekaufmanexpensify commented 1 year ago

@Gonals got it. Should we just re-assign this then?

I'm also curious if there is anything we can actually do about this (if this is an apple limitation). Though I see referenced here that other apps seem to get around this.

joekaufmanexpensify commented 1 year ago

@Gonals bump on this when you have a sec!

joekaufmanexpensify commented 1 year ago

Still pending further discussion.

joekaufmanexpensify commented 1 year ago

Bumped Alberto 1:1

Gonals commented 1 year ago

Yep! I think reassigning would be the way to go. I'll unassign myself. Can you roll the dice again, @joekaufmanexpensify? If I were to do it, I would just get reassigned 😅

joekaufmanexpensify commented 1 year ago

Sounds good!

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

joekaufmanexpensify commented 1 year ago

@Beamanator as an fyi, we re-assigned this as this issue requires backend changes, but the engineer who works on it needs to have a physical iOS device, and Alberto does not. LMK if you have any questions!

Beamanator commented 1 year ago

Asked for confirmation in slack if we can give external devs access to any certs to be able to test & work on this externally

Julesssss commented 1 year ago

Taking over.

You need to update backend to make sure the payload of notification not over the limit size

We do this already for messages over 3kb 😕 I'll take a look at this again.

Julesssss commented 1 year ago

Testing this is very time-consuming and even more difficult for iOS. Demoting to weekly but I'm aiming to take a look today

joekaufmanexpensify commented 1 year ago

Sounds good, thanks @Julesssss !

melvin-bot[bot] commented 1 year ago

@Julesssss @joekaufmanexpensify @0xmiroslav this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

Julesssss commented 1 year ago

I'm noticing the Onyx payload limit is also being hit on Android...

joekaufmanexpensify commented 1 year ago

Ah, interesting. That means we need to fix this in both native apps?

Julesssss commented 1 year ago

@joekaufmanexpensify it's likely a backend issue. I imagine we're hitting the max payload size again and will need to somehow reduce it. But the solution should work for both apps.

joekaufmanexpensify commented 1 year ago

Got it, sounds good!

Julesssss commented 1 year ago

Figured this out. PR here

joekaufmanexpensify commented 1 year ago

Woo, thanks Jules!

Julesssss commented 1 year ago

Fix deployed to prod, closing.

DinalJivani commented 1 year ago

@Julesssss @joekaufmanexpensify I think reporting bonus is pending

Julesssss commented 1 year ago

Oh yep, thanks for the reminder

joekaufmanexpensify commented 1 year ago

Yep! I'll pay today.

joekaufmanexpensify commented 1 year ago

This issue is from before we changed pricing tiers, so bonus is $250 here.

joekaufmanexpensify commented 1 year ago

@DinalJivani offer sent for $250!

DinalJivani commented 1 year ago

@joekaufmanexpensify offer accepted! Thanks.

joekaufmanexpensify commented 1 year ago

Since we are just paying out the reporting bonus here, we don't need to wait 7 days (since there is no possibility of the reporter causing a regression that results in reduced payment).

joekaufmanexpensify commented 1 year ago

@DinalJivani $250 sent and contract ended!

joekaufmanexpensify commented 1 year ago

Closing as this one is all set!

Expensify / App