Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

[HOLD for payment 2023-09-27] [$1000] Link Request Money not work #26214

Closed izarutskaya closed 1 year ago

izarutskaya commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Sign in on browser as User A
  2. Create a chat with multiple users
  3. Click the "+" green button icon in the chat and select Split Bill
  4. Copy the URL in the browser (should be https://staging.new.expensify.com/split/new) and send it to the user B
  5. Login on browser as User B -> go to chat User A
  6. Click on the link of Request Money user A just sent
  7. Enter the amount and press Next
  8. Notice the Amount page loads again

Expected Result:

Navigate to confirm the requested amount

Actual Result:

The screen to enter the amount of the Split Bill is displayed again

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: v1.3.57-5

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/115492554/a0bd23d1-848a-4adc-9bb7-db93b459789f

https://github.com/Expensify/App/assets/115492554/1eae76c4-ee37-488f-8f78-64c76faae30c

https://github.com/Expensify/App/assets/115492554/0122c24f-96b9-41fc-8b5a-d5a9fc9a8852

Expensify/Expensify Issue URL:

Issue reported by: @Le Thi Thu Thuy

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692093712051379

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01354f2b491ad407b0
  • Upwork Job ID: 1696603285025492992
  • Last Price Increase: 2023-09-05
  • Automatic offers:
    • akamefi202 | Contributor | 26512355
ArekChr commented 1 year ago

Hi @ChristinaDobrzyn, It seems like the PR did not get merged. It was reverted, and the error is not reproducible anymore due to changes in the split bill feature. I'm thinking we go for a 25% payout of the agreed price, given the situation. What do you think?

Christinadobrzyn commented 1 year ago

Ah thank you for catching that @ArekChr, okay the payment would be as follows here - https://github.com/Expensify/App/issues/26214#issuecomment-1758542357

Can you double-check that looks correct?

@akamefi202 I'll leave a comment in this GH about overpayment here and see if it can be deducted from this job - https://github.com/Expensify/App/issues/29219

akamefi202 commented 1 year ago

@Christinadobrzyn I agree. I will ask deduction when the issue is completed.

Christinadobrzyn commented 1 year ago

Sounds good! Nothing yet from @le about the job so going to keep this open.

thuyle04 commented 1 year ago

@Christinadobrzyn There seems to be a mistake here, my github account is Le Thi Thu Thuy, not le. So it's possible to tag the wrong person, please check carefully and help me correct it. Thanks Screenshot from 2023-10-12 22-29-15

thuyle04 commented 1 year ago

Contributor details Your Expensify account email: thuy.lethithu@antbuddy.com Upwork Profile Link: https://www.upwork.com/freelancers/~01fcd9ed589276332f

melvin-bot[bot] commented 1 year ago

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

Christinadobrzyn commented 1 year ago

Thanks @thuyle04 I thought that was a little strange - didn't think to look at the Slack post - thanks for showing that.

Can you accept this job offer so I can pay you? https://www.upwork.com/jobs/~01c8ed54f75760e5cc

Christinadobrzyn commented 1 year ago

paid @thuyle04 based on https://github.com/Expensify/App/issues/26214#issuecomment-1758542357

So I think this is all set!

Christinadobrzyn commented 1 year ago

Talking this over with @mallenexpensify I requested a refund from @akamefi202 for $750 since the final amount that should have been paid was $250 and they were paid $1000.

akamefi202 commented 1 year ago

@Christinadobrzyn I will do refund once I paid. It's very soon.

mallenexpensify commented 1 year ago

@Christinadobrzyn , reopening til refund is confirmed, so that I can then pay out

Christinadobrzyn commented 1 year ago

okay monitoring the Upwork job for details about the refund - https://www.upwork.com/nx/wm/workroom/34742476/details

mallenexpensify commented 1 year ago

I paid the other issue, please leave this open til the refund here is processed, thx

Christinadobrzyn commented 1 year ago

@akamefi202 can you let me know when you've issued the refund? Thanks!

akamefi202 commented 1 year ago

@Christinadobrzyn I will do refund on Monday next week.

mallenexpensify commented 1 year ago

@akamefi202 can you please confirm the refund? it doesn't look like we've received yet. Thanks.

image
akamefi202 commented 1 year ago

@Christinadobrzyn @mallenexpensify Sorry for late reply. I was OOO last week. I made the refund and I think we might close this issue now.

mallenexpensify commented 1 year ago

Thanks @akamefi202 , confirming job was refunded.

image

Pretty sure we're good to close this.

akamefi202 commented 1 year ago

@mallenexpensify @Christinadobrzyn Could you please finish the contract on Upwork too?

Christinadobrzyn commented 1 year ago

Thanks @mallenexpensify and @akamefi202 - I closed the contract in Upwork.