[$1000] Split bill - Bill splitting error when in 2 tabs

izarutskaya commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to any group chat
Click the "+" icon and select "Split bill"
Input amount of money and click "Next"
Copy the URL on the browser
Open a new tab -> Paste the copied URL
Click button "Split bill" in 1st tab
Click "< Cash" on modal of 2nd tab
Input amount of money and click "Next" again

Expected Result:

navigate to "Split bill" modal

Actual Result:

After pressing "Next" button, the screen is returned to the amount input modal

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: v1.3.57-5

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/115492554/66efa3f3-7583-4d48-9e84-e30c7c676501

https://github.com/Expensify/App/assets/115492554/0ba5d79e-57cf-4ad7-8a33-8e3d80ac353f

https://github.com/Expensify/App/assets/115492554/82d3048f-c9ae-4e5c-b69f-4df34ecfad97

Expensify/Expensify Issue URL:

Issue reported by: @Le Thi Thu Thuy

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692692134315659

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013cdd1bc133e52a9a
Upwork Job ID: 1699156283918704640
Last Price Increase: 2023-09-19

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot[bot] commented 1 year ago

@johncschuster Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] commented 1 year ago

Job added to Upwork: https://www.upwork.com/jobs/~013cdd1bc133e52a9a

melvin-bot[bot] commented 1 year ago

Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

johncschuster commented 1 year ago

Not overdue. This was just triaged, Melv.

melvin-bot[bot] commented 1 year ago

@johncschuster, @s77rt Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] commented 1 year ago

@johncschuster, @s77rt Eep! 4 days overdue now. Issues have feelings too...

s77rt commented 1 year ago

Not overdue. Looking for proposals

melvin-bot[bot] commented 1 year ago

@johncschuster @s77rt this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

s77rt commented 1 year ago

Not overdue. Still looking for proposals. We are not close Melvin

melvin-bot[bot] commented 1 year ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

s77rt commented 1 year ago

Not overdue. Still looking for proposals

s77rt commented 1 year ago

Same ^ Still looking for proposals

melvin-bot[bot] commented 1 year ago

@johncschuster @s77rt this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

s77rt commented 1 year ago

No proposals yet Melvin

melvin-bot[bot] commented 1 year ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

johncschuster commented 1 year ago

I'm going to raise the bounty

melvin-bot[bot] commented 1 year ago

Upwork job price has been updated to $1000

aimane-chnaif commented 1 year ago

Might have same root cause as https://github.com/Expensify/App/issues/26214

aimane-chnaif commented 1 year ago

Also reported by same reporter

ilkeruyanik commented 1 year ago

I couldn't reproduce it. Can you reproduce it?

s77rt commented 1 year ago

Not overdue. I think this may not be necessary a bug. The money request / split data are stored in Onyx and it's shared across tabs. We may need to refactor the IOU flow to fix this.

melvin-bot[bot] commented 1 year ago

@johncschuster @s77rt this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

Decide whether any proposals currently meet our guidelines and can be approved as-is today
If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

melvin-bot[bot] commented 1 year ago

Current assignee @s77rt is eligible for the Internal assigner, not assigning anyone new.

johncschuster commented 1 year ago

@s77rt you mentioned before that you think we may need to refactor the IOU flow to fix this. Do you know if this has been talked about anywhere? If not, I think we should raise the discussion.

s77rt commented 1 year ago

@hayata-suenaga I think we talked about this and back then we had IOU todos that the refactor was not convenient. Do we still have upcoming IOU work or can we go with the refactor?

The refactor would mainly remove Onyx usage i.e. do not store participants, amount, etc in Onyx

hayata-suenaga commented 1 year ago

I'm checking with the internal team to get opinions on if this refactoring is something we want to pursue.

mvtglobally commented 1 year ago

Issue not reproducible during KI retests. (First week)

melvin-bot[bot] commented 12 months ago

@johncschuster, @s77rt Huh... This is 4 days overdue. Who can take care of this?

s77rt commented 12 months ago

@hayata-suenaga Any updates on how we should handle this?

Still looking for proposals...

johncschuster commented 12 months ago

@hayata-suenaga bump!

hayata-suenaga commented 12 months ago

confirming with @tgolen about this as he is working on a refactoring involving the Money Request flow

melvin-bot[bot] commented 11 months ago

@johncschuster, @s77rt Whoops! This issue is 2 days overdue. Let's get this updated quick!

s77rt commented 11 months ago

I think we agreed on closing this one. Multi tabs support is not a priority for now.

hayata-suenaga commented 11 months ago

forgot to close this one 😓

Expensify / App