search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.5k stars 2.85k forks source link

Web - App focus on compose box even when edit message is present #26319

Open kbecciv opened 1 year ago

kbecciv commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Open the app
  2. Open any report
  3. Send any message
  4. Edit the message
  5. Visit any other report
  6. Revisit report opened in step 2

Expected Result:

App should keep the focus on edit message

Actual Result:

App shifts the focus on main compose box even when report has ongoing edit message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.59.0 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/a22de7a0-3c92-437c-9450-64171707b655

https://github.com/Expensify/App/assets/93399543/17fa5a7c-dc89-4a16-b8dd-ff9166399a2b

Expensify/Expensify Issue URL: Issue reported by: @dhanashree-sawant Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693420650403989

View all open jobs on GitHub

OSBotify commented 1 year ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

hannojg commented 1 year ago

I think that might be introduced by

just not sure if its really a deploy blocker? [app functionality remains imo]

luacmartins commented 1 year ago

Yea, I agree this is NAB. Removing the label.

stitesExpensify commented 1 year ago

@hannojg should I assign this to you since it's related to that other PR?

hannojg commented 1 year ago

I am not sure if this really needs to be fixed?