Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

Web - Next button while creating split bill is not at bottom #26510

Closed kbecciv closed 1 year ago

kbecciv commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Start split bill workflow
  2. After selecting members

Expected Result:

Split bill button should be at bottom

Actual Result:

it's not at bottom

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.61.0 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/ea4c5d6e-1b9e-4f45-a479-5a239fe0b314

image

Expensify/Expensify Issue URL: Issue reported by: @BhuvaneshPatil Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693591772083449

View all open jobs on GitHub

OSBotify commented 1 year ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

BhuvaneshPatil commented 1 year ago

Proposal

Can create a PR ASAP if required

Please re-state the problem that we are trying to solve in this issue.

Next button while creating split bill is not at bottom

What is the root cause of that problem?

Regression from #26179 Because of added ScrollView, it's not taking full height.

What changes do you think we should make in order to solve the problem?

We should make this flex grow

in MoneyRequestConfirmPage

<ScrollView contentContainerStyle={[styles.flexGrow1]}>
                        <ScrollView
                            horizontal
                            contentContainerStyle={[styles.flex1, styles.flexColumn]}
                        >

result -

Screenshot 2023-09-02 at 12 18 31 AM

What alternative solutions did you explore? (Optional)

BhuvaneshPatil commented 1 year ago

Same issue happens in RequestMoney Flow as well

kbecciv commented 1 year ago

Duplicate https://github.com/Expensify/App/issues/26418

kbecciv commented 1 year ago

Closing because of duplicate