[HOLD #26538] [$500] Settings - Using deep link, admin can request money to user workspace chat even though its not allowed

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings->workspaces->any workspace-> members->invite any member
3. Open the new chat created between workspace and user added in step 2
4. Click plus and observe that request money is not present as we are admin
5. In the URL, replace '/r/' with '/request/new/' and observe that it allows to open request money page
6. Complete the process and observe that app raises a request

Expected Result:

App should display 'Hmm its not here' page for request money by deep link by admin in workspace chat as request money option is not available for admin

Actual Result:

App allows to request money by deep link by admin in workspace chat even though request money option is not available for admin

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [ ] Android / Chrome
• [ ] iOS / native
• [ ] iOS / Safari
• [x] MacOS / Chrome / Safari
• [ ] MacOS / Desktop

Version Number: v1.3.61-3

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/115492554/bd1189fd-151c-429a-b57b-d976626d65d9

https://github.com/Expensify/App/assets/115492554/c19de3ee-768d-4c47-be61-c2971efc939a

Expensify/Expensify Issue URL:

Issue reported by: @Dhanashree-Sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692943365255729

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fea0f36079525f3d
• Upwork Job ID: 1698569709503803392
• Last Price Increase: 2023-10-19

Issue Owner

Current Issue Owner: @sophiepintoraetz

[ntdiary]

@pecanoro, there is a small change: as I noted in this comment, we'll be refactoring the money request flow, so I think we can put this issue on hold too? Please feel free to let me know if you have different thoughts. 🤔

[pecanoro]

Ahh got it, I will put in on hold as well/

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[pecanoro]

I see that requesting money seems to be available now for admins both ways (using the + and the link), so should it actually be allowed? I am confused about what's the desired behavior. @sophiepintoraetz Can you maybe bring it up in Slack? It seems admins can request money just fine like anyone else.

[sophiepintoraetz]

Ah, I missed this before heading OOO - let me catch up where the discussion is and come back to this.

[sophiepintoraetz]

Yes, I am going to close this issue out - Admins will be able to request money as a part of the invoicing/bill pay flow we are building.