[HOLD for payment 2023-12-20] [DISTANCE] LOW: PHASE 1: Wave 5 CLEANUP Refactor navigation among screens related to money request features

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.56k stars 2.9k forks source link

[HOLD for payment 2023-12-20] [DISTANCE] LOW: PHASE 1: Wave 5 CLEANUP Refactor navigation among screens related to money request features #26538

Closed hayata-suenaga closed 10 months ago

hayata-suenaga commented 1 year ago

Remove deep-linking support for screens related to money request

In the current code, deep linking to the screen for each step of money request flow is allowed.

There are logics to handle deep linking to a screen that corresponds to a step in the middle of the money request flow. These logics are not scalable and adds additional complexity.

Let's remove the support for deep linking. All screens should be under a single URL and all steps should be completed under that URL.

Relevant Slack discussion: https://expensify.slack.com/archives/C01GTK53T8Q/p1692998235169129

Issue Owner

Current Issue Owner: @anmurali

melvin-bot[bot] commented 11 months ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

tgolen commented 11 months ago

We are churning through the blockers as they come up!

melvin-bot[bot] commented 11 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 11 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.11-25 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/28618

If no regressions arise, payment will be issued on 2023-12-20. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

jjcoffee commented 11 months ago

@tgolen Could you assign me here and add the Bug label so a BZ is assigned too for eventual payment? Thanks!

melvin-bot[bot] commented 11 months ago

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 11 months ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot[bot] commented 11 months ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

tgolen commented 11 months ago

We're good here 😅

Just waiting for this to wrap up and get paid out.

melvin-bot[bot] commented 11 months ago

@tgolen, @anmurali, @jjcoffee Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 10 months ago

@tgolen, @anmurali, @jjcoffee 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

tgolen commented 10 months ago

Still waiting for @anmurali to pay this out.

melvin-bot[bot] commented 10 months ago

@tgolen, @anmurali, @jjcoffee Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

melvin-bot[bot] commented 10 months ago

@tgolen, @anmurali, @jjcoffee 12 days overdue now... This issue's end is nigh!

melvin-bot[bot] commented 10 months ago

@tgolen, @anmurali, @jjcoffee 12 days overdue now... This issue's end is nigh!

jjcoffee commented 10 months ago

@anmurali Happy New Year! Just a friendly bump for payment :bow:

anmurali commented 10 months ago

https://www.upwork.com/nx/wm/offer/100268863

jjcoffee commented 10 months ago

@anmurali Accepted the offer, thanks!

melvin-bot[bot] commented 10 months ago

@tgolen, @anmurali, @jjcoffee Eep! 4 days overdue now. Issues have feelings too...

anmurali commented 10 months ago

Paid.