[HOLD for payment 2023-10-12] [$500] warning: native module for Flipper seems unavailable

[marcaaron]

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015c93e6f743127c98
• Upwork Job ID: 1700290971102027776
• Last Price Increase: 2023-09-22
• Automatic offers:
• situchan | Contributor | 26876532
• bernhardoj | Contributor | 26936772

[melvin-bot[bot]]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A flipper warning in the console.

What is the root cause of that problem?

In NavigationRoot, we use useFlipper to integrate the flipper with react-navigation. However, flipper is only available for native platforms. https://github.com/Expensify/App/blob/b119f9ab54e7cc7272702e270693896b352b61e0/src/libs/Navigation/NavigationRoot.js#L53-L54

What changes do you think we should make in order to solve the problem?

Create a platform-dependent file for native and other platforms.

useFlipper/index.native.js will export useFlipper from react-navigation useFlipper/index.js will export a no-op function

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~015c93e6f743127c98

[melvin-bot[bot]]

Triggered auto assignment to @joekaufmanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[melvin-bot[bot]]

@greg-schroeder, @abdulrahuman5196, @joekaufmanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[joekaufmanexpensify]

Seems like I was accidentally double assigned here. Unassigning, but LMK if there's anything I can help with!

[greg-schroeder]

Nah you're good @joekaufmanexpensify, that was a mistake

[abdulrahuman5196]

Sorry for the delay, I will check on this during the weekend

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[greg-schroeder]

awaiting proposal review

[melvin-bot[bot]]

@greg-schroeder @abdulrahuman5196 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot[bot]]

@greg-schroeder, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[greg-schroeder]

Are you able to take a look @abdulrahuman5196?

[greg-schroeder]

Re-adjusting C+ to someone with a bit more bandwidth!

[melvin-bot[bot]]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[situchan]

I agree with @bernhardoj's proposal. Flipper is only for native so it makes sense to have platform files for useFlipper. 🎀 👀 🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot[bot]]

@greg-schroeder @jasperhuangg @situchan this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[greg-schroeder]

Hey @jasperhuangg can you confirm the assignment here? https://github.com/Expensify/App/issues/26988#issuecomment-1734828990

Thanks!

[jasperhuangg]

Thanks for your patience. Your proposal makes sense to me @bernhardoj, assigned!

[melvin-bot[bot]]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @situchan

[melvin-bot[bot]]

🎯 ⚡️ Woah @situchan / @bernhardoj, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @bernhardoj got assigned: 2023-09-29 06:12:32 Z
• when the PR got merged: 2023-10-02 19:19:22 UTC

On to the next one 🚀

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.77-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/28507

If no regressions arise, payment will be issued on 2023-10-12. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter
• [ ] Contributor that fixed the issue
• [ ] Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment offer (Contributor)
• @situchan requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@situchan] Determine if we should create a regression test for this bug.
• [ ] [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[greg-schroeder]

processing

[greg-schroeder]

Issue Participants:

Contributor: @bernhardoj ($750) C+: @situchan ($750)

[situchan]

We can skip BZ checklist here. It's just console warning

[greg-schroeder]

Yeah, agreed. Closing!