kbecciv commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open the app
Open settings->profile->display name and set long first or last name (do not set both first and last name as long)
Open settings->share code
Double click on name and select the text of display name
Using end points, try to extend the name beyond 3 dots
Observe that now app displays the remaining name but still displays the 3 dots in previous position

Expected Result:

App should either not allow to extend name to select the full name on drag or should remove the 3 dots if name is extended and rest name is displayed

Actual Result:

App allows to extend name to display remaining name in share code and also keeps the 3 dots in same location on mWeb chrome

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.67.2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/be5f01d8-9298-4bc1-9040-dfd98086d3e0

https://github.com/Expensify/App/assets/93399543/102ef0b7-3def-4a9b-8a73-c4a1c7635ed3

Expensify/Expensify Issue URL: Issue reported by: @dhanashree-sawant Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694106668042179

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @johncschuster

s77rt commented 10 months ago

Same ^

s77rt commented 10 months ago

Same ^

melvin-bot[bot] commented 10 months ago

@johncschuster, @s77rt, @neil-marcellini, @tienifr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

s77rt commented 10 months ago

Still on hold

tienifr commented 10 months ago

@s77rt Do you think we should make this Monthly? The upstream repo seems inactive for a while.

johncschuster commented 10 months ago

This is still on hold. I agree we should downgrade the label to monthly while we wait on the upstream issue to be resolved.

s77rt commented 9 months ago

Still on hold

neil-marcellini commented 7 months ago

Still hold for the upstream PR https://github.com/necolas/react-native-web/pull/2584. I did tag the maintainer and ask for review.

s77rt commented 6 months ago

Still no movement on the PR

s77rt commented 5 months ago

Still no action on the PR

johncschuster commented 4 months ago

Same as above. No action on the linked PR.

s77rt commented 3 months ago

Same ^

tienifr commented 3 months ago

@s77rt @johncschuster The upstream repo has been stale for quite a long time. We're holding things for nearly a year. Wdyt about creating a patch in our repo to speed things up?

s77rt commented 3 months ago

@tienifr Let's go with the patch

tienifr commented 3 months ago

@s77rt PR ^

melvin-bot[bot] commented 2 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 2 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.23-0 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/47532

If no regressions arise, payment will be issued on 2024-08-29. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@s77rt requires payment through NewDot Manual Requests
@tienifr requires payment through NewDot Manual Requests
@dhanashree-sawant requires payment (Needs manual offer from BZ)

melvin-bot[bot] commented 2 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@s77rt] Determine if we should create a regression test for this bug.
[ ] [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[x] [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

s77rt commented 2 months ago

The PR that introduced the bug has been identified: n/a (upstream bug)
The offending PR has been commented on: n/a
A discussion in #expensify-bugs has been started: Not needed
Determine if we should create a regression test for this bug: No