[HOLD for payment 2023-10-09] [$500] Android - LHN - Long pressing on stacked avatars results in transparency issue with avatars

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed

Precondition: User has a workspace IOU and a thread in room

1. Launch New Expensify app
2. Long press on workspace IOU row in LHN
3. Long press on the message thread row in LHN

Expected Result:

There is no visual issues with the avatars

Actual Result:

When long pressing on workspace IOU row in LHN, a circular overlay is seen instead of square overlay over the workspace avatar. As for the message thread, the user avatar overlaps with workspace avatar

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android / native
• [ ] Android / Chrome
• [ ] iOS / native
• [ ] iOS / Safari
• [ ] MacOS / Chrome / Safari
• [ ] MacOS / Desktop

Version Number: 1.3.69-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/78819774/2fc43252-9512-45b3-916b-a433d98b28a3

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0181b4bbc15e998db5
• Upwork Job ID: 1702221104396021760
• Last Price Increase: 2023-09-14
• Automatic offers:
• bernhardoj | Contributor | 26771145

[melvin-bot[bot]]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~0181b4bbc15e998db5

[melvin-bot[bot]]

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Long-pressing the LHN item will make the second avatar transparent. This happens on the search page too.

What is the root cause of that problem?

Each item in the list uses PressableWithFeedback which has a default pressDimmingValue of 0.8. Holding down the item will reduce the opacity to 0.8. On Android, having components stacked on top of each other with reduced opacity will not render it correctly. This is the same issue as this one which I explained the issue here or this one.

What changes do you think we should make in order to solve the problem?

The solution is to use needsOffscreenAlphaCompositing on the component that has the opacity applied, which is OpacityView in this case.

Details: We will apply this to both PressableWithSecondaryInteraction of OptionRowLHN and PressableWithFeedback of OptionRow. The needsOffscreenAlphaCompositing will be true only if the icon's length is >= 2.

PressableWithSecondaryInteraction uses PressableWithFeedback internally, so we will pass over the needsOffscreenAlphaCompositing props to PressableWithFeedback.

In PressableWithFeedback, we will pass the needsOffscreenAlphaCompositing props to OpacityView, and in OpacityView, pass the needsOffscreenAlphaCompositing props to Animated.View with the added condition of && shouldRenderOffscreen like we do in OfflineWithFeedback. https://github.com/Expensify/App/blob/95c9e4743f44ca42ece2c6ac56259b911d5feafc/src/components/OfflineWithFeedback.js#L117

<OptionRowLHN
  <PressableWithSecondaryInteraction needsOffscreenAlphaCompositing={props.optionItem.icons.length >= 2}
    <PressableWIthFeedback needsOffscreenAlphaCompositing={props.needsOffscreenAlphaCompositing}

<OptionRow
  <PressableWithFeedback needsOffscreenAlphaCompositing={this.props.option.icons.length >= 2}

<PressableWithFeedback
  <OpacityView needsOffscreenAlphaCompositing={props.needsOffscreenAlphaCompositing}
    <Animated.View needsOffscreenAlphaCompositing={shouldRenderOffscreen && props.needsOffscreenAlphaCompositing}

[narefyev91]

Proposal from @bernhardoj looks good to me https://github.com/Expensify/App/issues/27396#issuecomment-1719637570 thanks for detail explanation! 🎀 👀 🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @MonilBhavsar, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[laurenreidexpensify]

@MonilBhavsar bump ^^

[MonilBhavsar]

Sorry been dealing with a fire. Taking a look now

[MonilBhavsar]

Proposal looks good to me. Looks like we have seen similar issues with only Android in the past. If we can add some test steps to prevent it from happening

[melvin-bot[bot]]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @narefyev91

[melvin-bot[bot]]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @bernhardoj got assigned: 2023-09-20 06:52:11 Z
• when the PR got merged: 2023-09-27 03:21:12 UTC
• days elapsed: 4

On to the next one 🚀

[Pujan92]

@bernhardoj Seems regression of crashes after this PR merged. https://expensify.slack.com/archives/C049HHMV9SM/p1695796696023189

[bernhardoj]

@Pujan92 you're right. Not every OptionRow usage has icons. I have raised a new PR to fix it here.

Thanks for letting us know!

cc: @narefyev91 @MonilBhavsar

[MonilBhavsar]

Thank you!

[melvin-bot[bot]]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @bernhardoj got assigned: 2023-09-20 06:52:11 Z
• when the PR got merged: 2023-09-28 04:37:15 UTC
• days elapsed: 5

On to the next one 🚀

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.75-12 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/27850
• https://github.com/Expensify/App/pull/28319

If no regressions arise, payment will be issued on 2023-10-09. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter
• [ ] Contributor that fixed the issue
• [ ] Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)
• @bernhardoj requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@narefyev91] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@narefyev91] Determine if we should create a regression test for this bug.
• [ ] [@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[laurenreidexpensify]

Payment Summary:

• External issue reporter - Applause N/A
• Contributor that fixed the issue - @narefyev91 expert contributor N/A
• Contributor+ that helped on the issue and/or PR - @bernhardoj = payment issued in Upwork $500

@narefyev91 please advise on checklist above thanks so we can close this out

[laurenreidexpensify]

Bump for checklist @narefyev91

[MonilBhavsar]

Payment Summary:

• External issue reporter - Applause N/A
• Contributor that fixed the issue - @narefyev91 expert contributor N/A
• Contributor+ that helped on the issue and/or PR - @narefyev91 = payment issued in Upwork $500

@narefyev91 please advise on checklist above thanks so we can close this out

@laurenreidexpensify contributor that fixed the issue should be @bernhardoj ?

[situchan]

There was regression - https://github.com/Expensify/App/issues/28317

[narefyev91]

• The PR that introduced the bug has been identified. Link to the PR - current PR was fixing missing functionality and second one already fix regression from initial one
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment - N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion - N/A
• Determine if we should create a regression test for this bug - N/A

[laurenreidexpensify]

https://github.com/Expensify/App/issues/27396#issuecomment-1761498799

@MonilBhavsar sorry typo! corrected

[MonilBhavsar]

Looks like we're good to close this issue?

[laurenreidexpensify]

@MonilBhavsar - can you confirm is this is correct - https://github.com/Expensify/App/issues/28317

if no regression feel free to close

[MonilBhavsar]

@laurenreidexpensify yes, there was a regression coming from this PR which was fixed by @bernhardoj