Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

[HOLD for payment 2023-09-29] [HOLD for payment 2023-09-27] Web - App Fails to Redirect to Announcement Page After Split Bill #27677

Closed kbecciv closed 1 year ago

kbecciv commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to settings > workspace > create new workspace > members.
  2. Invite members to the workspace.
  3. Click on the three dots and open the announcement room.
  4. Click on the plus sign, select split bill, add the desired number, and click on split bill.
  5. The app should redirect to the announcement page, but the split bill page remains open and the app does not redirect.

Expected Result:

After splitting the bill in the workspace, the app should automatically redirect to the announcement page.

Actual Result:

The app fails to redirect to the announcement page after splitting the bill, and the split bill page remains open.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.71.4 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

screen-capture - 2023-09-18T064009.572.webm

https://github.com/Expensify/App/assets/93399543/8c274d89-0bc6-49f1-a73f-e78fa7f48804

Expensify/Expensify Issue URL: Issue reported by: @tewodrosGirmaA Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695037437630339

View all open jobs on GitHub

OSBotify commented 1 year ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

bondydaa commented 1 year ago

hmm was is split bill even showing up in the + list for an #announce room?

From the looks of it after the split is created it creates a new report in the LHN since it is being split between 2 users (so a manual request) not with the workspace.

I haven't been following much with Manual Requests so I'm not 100% sure that option should be showing or not.

bondydaa commented 1 year ago

opened a discussion here to see what others think https://expensify.slack.com/archives/C01GTK53T8Q/p1695057805924489

bondydaa commented 1 year ago

PR to fix has been merged but not yet deployed https://github.com/Expensify/App/pull/27793

melvin-bot[bot] commented 1 year ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 year ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.71-12 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-09-27. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

melvin-bot[bot] commented 1 year ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.72-11 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-09-29. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

melvin-bot[bot] commented 1 year ago

@bondydaa Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] commented 1 year ago

@bondydaa Still overdue 6 days?! Let's take care of this!

bondydaa commented 1 year ago

i think we can close? if there is payment owed somewhere let me know

tewodrosGirmaA commented 1 year ago

@bondydaa I didn't get paid for bug report

tewodrosGirmaA commented 1 year ago

(Reporter Role) Hello, @bondydaa I was wondering if I am eligible for payment even though my issue is marked as "Awaiting Payment" and I have not yet received any payment. The issue has been closed and I would appreciate any clarification on this matter. Thank you.

bondydaa commented 1 year ago

oh doh sorry yes that seems right, lets get a bug zero person involved to handled that, sorry!

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

bondydaa commented 1 year ago

@miljakljajic can you handle paying @tewodrosGirmaA for reporting the bug? thanks!

aimane-chnaif commented 1 year ago

I am also eligible for fixing this bug

miljakljajic commented 1 year ago

Thank you, handling!

miljakljajic commented 1 year ago

sent contracts to you both

tewodrosGirmaA commented 1 year ago

Thank you @miljakljajic I accept the offer

miljakljajic commented 1 year ago

Paid and contracts ended

aimane-chnaif commented 1 year ago

@miljakljajic urgency bonus is applicable here as C+ is also external contributor

miljakljajic commented 1 year ago

Bonus paid, sorry @aimane-chnaif !

aimane-chnaif commented 1 year ago

Thanks so much!