[HOLD for payment 2023-10-18] [$500] Web - Cursor Remains as Hand Icon on Checkbox in "Paid By" Section During Split Bill

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on FAB and select "Send Message"
2. Add two emails and create a group with the two emails
3. Inside the chat, click on the plus sign and select "Split Bill"
4. Add the desired amount and click "Next"
5. Hover over email (cursor is disabled)
6. Hover over the checkbox (cursor changes to hand icon, but remains delectable)

Expected Result:

When hovering over the checkbox in the "Paid By" section during split bill, the cursor should be disabled, just like when hovering over the associated email.

Actual Result:

While hovering over the email, the cursor is properly disabled. However, when hovering over the checkboxes, the cursor changes to a hand icon during split bill.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [ ] Android / Chrome
• [ ] iOS / native
• [ ] iOS / Safari
• [x] MacOS / Chrome / Safari
• [ ] MacOS / Desktop

Version Number: 1.3.73.0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/52729e0f-869a-4063-8694-7243168c3c52

https://github.com/Expensify/App/assets/93399543/1d6eec3e-54f6-429c-aa36-7a95b6febe00

Expensify/Expensify Issue URL: Issue reported by: @tewodrosGirmaA Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695270713412089

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e8f7be88bc37af93
• Upwork Job ID: 1705585682941407232
• Last Price Increase: 2023-09-30
• Automatic offers:
• aimane-chnaif | Reviewer | 27031408
• esh-g | Contributor | 27031411
• tewodrosGirmaA | Reporter | 27031412

[esh-g]

Proposal

Please re-state the issue

Cursor is not disabled in SelectCircle when the option is disabled.

What is the root cause of this issue?

The reason that the cursor is disabled on the rest of the row option is because we are passing the isDisabled prop to the PressableWithFeedback component wrapping the whole OptionRow. https://github.com/Expensify/App/blob/5aa7f6da94ddb1c8ca55a6cce714555f819c1dd0/src/components/OptionRow.js#L199

We are not passing the isDisabled prop to the PressableWithFeedback which wraps the SelectCircle component here: https://github.com/Expensify/App/blob/5aa7f6da94ddb1c8ca55a6cce714555f819c1dd0/src/components/OptionRow.js#L286-L292

What changes do you think should be made to fix this problem?

We should pass the isDisabled prop the same way we pass it to the root PressableWithFeedback of the OptionRow as mentioned in the root cause.

Optional: We can also pass isDisabled prop to the Button element (the one which says 'split' or 'add to group' in the options) for consistency but since I don't see a case where the row with a button will be disabled, this is not required.

What other alternative options did you explore? (Optional)

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The paid by row Pressable is disabled but hand cursor is shown on the selectRow even though it is unclickable

What is the root cause of that problem?

We are not disabling this Pressable https://github.com/Expensify/App/blob/ee023d8ab36dd722a465c89bf4edff1b8e79aadf/src/components/OptionRow.js#L286-L292 like we do here https://github.com/Expensify/App/blob/ee023d8ab36dd722a465c89bf4edff1b8e79aadf/src/components/OptionRow.js#L199

What changes do you think we should make in order to solve the problem?

We should use the same disabling here https://github.com/Expensify/App/blob/ee023d8ab36dd722a465c89bf4edff1b8e79aadf/src/components/OptionRow.js#L288 for this Pressable as well.

What alternative solutions did you explore? (Optional)

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01e8f7be88bc37af93

[melvin-bot[bot]]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot[bot]]

Triggered auto assignment to @tjferriss (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Cursor Remains as Hand Icon on Checkbox in "Paid By" Section During Split Bill

What is the root cause of that problem?

We are using disable props for OptionRow https://github.com/Expensify/App/blob/5aa7f6da94ddb1c8ca55a6cce714555f819c1dd0/src/components/OptionRow.js#L199

But we don't do that for the checkbox https://github.com/Expensify/App/blob/5aa7f6da94ddb1c8ca55a6cce714555f819c1dd0/src/components/OptionRow.js#L286-L293

It causes the consistency

What changes do you think we should make in order to solve the problem?

First, Let's see the transaction report, If we hover detail transactions, it display default cursor

and cancelled task case: https://expensify.slack.com/archives/C049HHMV9SM/p1695024078116809?thread_ts=1694080698.301029&cid=C049HHMV9SM In this case, we also should use the default cursor instead of disabled cursor for all option row (include checkbox) if want to disable that.

To do that:

1. remove disable prop here https://github.com/Expensify/App/blob/5aa7f6da94ddb1c8ca55a6cce714555f819c1dd0/src/components/OptionRow.js#L199
2. replace this style

   (!this.props.onSelectRow || this.props.isDisabled) ? styles.cursorDefault : null,

in https://github.com/Expensify/App/blob/5aa7f6da94ddb1c8ca55a6cce714555f819c1dd0/src/components/OptionRow.js#L208 and add in https://github.com/Expensify/App/blob/5aa7f6da94ddb1c8ca55a6cce714555f819c1dd0/src/components/OptionRow.js#L286

What alternative solutions did you explore? (Optional)

[JawadSadiq01]

Proposal

Please re-state the problem that we are trying to solve in this issue. Cursor Remains as Hand Icon on Checkbox in "Paid By" Section During Split Bill

What is the root cause of that problem? SelectCircle is a re-usable common component. It's only working with one prop name as isChecked. There is nothing else, that tells either its disable or clickable.

What changes do you think we should make in order to solve the problem? You just have to add one more prop into SelectCircle that tells, either its active or disabled.

Do the followings;

1. You have to pass a disable prop with a particular name(I named that isDisabled) from OptionsRow Component(line#291).

<SelectCircle isChecked={this.props.isSelected} isDisabled={this.props.isDisabled} />

2. Apply this isDisable prop inside the SelectCircle Component

import React from 'react';
import {View} from 'react-native';
import PropTypes from 'prop-types';
import styles from '../styles/styles';
import Icon from './Icon';
import * as Expensicons from './Icon/Expensicons';
import themeColors from '../styles/themes/default';

const propTypes = {
    /** Should we show the checkmark inside the circle */
    isChecked: PropTypes.bool,
    isDisabled: PropTypes.bool,
};

const defaultProps = {
    isChecked: false,
    isDisabled: false,
};

function SelectCircle(props) {
    return (
        <View style={[styles.selectCircle, styles.alignSelfCenter, props.isDisabled ? styles.disableSelectCircle : '']}>
            {props.isChecked && (
                <Icon
                    src={Expensicons.Checkmark}
                    fill={themeColors.iconSuccessFill}
                />
            )}
        </View>
    );
}

SelectCircle.propTypes = propTypes;
SelectCircle.defaultProps = defaultProps;
SelectCircle.displayName = 'SelectCircle';

export default SelectCircle;

3. Make another style object(I name as disabledSelectCircle) inside styles.js file

disableSelectCircle: {
        ...cursor.cursorDisabled,
},

What alternative solutions did you explore? (Optional) NA

Video Attachment

https://github.com/Expensify/App/assets/135354140/adf46228-aa7c-4670-bb9a-738dcb18fdca

[tjferriss]

@muttmuure it looks like MelvinBot assigned me after you. I'm going to un-assign myself.

[astrohunter62]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The cursor remains a hand icon when hovering over the checkbox in the 'Paid By' section during the Split bill process.

What is the root cause of that problem?

In the OptionRow component, there's a missing pass of the 'disabled' props to the SelectCircle component wrapped within PressableWithFeedback.

What changes do you think we should make in order to solve the problem?

We can pass the 'disabled' props to PressableWithFeedback.

<PressableWithFeedback
    onPress={() => this.props.onSelectedStatePressed(this.props.option)}
    accessibilityRole={CONST.ACCESSIBILITY_ROLE.CHECKBOX}
    accessibilityLabel={CONST.ACCESSIBILITY_ROLE.CHECKBOX}
    disabled={this.state.isDisabled}
>
    <SelectCircle isChecked={this.props.isSelected} />
</PressableWithFeedback>

Result:

28064(chrome).webm

28064(safari).webm

[melvin-bot[bot]]

@muttmuure, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@muttmuure, @aimane-chnaif Still overdue 6 days?! Let's take care of this!

[melvin-bot[bot]]

@muttmuure, @aimane-chnaif 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[muttmuure]

@aimane-chnaif 3 proposals to review when you have time. Thank you!

[aimane-chnaif]

@esh-g's proposal looks good to me. 🎀 👀 🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot[bot]]

📣 @aimane-chnaif 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[melvin-bot[bot]]

📣 @esh-g 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot[bot]]

📣 @tewodrosGirmaA 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[lakchote]

@esh-g's proposal LGTM.

[esh-g]

Thanks @lakchote Here is the PR: https://github.com/Expensify/App/pull/28850 🚀

cc @aimane-chnaif

[melvin-bot[bot]]

🎯 ⚡️ Woah @aimane-chnaif / @esh-g, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @esh-g got assigned: 2023-10-05 05:53:20 Z
• when the PR got merged: 2023-10-09 13:23:06 UTC

On to the next one 🚀

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.80-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/28850

If no regressions arise, payment will be issued on 2023-10-18. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter
• [ ] Contributor that fixed the issue
• [ ] Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @esh-g requires payment offer (Contributor)
• @aimane-chnaif requires payment offer (Reviewer)
• @tewodrosGirmaA requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [ ] [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[lakchote]

@aimane-chnaif please complete the checklist in order to close the issue.

[aimane-chnaif]

• [x] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/25564
• [x] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/25564/files#r1365623813
• [x] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [x] Determine if we should create a regression test for this bug.
• [x] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

No need regression test

[aimane-chnaif]

@lakchote can you please re-open the issue? I haven't received payment yet

[tewodrosGirmaA]

@lakchote can you please re-open the issue? I haven't received payment yet

[muttmuure]

Contracts extended

[aimane-chnaif]

@muttmuure there's contract already - https://github.com/Expensify/App/issues/28064#issuecomment-1748110387

[aimane-chnaif]

This is eligible for bonus

[muttmuure]

Bonus sent

[tewodrosGirmaA]

Hello @muttmuure, I have not received payment?

[tewodrosGirmaA]

Hello @muttmuure, I have not received payment?

[esh-g]

@muttmuure I still haven't received the payment as well...

[muttmuure]

Oops, sorry!

[muttmuure]

Offers sent

[tewodrosGirmaA]

Offers sent

Thank you @muttmuure I accepted the offer

[esh-g]

Thanks, accepted the offer @muttmuure

[esh-g]

@muttmuure Please also make sure to check the bonus... thanks

[lakchote]

@muttmuure were you able to check the bonus? Thanks!

[muttmuure]

$750 inc Bonus paid to @esh-g @tewodrosGirmaA also paid