Closed lanitochka17 closed 1 year ago
Triggered auto assignment to @stephanieelliott (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
Platforms
in OP are ✅)I think the testing step are misunderstood the light mode is referred to the theme prefference in App (NOT YET IMPLEMENTED) not the system theme preference
I'm a little confused about what needs to happen here and why it wasn't called out as a regression if it was caused by the linked PR.
@ishpaul777 just want to make sure I understand -- are you saying that this actually isn't a bug, and is controlled by the app preferences?
So the theme preference is not yet implemented so this isn't a bug, as far as I know. cc @s77rt
Although the QA did switch to light mode, they may need to refresh the App to have it load in light mode. But that won't happen as the light mode is not supported yet.
For reference it would have looked like this
The PR QA test steps for light mode can be ignored (we shouldn't have added those). Sorry for the confusion.
@stephanieelliott We are good to close this.
@stephanieelliott Whoops! This issue is 2 days overdue. Let's get this updated quick!
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when executing PR https://github.com/Expensify/App/pull/27920
Action Performed:
Expected Result:
Rgb value is 235, 230, 223
Actual Result:
Rgb value in light mode is rgb(26,61,50)
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.74-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/efc46659-f318-49a5-814b-402846168bc5
https://github.com/Expensify/App/assets/78819774/1792f5b1-9752-454a-975f-6f5bd1bcf2a6
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub