search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.36k stars 2.78k forks source link

[$500] Web – Request Money - Duplicated chats do not appear in the LHN #28491

Closed lanitochka17 closed 11 months ago

lanitochka17 commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in with the same account in the main testing device and a secondary device
  3. Disable the internet connection in the main testing device
  4. In the secondary device Split a bill with 2 users, this should create a new group and 2 new 1:1 conversations
  5. In the main testing device (should be offline) create the SAME split bill with the 2 users
  6. Enable the internet connection in the main testing device. The split bill request will be sent and you will get an error in the main device only

Expected Result:

Duplicated chats appear in the LHN

Actual Result:

Duplicated chats do not appear in the LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.75-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/78819774/efdeb63e-f992-4aa7-8ff0-d7d124e058eb

Expensify/Expensify Issue URL:

Issue reported by: Applausec - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0103fc103b68458f78
  • Upwork Job ID: 1709188061816893440
  • Last Price Increase: 2023-10-17
melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

sophiepintoraetz commented 12 months ago

Checking the label logic here before confirming next step.

melvin-bot[bot] commented 12 months ago

Job added to Upwork: https://www.upwork.com/jobs/~0103fc103b68458f78

melvin-bot[bot] commented 12 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

melvin-bot[bot] commented 12 months ago

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 12 months ago

Bug0 Triage Checklist (Main S/O)

sophiepintoraetz commented 12 months ago

@sonialiap - just need a hand with baby sitting this issue whilst I'm OOO - there are no proposals yet but I'll take it back on 17 Oct if it's still going then!

melvin-bot[bot] commented 11 months ago

@Ollyws, @sonialiap, @sophiepintoraetz Eep! 4 days overdue now. Issues have feelings too...

Ollyws commented 11 months ago

Awaiting proposals...

melvin-bot[bot] commented 11 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Ollyws commented 11 months ago

Still awaiting proposals...

melvin-bot[bot] commented 11 months ago

@Ollyws @sonialiap @sophiepintoraetz this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

MrMuzyk commented 11 months ago

@lanitochka17

Hey, I wasn't able to reproduce this issue. Can you confirm that this is still a valid issue?

https://github.com/Expensify/App/assets/23487612/98ebb541-bc85-46f3-90a0-b0ce7e597869

melvin-bot[bot] commented 11 months ago

@Ollyws, @sonialiap, @sophiepintoraetz Whoops! This issue is 2 days overdue. Let's get this updated quick!

MrMuzyk commented 11 months ago

@lanitochka17

With help of my team member @roksanaz I was able to reproduce it once and so did she. It doesn't seem to happen everytime. However the error that we both recieved said - Unexpected error creating this chat, please try again later. There is a previously existing chat between these users. which seems to be reasonable behaviour. Here is a response I got this one time.

    "code": 666,
    "jsonCode": 666,
    "type": "Expensify\\Libs\\Error\\ExpError",
    "UUID": "61F4D57E-F025-4289-B7F0-483FA8EB820D",
    "message": "There is a previously existing chat between these users.",
    "title": "",
    "data": {
        "onyxData": [
            {
                "onyxMethod": "merge",
                "key": "report_8615329571914203",
                "value": {
                    "errorFields": {
                        "createChat": {
                            "1697460612565675": "There is a previously existing chat between these users."
                        }
                    }
                }
            },
            {
                "onyxMethod": "merge",
                "key": "report_8981857230926563",
                "value": {
                    "errorFields": {
                        "createChat": {
                            "1697460612565666": "There is a previously existing chat between these users."
                        }
                    }
                }
            },
            {
                "onyxMethod": "merge",
                "key": "report_3435898379201309",
                "value": {
                    "errorFields": {
                        "createChat": {
                            "1697460612565667": "There is a previously existing chat between these users."
                        }
                    }
                }
            }
        ]
    },
    "htmlMessage": "",
    "onyxData": [
        {
            "onyxMethod": "merge",
            "key": "report_8615329571914203",
            "value": {
                "errorFields": {
                    "createChat": {
                        "1697460612565675": "There is a previously existing chat between these users."
                    }
                }
            }
        },
        {
            "onyxMethod": "merge",
            "key": "report_8981857230926563",
            "value": {
                "errorFields": {
                    "createChat": {
                        "1697460612565666": "There is a previously existing chat between these users."
                    }
                }
            }
        },
        {
            "onyxMethod": "merge",
            "key": "report_3435898379201309",
            "value": {
                "errorFields": {
                    "createChat": {
                        "1697460612565667": "There is a previously existing chat between these users."
                    }
                }
            }
        }
    ],
    "requestID": "81706d1ae90dbf35-WAW"
}

Given the BE response I'm not sure if behaviour described in this issue is a bug and expected behaviour is a valid one. Expected behaviour in this issues is - Duplicated chats appear in the LHN where BE clearly states that you can't have duplicated chats.

lanitochka17 commented 11 months ago

@MrMuzyk Hello Thank you for the clarification

sonialiap commented 11 months ago

I'm OOO Oct 16-23 and we don't need two BZ on this issue, unassigning myself

melvin-bot[bot] commented 11 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

sophiepintoraetz commented 11 months ago

@MrMuzyk and @roksanaz, thank you for taking the time to break down your findings, I agree with you that the expected behaviour in the OP is incorrect. I'm closing this issue as not a bug.