[HOLD for #27665][$500] Personal detail - App not dismiss RHN when click outside

izarutskaya commented 9 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Click Setting => Profile => Personal detail
Click Date of birth
Click year to open year picker
Click outside RHN, Observe that RHN is not dismissed

Expected Result:

RHN dismissed when click outside

Actual Result:

RHN is not dismissed but it goes back one step

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

Version Number: v1.3.77-0

Reproducible in staging?: y

Reproducible in production?: y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/115492554/cc1a0c13-1e71-4c83-95dc-ec31e5debef9

https://github.com/Expensify/App/assets/115492554/c2aa61de-8119-429f-af0d-179bd7c69cc8

https://github.com/Expensify/App/assets/115492554/5cb375bf-e636-4d5f-bc7a-7b056f91f26d

Expensify/Expensify Issue URL:

Issue reported by: @namhihi237

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696265759646699

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0119761391c95f3447
Upwork Job ID: 1709254523081965568
Last Price Increase: 2023-10-03

melvin-bot[bot] commented 9 months ago

Job added to Upwork: https://www.upwork.com/jobs/~0119761391c95f3447

melvin-bot[bot] commented 9 months ago

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 9 months ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot[bot] commented 9 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

ishpaul777 commented 9 months ago

same root cause as #27665, YearPicker is a modal not a RHN screen with route

cooldev900 commented 9 months ago

how about changing route when the modal is closed, not hidden? https://github.com/Expensify/App/blob/e30dce19672085a2c8b34576d2fe33ebd8aee249/src/components/NewDatePicker/CalendarPicker/index.js#L237

<YearPickerModal
                    isVisible={this.state.isYearPickerVisible}
                    years={this.state.years}
                    currentYear={currentYearView}
                    onYearChange={this.onYearSelected}
                    onClose={() => Navigation.navigate()}
                    onHide={() => this.setState({isYearPickerVisible: false})}
                />

https://github.com/Expensify/App/blob/e30dce19672085a2c8b34576d2fe33ebd8aee249/src/components/NewDatePicker/CalendarPicker/YearPickerModal.js#L55

<Modal
            type={CONST.MODAL.MODAL_TYPE.RIGHT_DOCKED}
            isVisible={props.isVisible}
            onClose={props.onClose}
            onModalHide={props.onHide}
            hideModalContentWhileAnimating
            useNativeDriver
        >
        ...
        </Modal>

ishpaul777 commented 9 months ago

thats a reasonalble Idea, But we are migrating the modal to a route in #27665 so this issue will be resoloved upstream.

melvin-bot[bot] commented 9 months ago

@Ollyws, @sonialiap Huh... This is 4 days overdue. Who can take care of this?

sonialiap commented 9 months ago

Sounds like we can put this one on hold for https://github.com/Expensify/App/issues/27665. I'm going to update this issue to be on hold but correct me if I misunderstood

sonialiap commented 9 months ago

I'm moving this to "Weekly" for now because I'll be OOO until the 22nd and no need for melvin to ping us here until https://github.com/Expensify/App/issues/27665 is resolved and I'm back to check on it

sonialiap commented 8 months ago

Still on hold for https://github.com/Expensify/App/issues/27665

sonialiap commented 8 months ago

Still on hold for https://github.com/Expensify/App/issues/27665

sonialiap commented 8 months ago

Still on hold for https://github.com/Expensify/App/issues/27665

sonialiap commented 7 months ago

Still on hold for https://github.com/Expensify/App/issues/27665

sonialiap commented 7 months ago

Still on hold. PR up but not yet deployed

sonialiap commented 7 months ago

Still on hold, the PR is still in progress https://github.com/Expensify/App/pull/31729