[HOLD for payment 2023-11-07] [$500] Scan - App displays 'Split' in title on back from scan request money request

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Click on plus and click request money->scan
3. Select any file
4. Observe now it displays 'Manual' in header, select any user
5. Click on back and observe that now it displays 'Split' in header even though there is no option to add other user to split

Expected Result:

App should not display 'Split' in header when coming back from scan request as we don't allow adding user for split in scan request

Actual Result:

App displays 'Split' in header when coming back from scan request even though we don't allow adding user for split in scan request

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android / native
• [x] Android / Chrome
• [x] iOS / native
• [x] iOS / Safari
• [x] MacOS / Chrome / Safari
• [x] MacOS / Desktop

Version Number: 1.3.77.2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/ba11ac46-fd7d-4fff-b140-61705ec3b51f

https://github.com/Expensify/App/assets/93399543/2a3bcc2f-7528-46e7-8d86-a723b5313369

https://github.com/Expensify/App/assets/93399543/00a95b85-4f98-4e9b-99b1-2a2246dd0ba5

https://github.com/Expensify/App/assets/93399543/0b9a48dc-886d-473f-b30b-2eb1a257ff0d

https://github.com/Expensify/App/assets/93399543/7232ee71-e30c-41d3-920a-e912dc9f143e

https://github.com/Expensify/App/assets/93399543/9669b6b8-ab02-48d4-a411-7d6fd3c116a6

https://github.com/Expensify/App/assets/93399543/5f9e8d4f-c20a-4521-9d08-fa72e32f1ec5

Expensify/Expensify Issue URL: Issue reported by: @dhanashree-sawant Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696334987842689

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011c86077fd238d8d9
• Upwork Job ID: 1709312814973755392
• Last Price Increase: 2023-10-10
• Automatic offers:
• fedirjh | Reviewer | 27263280
• DylanDylann | Contributor | 27263283
• dhanashree-sawant | Reporter | 27263284

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot[bot]]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot[bot]]

📣 @dhanashree-sawant 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[trjExpensify]

Wahoo! Let's get the PR going :)

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.93-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/29936

If no regressions arise, payment will be issued on 2023-11-07. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [x] External issue reporter
• [x] Contributor that fixed the issue
• [x] Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment offer (Reviewer)
• @DylanDylann requires payment offer (Contributor)
• @dhanashree-sawant requires payment offer (Reporter)

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@fedirjh] Determine if we should create a regression test for this bug.
• [ ] [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[fedirjh]

BugZero Checklist:

• [x] Link to the PR: https://github.com/Expensify/App/pull/25564
• [x] Link to comment: https://github.com/Expensify/App/pull/25564#discussion_r1380620687
• [x] Link to discussion: No need to add anything to the checklist. The PR is very complicated, so it's possible that these bugs were not noticed.
• [x] Determine if we should create a regression test for this bug: Yes

Regression Test Proposal

Scan request:

1. Open the app
2. Click on plus and click request money -> scan
3. Select any file
4. Verify it displays Scan in the header.
5. Select any user, you will be taken to a confirmation page.
6. Click on back to return to the participant selector page.
7. Verify that it displays Scan in the header

Manual/Split request:

1. Open the app
2. Click on plus and click request money -> manual
3. Enter amount and press next
4. Verify it displays Manual in the header.
5. Select any user, you will be taken to a confirmation page.
6. Click on back to return to the participant selector page.
7. Verify that it displays Manual in the header
8. Click the split button

9. Verify that the header message is changed to Split

   • Do we agree 👍 or 👎

[melvin-bot[bot]]

@amyevans, @trjExpensify, @fedirjh, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot[bot]]

@amyevans, @trjExpensify, @fedirjh, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

[trjExpensify]

Confirming payments as follows:

$500 to @DylanDylann for the fix $500 to @fedirjh for C+ $50 to @dhanashree-sawant for the bug report

PR took more than 3 days, so #urgency bonus doesn't apply.

[trjExpensify]

Thanks for those, @fedirjh! Created an issue for Applause.

[trjExpensify]

Settled up with you all. Thanks!

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.