[$500] [Form Provider Refactor] AddressPage

[luacmartins]

Coming from https://github.com/Expensify/App/issues/25397#issuecomment-1743272245, we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.

This issue is specific to refactoring src/pages/settings/Profile/PersonalDetails/AddressPage.js

cc @kowczarz

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012aba0c7431d96aff
• Upwork Job ID: 1709704418695823360
• Last Price Increase: 2023-10-05

Issue Owner

Current Issue Owner: @kowczarz

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~012aba0c7431d96aff

[melvin-bot[bot]]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

[melvin-bot[bot]]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kowczarz]

Hello! I'm Kamil Owczarz from Software Mansion, the expert agency and I would like to work on this task.

[melvin-bot[bot]]

Current assignee @thesahindia is eligible for the External assigner, not assigning anyone new.

[alexpensify]

@kowczarz -- any update on the proposal for this GitHub?

[luacmartins]

Similar to the hook refactor, I don't think we need a proposal for this one since the refactors are straightforward and follow the same pattern. @kowczarz authored the original refactor PR, so I think they are best suited to work on this as well :)

[alexpensify]

Thanks @luacmartins, sounds like a plan!

[alexpensify]

Update: Waiting for the PR to fix this issue

[luacmartins]

We're still working on other forms. Will get to this one soon!

[melvin-bot[bot]]

@alexpensify @luacmartins @thesahindia @kowczarz this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[kowczarz]

Still working on other forms.

[kowczarz]

https://github.com/Expensify/App/pull/29983 is a blocker here, as soon as it will be merged I will start working on this issue.

[alexpensify]

Perfect, thanks @kowczarz for the update!

[alexpensify]

Daily Update: It looks like the PR mentioned above has some feedback that needs review.

[melvin-bot[bot]]

@alexpensify @luacmartins @thesahindia @kowczarz this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[alexpensify]

Daily update: The PR is moving forward now.

[melvin-bot[bot]]

@alexpensify, @luacmartins, @thesahindia, @kowczarz Whoops! This issue is 2 days overdue. Let's get this updated quick!

[luacmartins]

Holding PR is merged. We're good to work on this

[alexpensify]

@kowczarz - all set, the blocker should be clear now. Thanks for reviewing again.

[melvin-bot[bot]]

@alexpensify @luacmartins @thesahindia @kowczarz this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot[bot]]

Current assignee @thesahindia is eligible for the Internal assigner, not assigning anyone new.

[alexpensify]

@luacmartins should we make this external again? Thanks for the update!

[melvin-bot[bot]]

Current assignee @thesahindia is eligible for the External assigner, not assigning anyone new.

[alexpensify]

@luacmartins bumping again, should we make this external?

[luacmartins]

It seems to be external already and we got SWM working on it

[luacmartins]

@kowczarz is still working on related issues

[kowczarz]

This one is handled by @cdOut in https://github.com/Expensify/App/pull/30568

[alexpensify]

Thank you @kowczarz for the update!

[alexpensify]

Daily Update: PR is moving forward!

[melvin-bot[bot]]

@alexpensify, @luacmartins, @thesahindia, @kowczarz 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot[bot]]

@alexpensify, @luacmartins, @thesahindia, @kowczarz 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot[bot]]

@alexpensify, @luacmartins, @thesahindia, @kowczarz 12 days overdue. Walking. Toward. The. Light...

[alexpensify]

Catching up from being OOO, it looks like the PR was reverted due to deploy concerns. @cdOut and @kowczarz - can you please share the next steps here and how we can keep moving forward? Thanks!

[alexpensify]

@cdOut and @kowczarz - any update here?

[cdOut]

There was a little bit of confusion due to multiple pages being named similarly. This issue will be done alongside this one, since they both address the same component, AddressForm: https://github.com/Expensify/App/issues/32064. After that one is merged, this one will also be refactored.

[melvin-bot[bot]]

This issue has not been updated in over 14 days. @alexpensify, @luacmartins, @thesahindia, @kowczarz eroding to Weekly issue.

[alexpensify]

Thank you @cdOut for the update!

[alexpensify]

Daily Update: The PR is in draft mode.

[alexpensify]

Daily Update: The PR is ready for review!

[alexpensify]

Ok, now we will need to wait for automation here.

[alexpensify]

@luacmartins and @thesahindia it looks like automation didn't kick in here. Is this one complete? If yes, I'll need to start the manual payment process. Thanks!

[cdOut]

It is merged and completed.

[alexpensify]

Thank you @cdOut for the update!

---

Here is the payment summary:

• External issue reporter - N/A
• Contributor that fixed the issue - @cdOut Software Mansion
• Contributor+ that helped on the issue and/or PR - @thesahindia $500

Upwork Job: N/A

---

Heads up, I will be offline from Friday, December 22, to Thursday, January 4, 2024. I will not be actively watching over this GitHub during that period. If anything urgent is needed here, please ask for help in the #expensify-open-source Slack Room-- thanks!

[alexpensify]

No update, waiting for confirmation that @thesahindia has submitted a payment request in Chat before I close this one.

[melvin-bot[bot]]

This issue has not been updated in over 15 days. @alexpensify, @luacmartins, @thesahindia, @kowczarz eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[alexpensify]

@thesahindia can you please confirm if you submitted a payment request? After, I can close this GH - thanks!

[thesahindia]

Sorry for the delay. I have submitted the payment request. We can close this.

[alexpensify]

Awesome, thank you for the update!