[HOLD for payment 2023-10-30] Distance IOU - Map preview is not extended to full view on RHP

lanitochka17 commented 11 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/26307

Action Performed:

Go to https://staging.new.expensify.com/
Go to + > Request money > Distance

Expected Result:

Map preview is extended to full view on RHP

Actual Result:

Map preview is not extended to full view on RHP

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.78-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/78819774/40cc133f-4746-480e-bc41-018a3b1c477c

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

melvin-bot[bot] commented 11 months ago

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 11 months ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

OSBotify commented 11 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot[bot] commented 11 months ago

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

s-alves10 commented 11 months ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

On distance request page, map preview is not extended to full view on RHP

What is the root cause of that problem?

In the newly created DraggableList component, we wrap all contents inside ScrollView as you can see https://github.com/Expensify/App/blob/eb5e1e82e1745d13d06d32f681c5fe81efb0d697/src/components/DraggableList/index.tsx#L73

ScrollView has style flex1 so that it covers all possible space, but this ScrollView component has a content container in it. Please refer https://reactnative.dev/docs/scrollview#contentcontainerstyle. We doesn't set the style of this content container so the container doesn't cover the possible space.

This is the root cause

What changes do you think we should make in order to solve the problem?

Set the contentContainerStyle of ScrollView to styles.flex1

This works as expected

Result

![image](https://github.com/Expensify/App/assets/126839717/59d9d225-600e-49bb-9d5a-f48138767d48)

What alternative solutions did you explore? (Optional)

hayata-suenaga commented 11 months ago

tagged PR author (SWM engineer) here and C+ here

situchan commented 11 months ago

What will be max height on mobile?

Simulator Screenshot - iPhone 14 Pro - 2023-10-05 at 19 51 29

hayata-suenaga commented 11 months ago

@shawnborton since you were involved in the Distance Request screen design,

should the map be stretched out to fill the remaining space or the current heigh is okay?

hayata-suenaga commented 11 months ago

Please check the hight here

s-alves10 commented 11 months ago

I think min-height: 300, max-height: 500

situchan commented 11 months ago

I was also thinking to add flex to contentContainerStyle but web and native are implemented differently so it won't work on native. We should confirm if map should be stretched on native as well.

mountiny commented 11 months ago

This is a new feature/ change and the behaviour is not blocking user so I am removing the blocker label and the original PR author can address the changes based on design feedback.

Let me know if you disagree about the blocker status. thanks!

kosmydel commented 11 months ago

I was also thinking to add flex to contentContainerStyle but web and native are implemented differently so it won't work on native. We should confirm if map should be stretched on native as well.

This one solves the issue. Preparing PR with that change.

s-alves10 commented 11 months ago

The mentioned change doesn't solve the issue on natives

s-alves10 commented 11 months ago

For native platforms, we need to change the DraggableList as follows

    return (
        <DraggableFlatList
            ref={ref}
            contentContainerStyle={styles.flex1}
            containerStyle={styles.flex1}
            ListFooterComponentStyle={styles.flex1}
            // eslint-disable-next-line react/jsx-props-no-spreading
            {...viewProps}
        />
    );

shawnborton commented 11 months ago

should the map be stretched out to fill the remaining space or the current heigh is okay?

Yes, it should fill the available space. I feel like we have multiple threads/places where we've given feedback about the correct design and behavior of this page. @trjExpensify or @JmillsExpensify can you help shed some light on that here?

neil-marcellini commented 11 months ago

Reminder: please add distance related issues to the project. It helps us keep track of them.

trjExpensify commented 11 months ago

Yes, it should fill the available space. I feel like we have multiple threads/places where we've given feedback about the correct design and behavior of this page. @trjExpensify or @JmillsExpensify can you help shed some light on that here?

It looks like this was a regression found when executing this PR, which is linked to the issue that references the main discussion on deciding the design of this: https://expensify.slack.com/archives/C05DWUDHVK7/p1694509495995009

While there are a healthy number of PR reviews on that PR, and it was shared in the thread, there wasn't a review requested from someone on the design team. So I think this is just another reminder to make sure that happens, and this would likely have been caught. CC: @hayata-suenaga

neil-marcellini commented 11 months ago

@pecanoro I can take this over if you like since it's a distance requests issue.

pecanoro commented 11 months ago

@neil-marcellini Nah, it's fine, it seems like an easy issue to review.

pecanoro commented 11 months ago

@neil-marcellini Nah, it's fine, it seems like an easy issue to review.

melvin-bot[bot] commented 10 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 10 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.88-11 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/28922

If no regressions arise, payment will be issued on 2023-10-30. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot[bot] commented 10 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@pecanoro] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@pecanoro] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@pecanoro] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@pecanoro] Determine if we should create a regression test for this bug.
[ ] [@pecanoro] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

pecanoro commented 10 months ago

Ah we can close this one since it was a regression and it was fixed by the original person

Expensify / App