[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] No margin top on zip code input

m-natarajan commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.80-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @Krishna2323 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696629077014029

Action Performed:

Open settings > workspaces > select any workspace > bank account > connect manually
Complete step 1
Observe there is space above every input but not on zip code input
Expected Result:

There should be margin top on zip code input like all other inputs.

Actual Result:

There is no margin top on zip code input.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?
- [x] Android: Native
- [x] Android: mWeb Chrome
- [x] iOS: Native
- [x] iOS: mWeb Safari
- [x] MacOS: Chrome / Safari
- [x] MacOS: Desktop

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/38435837/68544cbe-b35d-4143-84e2-befbe4ec4670

Android: mWeb Chrome

iOS: Native

https://github.com/Expensify/App/assets/38435837/975e1442-13a6-477c-9a7c-1478c1ad47b4

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/38435837/a73dc504-dc23-4a9f-a8e8-47924dfd20c1 ![Full Screen #1](https://github.com/Expensify/App/assets/38435837/49b6fb27-2236-4c1d-b26c-43ed66b3938a)

MacOS: Desktop

![zip_code_margin](https://github.com/Expensify/App/assets/38435837/b9b21f3a-f9eb-477b-bfcc-26047c360876)

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0170820d98137d62bd
Upwork Job ID: 1711538110955954176
Last Price Increase: 2023-10-10
Automatic offers:

s77rt | Reviewer | 27165311
Krishna2323 | Contributor | 27165313
Krishna2323 | Reporter | 27165317

Issue Owner

Current Issue Owner: @MitchExpensify

Issue Owner

Current Issue Owner: @MitchExpensify

melvin-bot[bot] commented 1 year ago

Job added to Upwork: https://www.upwork.com/jobs/~0170820d98137d62bd

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

Krishna2323 commented 1 year ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

No margin top on zip code input

What is the root cause of that problem?

We are not adding containerStyles={[styles.mt4]} prop to zip code input, but we are adding this to every input.

https://github.com/Expensify/App/blob/b2d1c6f14f6eea1f1ccbaf3065a200f1094656f8/src/pages/ReimbursementAccount/AddressForm.js#L135-L148

What changes do you think we should make in order to solve the problem?

We need to just pass containerStyles={[styles.mt4]} prop to zip code input.

if "mt4" seems too much, we can use mt2.

Option 2

If we don't need to add margin top to input if there is a option selector above it then we should remove <View style={styles.formSpaceVertical} /> above State input on personal details home address page.

Result

PiyushChandra17 commented 1 year ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

No margin top on zip code input

What is the root cause of that problem?

We are not passing any style in the text input of zip code here,

https://github.com/Expensify/App/blob/562f9d8ff66d1e90285df088fa785c9638aa3861/src/pages/ReimbursementAccount/AddressForm.js#L135-L148

What changes do you think we should make in order to solve the problem?

We need to wrap TextInput component in View, and add the styles.mt4 style.

<View style={[styles.mt4]}>
    <TextInput
        inputID={props.inputKeys.zipCode}
        shouldSaveDraft={props.shouldSaveDraft}
        label={props.translate('common.zip')}
        accessibilityLabel={props.translate('common.zip')}
        accessibilityRole={CONST.ACCESSIBILITY_ROLE.TEXT}
        keyboardType={CONST.KEYBOARD_TYPE.NUMBER_PAD}
        value={props.values.zipCode}
        defaultValue={props.defaultValues.zipCode}
        onChangeText={(value) => props.onFieldChange({zipCode: value})}
        errorText={props.errors.zipCode ? props.translate('bankAccount.error.zipCode') : ''}
        maxLength={CONST.BANK_ACCOUNT.MAX_LENGTH.ZIP_CODE}
        hint={props.translate('common.zipCodeExampleFormat', {zipSampleFormat: CONST.COUNTRY_ZIP_REGEX_DATA.US.samples})}
    />
</View>

What alternative solutions did you explore? (Optional)

NA

Result:

https://github.com/Expensify/App/assets/47579287/631f97cd-458c-43b9-93c1-162e2094ec65

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

s77rt commented 1 year ago

I'm not sure whether this is a bug or intended. Asked in Slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1696967863302429

MitchExpensify commented 1 year ago

Holding on an internal discussion

Krishna2323 commented 1 year ago

@s77rt, we can proceed here with mt2(8px) margin on top as discussed in slack.

s77rt commented 1 year ago

@Krishna2323 Thanks for the proposal! Your RCA is correct and the solution has been agreed on by design team. Let's get this fixed!

🎀 👀 🎀 C+ reviewed Link to proposal

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @amyevans, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

s77rt commented 1 year ago

@PiyushChandra17 Thanks for the proposal. Unfortunately it's a dupe.

melvin-bot[bot] commented 1 year ago

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

melvin-bot[bot] commented 1 year ago

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

melvin-bot[bot] commented 1 year ago

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

melvin-bot[bot] commented 1 year ago

🎯 ⚡️ Woah @s77rt / @Krishna2323, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

when @Krishna2323 got assigned: 2023-10-12 18:09:19 Z
when the PR got merged: 2023-10-12 22:58:27 UTC

On to the next one 🚀

melvin-bot[bot] commented 1 year ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 year ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.84-10 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/29480

If no regressions arise, payment will be issued on 2023-10-23. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@s77rt requires payment offer (Reviewer)
@Krishna2323 requires payment offer (Contributor)
@Krishna2323 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot[bot] commented 1 year ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@s77rt] Determine if we should create a regression test for this bug.
[ ] [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot[bot] commented 1 year ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.84-10 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/29480

If no regressions arise, payment will be issued on 2023-10-23. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@s77rt requires payment offer (Reviewer)
@Krishna2323 requires payment offer (Contributor)
@Krishna2323 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot[bot] commented 1 year ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@s77rt] Determine if we should create a regression test for this bug.
[ ] [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

s77rt commented 1 year ago

The PR that introduced the bug has been identified: https://github.com/Expensify/App/pull/21049
The offending PR has been commented on: https://github.com/Expensify/App/pull/21049#discussion_r1361377789
A discussion in #expensify-bugs has been started: Not needed
Determine if we should create a regression test for this bug: No

MitchExpensify commented 1 year ago

Payment summary:

$50 - @Krishna2323 requires payment offer (Reporter) $375 - @Krishna2323 requires payment offer (Contributor) $375 - @s77rt requires payment offer (Contributor Plus)

Does this look correct to you all?

s77rt commented 1 year ago

@MitchExpensify I think the price for this one should be lowered since it was just a style adjustment. https://expensify.slack.com/archives/C01GTK53T8Q/p1696968320902849?thread_ts=1696967863.302429&cid=C01GTK53T8Q

MitchExpensify commented 1 year ago

Thanks, lowering to $375 which is $250 + 50% speed bonus

Krishna2323 commented 1 year ago

@MitchExpensify, it should be $375 😄.

MitchExpensify commented 1 year ago

Oh lol, my mistake @Krishna2323

amyevans commented 1 year ago

Friendly bump @MitchExpensify for payment

MitchExpensify commented 1 year ago

Paid, sorry for the delay! 🙇

Expensify / App