Split bill - Split bill on workspace chat can only be created from FAB, but not the chat itself

lanitochka17 commented 11 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.80-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

Go to staging.new.expensify.com
Go to a workspace chat > + button > Request money
Attempt to create a split bill
Go to FAB on LHN > Request money > Manual
Enter amount > Next
Select Split on the workspace chat in Step 2

Expected Result:

User should be able to create split bill from workspace chat and FAB

Actual Result:

User is only able to create split bill in workspace chat from FAB menu. In workspace chat, only request money option is possible

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/78819774/f0648ddf-0237-4a3a-ae11-5fb56bd51fa6

MacOS: Desktop

View all open jobs on GitHub

melvin-bot[bot] commented 11 months ago

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 11 months ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

trjExpensify commented 11 months ago

Ah, @youssef-lr.. isn't Split bill being added back as a menu item in the workspace chat create menu?

trjExpensify commented 11 months ago

@youssef-lr confirming we can close this one?

trjExpensify commented 11 months ago

The only workspace chat that has the Split bill option right now is the Teachers Unite one.

youssef-lr commented 11 months ago

@trjExpensify seems like this can be bypassed using Global Create. Should we implement a fix to not show the split pill button next to other workspaces?

youssef-lr commented 11 months ago

Likewise a fix to not allow requesting money from TU workspace?

trjExpensify commented 11 months ago

@trjExpensify seems like this can be bypassed using Global Create. Should we implement a fix to not show the split pill button next to other workspaces?

I think we should continue that follow-up discussion somewhere about how we're going to approach this holistically.

Likewise a fix to not allow requesting money from TU workspace?

I don't think we need to worry about that until it actually is proven to be a problem with teachers in the flow doing it by accident.

Expensify / App