Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.53k stars 2.88k forks source link

[$500] Deeplinks - "It's not here" displayed when background the app and open /enable-payment deeplink #29232

Closed lanitochka17 closed 1 month ago

lanitochka17 commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.80-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

Precondition: user should NOT be Signed In

  1. Open app
  2. Background the app
  3. Tap on deeplink from other app (messanger/notes) staging.new.expensify.com/enable-payments

Expected Result:

User should be navigated on "Enable-payments" page

Actual Result:

"Hmm... it's not here" page opens

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native https://github.com/Expensify/App/assets/78819774/01b9765d-aa66-4639-8c65-47eec611b2e7
Android: mWeb Chrome
iOS: Native https://github.com/Expensify/App/assets/78819774/73d85d40-82b8-4189-a97f-199911c2052a
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f993ca3dfb12ab11
  • Upwork Job ID: 1802829645254455808
  • Last Price Increase: 2024-08-08
  • Automatic offers:
    • shubham1206agra | Reviewer | 102925992
melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

alexpensify commented 1 year ago

Still on my testing list, other GHs have taken priority.

alexpensify commented 1 year ago

I've run out of time and will have to test over the weekend.

alexpensify commented 1 year ago

Closing - I've been unable to replicate it on my android device

kbecciv commented 8 months ago

QA team is able to reproduce it on build 1.4.50.2. the only difference that this time the issue is not reproducible on Android

https://github.com/Expensify/App/assets/93399543/8176f51b-41aa-4131-acfd-05ac407dac90

alexpensify commented 8 months ago

I'll need to test again then.

melvin-bot[bot] commented 7 months ago

@alexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

alexpensify commented 7 months ago

Still on my testing list.

alexpensify commented 7 months ago

No update yet

alexpensify commented 7 months ago

I'll test soon.

alexpensify commented 7 months ago

On my testing list

alexpensify commented 7 months ago

Closing again, I tested again and did not get the oops error:

  1. I logged into the application 2024-03-27_12-06-36

  2. I opened the browser and input the following link: staging.new.expensify.com/enable-payments

I get to the following location:

2024-03-27_12-06-08

When I log in, I land on the following page:

2024-03-27_12-10-49

lanitochka17 commented 5 months ago

Issue is still reproducible

https://github.com/Expensify/App/assets/78819774/f09cd341-1bf4-4167-a7cd-653ff19edbbc

alexpensify commented 5 months ago

This week, I'll try to test again.

alexpensify commented 5 months ago

I've asked for help here - https://expensify.slack.com/archives/C01SKUP7QR0/p1718126752943919 and confirm on a physical device instead of a simulator.

mallenexpensify commented 5 months ago

I'm a bit confused. In the OP it states "Precondition: user should be Signed In" but in the vid here, the user needs to sign in then be redirected to the error page.

For me... when I'm signed into my mallen@expensify.com email on the latest staging version and I click http://staging.new.expensify.com/enable-payments in a text message I sent to a test account, the app opens to LHN.

When I sign out then use my mattqwerty9@gmail.com to sign in after clicking http://staging.new.expensify.com/enable-payments , I'm sent to an error page. @alexpensify , want to update the OP to state

Precondition: user should not be Signed In ?

IMG_DE1EECE5DFDE-1

alexpensify commented 4 months ago

Thanks, @mallenexpensify, for testing! I'll update the OP and include that precondition.

melvin-bot[bot] commented 4 months ago

@alexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 4 months ago

Job added to Upwork: https://www.upwork.com/jobs/~01f993ca3dfb12ab11

melvin-bot[bot] commented 4 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

alexpensify commented 4 months ago

Assigning external, we need proposals here.

alexpensify commented 4 months ago

Waiting for proposals here

melvin-bot[bot] commented 4 months ago

@alexpensify, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

alexpensify commented 4 months ago

Waiting for proposals here

melvin-bot[bot] commented 4 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

alexpensify commented 4 months ago

Waiting for proposals here

alexpensify commented 4 months ago

I'll start shopping for proposals in Slack.

alexpensify commented 4 months ago

Following this process: https://stackoverflowteams.com/c/expensify/questions/8260/8261#8261

Asked for help here:

https://expensify.slack.com/archives/C04878MDF34/p1719612019023199 https://expensify.slack.com/archives/C03UK30EA1Z/p1719612099665119 https://expensify.slack.com/archives/C02NK2DQWUX/p1719612141866369

melvin-bot[bot] commented 4 months ago

Upwork job price has been updated to $500

alexpensify commented 4 months ago

Heads up, I will be offline until Monday, July 8, 2024, and will not actively watch over this GitHub during that period.

I'll try to check in a few times. If anything urgent is needed here, please ask for help in the #expensify-open-source Slack Room-- thanks!

BrtqKr commented 4 months ago

Hey, I'm a developer from SWM I'd like to take care of this ticket.

melvin-bot[bot] commented 4 months ago

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

alexpensify commented 4 months ago

Thanks, I've assigned you @BrtqKr.

alexpensify commented 4 months ago

Heads up, I will be offline until Monday, July 8, 2024, and will not actively watch over this GitHub during that period.

If this GitHub needs an urgent update, please ask for help in the #expensify-open-source Slack Room. If it can wait, I'll continue the review process when I return online. Thanks!

melvin-bot[bot] commented 4 months ago

@alexpensify, @BrtqKr, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

alexpensify commented 4 months ago

No update yet, waiting for a PR from @BrtqKr.

alexpensify commented 4 months ago

@BrtqKr - I'm catching up from being OOO, any update here? Thanks!

alexpensify commented 4 months ago

@BrtqKr - please keep me posted if you can't work on this one and I'll ask around for help. Thanks!

alexpensify commented 4 months ago

Waiting for an update

BrtqKr commented 3 months ago

Sorry @alexpensify, I was talking about this with @AndrewGable on the shared channel during your absence. I'd need a provisioning profile to test this on a physical device, otherwise it wasn't working. There's a ?mode=developer thing for the universal links, but it has to relate web and mobile versions properly.

alexpensify commented 3 months ago

Ok, thanks for that update. Did you chat with Andrew in a public Slack channel, if yes, can you share a link here? Thanks!

BrtqKr commented 3 months ago

Sure, it's here

alexpensify commented 3 months ago

Thanks, I'll review that thread and figure out what we should do here.

melvin-bot[bot] commented 3 months ago

@alexpensify, @BrtqKr, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

alexpensify commented 3 months ago

No update and still need to plan the next steps here

alexpensify commented 3 months ago

No update

melvin-bot[bot] commented 3 months ago

@alexpensify, @BrtqKr, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

alexpensify commented 3 months ago

I bumped the Slack 🧵 to figure out the next steps or if we should close:

https://expensify.slack.com/archives/C04878MDF34/p1722278661242209?thread_ts=1719849633.995639&cid=C04878MDF34

alexpensify commented 3 months ago

I'm still reviewing the next steps here and what's possible.