Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.53k stars 2.88k forks source link

[$500] Android - Note - The page is broken with a long blockcode with one backtick #29387

Closed izarutskaya closed 10 months ago

izarutskaya commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when validating PR https://github.com/Expensify/App/pull/29055

Version Number: v1.3.81-6

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: @

Action Performed:

  1. Open the App
  2. Login with any account
  3. Open a Person to Person report.
  4. Now open Profile Details.
  5. Press on Private Note.
  6. Select My Note
  7. Enter a long blockcode with one backtick ( ) and save it.

Expected Result:

The code block does not go beyond the page (the page is broken)

Actual Result:

The block of code goes outside the page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native ![Bug6233522_1697053941825!Screenshot_2023-10-11-17-36-57-29_4f9154176b47c00da84e32064abf1c48](https://github.com/Expensify/App/assets/115492554/d751b423-c88c-46c5-a176-23acdb775cbf) https://github.com/Expensify/App/assets/115492554/b165b8a8-4dd4-48fd-9e62-e27c2cb36d4b
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01412f56d0ed1fc241
  • Upwork Job ID: 1712207610531987456
  • Last Price Increase: 2023-10-11
  • Automatic offers:
    • dhanashree-sawant | Reporter | 27538114
rlinoz commented 10 months ago

I believe we can reassign, how do we do that?

rushatgabhane commented 10 months ago

We need to find a contributor with a new proposal. @rlinoz

cubuspl42 commented 10 months ago

First, I'd suggest to clear up this issue. The actual scope of this issue is unclear. There's only one screenshot provided for one platform, while the proposal mentions issues on Native and web. The test steps render like this for me:

image

...while on the screenshot we can see that the text is very long and presumably consists of long words.

It should be made clear how this issue relates to https://github.com/Expensify/App/issues/27913.

cubuspl42 commented 10 months ago

If the scope was clear, I could help sketching a solution (maybe even fix this myself), because I have experience with the code related to the inline code blocks.

rlinoz commented 10 months ago

To be honest I am not sure this is still a problem since I cannot reproduce this issue either on web or Android.

Steps I took For chats:

  1. Open a chat
  2. Write a long 1 tick block of code

For notes (basically the issue repro steps):

  1. Open a Person to Person report.
  2. Now open Profile Details.
  3. Press on Private Note.
  4. Select My Note
  5. Enter a long blockcode with one backtick and save it eg:
    `. asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf asdf asd asdf`

Android

Web

Screenshot 2024-01-03 at 17 12 02 image
dylanexpensify commented 10 months ago

@rlinoz agree, closing