[$125] Split bill - Split Bill description on Details page is empty in Group chat

lanitochka17 commented 11 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.83-5

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

Open New Expensify app
Click the + icon in a Group conversation > Split Bill
Select Split on any user > Next
Enter description, date and merchant
Create the bill split
Click on the bill split preview

Expected Result:

Description should be saved and visible

Actual Result:

Description field is empty

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/78819774/88e2164e-1796-4391-b846-a69023f4eee4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b2dd27f3e4c1c58d
Upwork Job ID: 1712586612101890048
Last Price Increase: 2023-10-19

melvin-bot[bot] commented 11 months ago

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 11 months ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

OSBotify commented 11 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot[bot] commented 11 months ago

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

mountiny commented 11 months ago

discussed here, removing the blocker and exporting this

melvin-bot[bot] commented 11 months ago

Job added to Upwork: https://www.upwork.com/jobs/~01b2dd27f3e4c1c58d

melvin-bot[bot] commented 11 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

melvin-bot[bot] commented 11 months ago

Upwork job price has been updated to $125

bernhardoj commented 11 months ago

Regression from https://github.com/Expensify/App/pull/29055

trjExpensify commented 11 months ago

@jeet-dhandha can you look into this regression from your PR please?

jeet-dhandha commented 11 months ago

@bernhardoj Please share a video with the PR’s code and a video after reverting the code. As then only i can be sure its a regression from my PR. And also do check that the bugs fixed in the PR are also not coming back.if they are then the regression loop will go on forever.

Thanks in advance.

bernhardoj commented 11 months ago

I don't have my laptop with me right now, but before https://github.com/Expensify/App/pull/29055 you made a platform specific file for the MenuItem RenderHTML where the native file doesn't have the View wrapper. https://github.com/Expensify/App/blob/2b4e1c6dbb4fc0a79b707696f0e83bceaa6035e5/src/components/MenuItem.js#L255-L257

You also did explain here that wrapping the RenderHTML with View on native will make the text empty.

melvin-bot[bot] commented 11 months ago

@bondydaa, @maddylewis, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

bondydaa commented 11 months ago

@bernhardoj @jeet-dhandha what's the status here?

jeet-dhandha commented 11 months ago

I am OOO this and next week due to health reasons.

melvin-bot[bot] commented 11 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

trjExpensify commented 11 months ago

Has this been tested or is it an Android only bug or something? 😕 I can't reproduce on desktop, web or iOS native:

maddylewis commented 11 months ago

@situchan - have you been able to reproduce this bug recently?

situchan commented 11 months ago

I am not able to reproduce on latest main

trjExpensify commented 11 months ago

Confirming you tested on Android native?

situchan commented 11 months ago

Tested android as well.

bondydaa commented 11 months ago

going to close this out then

Expensify / App