Split - Total group split details card does not appear in chat until the chat is revisited

lanitochka17 commented 11 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.84-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Issue found when executing PR https://github.com/Expensify/App/pull/29424

Action Performed:

Precondition: User A is a workspace admin and User B is a workspace member

[User A] Open the workspace chat with User B
[User B] Go to FAB > Request money > Manual > Enter amount > Next
[User B] Select Split on the workspace chat in Step 1 > Create the bill split

Expected Result:

On User A's side, the total group split details card will appear along with individual split preview

Actual Result:

On User A's side, only the invididual split preview appears. The total group split details card does not appear until the chat is revisited

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/78819774/ad297986-2c42-4b0f-84f3-9201e4838f26

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0137b2e4cc6c36c506
Upwork Job ID: 1713664488466337792
Last Price Increase: 2023-10-15

melvin-bot[bot] commented 11 months ago

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 11 months ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

OSBotify commented 11 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot[bot] commented 11 months ago

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

melvin-bot[bot] commented 11 months ago

Job added to Upwork: https://www.upwork.com/jobs/~0137b2e4cc6c36c506

melvin-bot[bot] commented 11 months ago

Triggered auto assignment to Contributor Plus for review of internal employee PR - @0xmiroslav (Internal)

mountiny commented 11 months ago

This will most likely have to be internal and we need to ensure the split action is pushed to the groupchat too. I dont think it has to be a deploy blocker though so demoting cc @youssef-lr

neil-marcellini commented 11 months ago

Thanks Vit. @youssef-lr have you been working on this lately and would you like to take it over? That would be a big help to me.

youssef-lr commented 11 months ago

Sure @neil-marcellini :)

youssef-lr commented 11 months ago

Working on this tomorrow.

melvin-bot[bot] commented 11 months ago

@youssef-lr, @Christinadobrzyn, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

Christinadobrzyn commented 11 months ago

hi @youssef-lr let us know if you have a PR or update for this! Thanks!

youssef-lr commented 11 months ago

PR is underway @Christinadobrzyn

melvin-bot[bot] commented 11 months ago

@youssef-lr, @Christinadobrzyn, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

youssef-lr commented 11 months ago

This should be fixed now.

Christinadobrzyn commented 11 months ago

Awesome! Let me know if these payouts look accurate!

Payouts due:

Issue Reporter: NA Contributor: NA Contributor+: @0xmiroslav NA based on https://github.com/Expensify/App/issues/29634#issuecomment-1787965001

Eligible for 50% #urgency bonus? NA - internal

Upwork job is here.

0xmiros commented 11 months ago

It was backend fix and no payment required here

Christinadobrzyn commented 11 months ago

Ah okay, thanks @0xmiroslav - closed the Upwork job. Closing this as complete!

Expensify / App