Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.55k stars 2.9k forks source link

[$500] Workspace - Settings - Abbreviation used instead of symbol for AMD currency #29715

Closed kbecciv closed 1 year ago

kbecciv commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.84.9 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @dhanashree-sawant Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697480858959599

Action Performed:

  1. Open the app
  2. Open settings->workspaces->any workspace->settings
  3. Click on default currency
  4. Search for AMD, observe the part after '-' in search result
  5. Search for AMD symbol on google and observe that it is different then what we use
  6. Cross check for different currencies like AWG, EUR, INR, USD, AUD etc. We use symbols throughout the list to display after '-'
  7. Search for symbol used for AMD in our list on google and observe that we are using abbreviation instead of symbol for AMD

Expected Result:

App should use AMD symbol for AMD currency as we use that to display before currency for all workspace money requests

Actual Result:

App used AMD abbreviation instead of available symbol for AMD currency in workspace currency list and also for all workspace money requests

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native ![android native amd](https://github.com/Expensify/App/assets/93399543/6873d342-a4e4-48b1-8ae7-c09359569169)
Android: mWeb Chrome ![android chrome amd](https://github.com/Expensify/App/assets/93399543/d1e8239c-65ef-43ee-9f3a-22a762795350)
iOS: Native ![ios native amd](https://github.com/Expensify/App/assets/93399543/99261312-7b5c-4e1f-aca9-8babe5708ef9)
iOS: mWeb Safari ![ios safari amd](https://github.com/Expensify/App/assets/93399543/cc8afcae-5b8a-49c6-a00a-4c055127e981)
MacOS: Chrome / Safari https://github.com/Expensify/App/assets/93399543/f9c3e9cb-13f0-4924-ae06-54414539ec1d ![mac chrome amd](https://github.com/Expensify/App/assets/93399543/d0b65b1b-199d-4d4b-93e4-78a73c25af9f) https://github.com/Expensify/App/assets/93399543/24f7acc9-d033-4c86-a2f1-c2d92119496a
MacOS: Desktop ![mac desktop amd](https://github.com/Expensify/App/assets/93399543/43e68e1c-6f29-42ea-8a8d-1552d877694b)

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f24bbd57aff799b7
  • Upwork Job ID: 1714021803651682304
  • Last Price Increase: 2023-10-16
melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Job added to Upwork: https://www.upwork.com/jobs/~01f24bbd57aff799b7

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

cg813 commented 1 year ago

Proposal

Please re-state the problem that we are trying to solve in this issue. App should use symbol for AMD currency not abbreviation

What is the root cause of that problem? Used abbreviation not symbol for AMD in currencyList

What changes do you think we should make in order to solve the problem? Just need to change from abbreviation to symbol for AMD and check other currencies also.

image
eh2077 commented 1 year ago

It looks like not a bug, see https://www.globecountries.com/currency/amd.html

cg813 commented 1 year ago

It looks like not a bug, see https://www.globecountries.com/currency/amd.html

https://en.wikipedia.org/wiki/Armenian_dram

parasharrajat commented 1 year ago

This is a new feature request, not a bug. @sakluger Please close this issue or let me know if this feature needs to be implemented.

@dhanashree-sawant open a new feature request report on Slack to get consensus.

Note: @dhanashree-sawant I can still not tag you. Please let me know if I can help anyway.

dhanashree-sawant commented 1 year ago

Yes please if you have any solution for it then let me know, I couldn't find a proper solution to it. 😅

I raised it as it is inconsistent with the way we display other currencies. Can you let me know why do you think this to be feature request?

That symbol existed way back when we used dropdown for currency. Before it didn't mattered much as it was only displayed in settings and in # admin room update message but now, we also display it during distance request and that would be used more often by users.

Displaying wrong symbol for a currency isn't ideal and although a small fix, seems worth it.

sakluger commented 1 year ago

According to https://www.globecountries.com/currency/amd.html, thre are two valid symbols for AMD: ֏ or դր. We are using the second valid symbol, so this is not a bug.

image