[$500] Android - Chat -Chat composer is focused but keyboard doesn't open when dismiss the emoji picker

lanitochka17 commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.86-1 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL Issue reported by:** Applause - Internal Team

Slack conversation:

Action Performed:

Open New Expensify app
Open random chat
Long press on emoji picker
Dismiss the emoji picker screen by taping outside
Notice the keyboard behavior

Expected Result:

When message composer is focused the keyboard should open

Actual Result:

Keyboard does not open when dismiss the emoji picker even the chat composer is focused

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/78819774/24cbcd8b-9068-4566-85aa-6388dc008f98

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0161f29542bae453d0
Upwork Job ID: 1714740295816368128
Last Price Increase: 2023-11-01

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Job added to Upwork: https://www.upwork.com/jobs/~0161f29542bae453d0

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

bernhardoj commented 1 year ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

When we focus on the main composer, open the emoji picker, and then close the emoji picker, the composer is still focused, but no keyboard is showing.

What is the root cause of that problem?

This is a well-known issue where calling focus while the text input is focused won't bring up the keyboard again.

on Android, when we open the emoji picker, the main composer is still in a focused state

What changes do you think we should make in order to solve the problem?

Blur the main composer before opening the emoji picker. We did this with the + action button. https://github.com/Expensify/App/blob/b38171d0374d52e49ac5131363f920c48ea36eb7/src/pages/home/report/ReportActionCompose/ReportActionCompose.js#L213-L218

melvin-bot[bot] commented 1 year ago

@miljakljajic, @fedirjh Huh... This is 4 days overdue. Who can take care of this?

fedirjh commented 1 year ago

I have seen this bug before.

mkhutornyi commented 1 year ago

Dupe of https://github.com/Expensify/App/issues/29011

fedirjh commented 1 year ago

I think this bug was fixed in the past using a setTimeout approach, I guess there was some PR re-introduced it.

Dupe of https://github.com/Expensify/App/issues/29011

Both are related, but we have different components for the composer and the edit composer, not sure if the other issue will cover both.

fedirjh commented 1 year ago

Let's put this on hold for https://github.com/Expensify/App/issues/24452.

melvin-bot[bot] commented 1 year ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 1 year ago

@miljakljajic, @fedirjh Eep! 4 days overdue now. Issues have feelings too...

fedirjh commented 1 year ago

@miljakljajic little bump for https://github.com/Expensify/App/issues/29908#issuecomment-1777406132

melvin-bot[bot] commented 1 year ago

@miljakljajic @fedirjh this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 1 year ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

fedirjh commented 1 year ago

Not overdue, waiting for @miljakljajic to put it on hold for https://github.com/Expensify/App/issues/24452

miljakljajic commented 1 year ago

I agree @fedirjh (apologies, I was OOO) I think we can close for now and re-open if we find that it wasn't resolved by https://github.com/Expensify/App/issues/24452

Expensify / App