[HOLD for payment 2023-11-17] [$500] No space between description & show more option

m-natarajan commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.87-1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @krishna2323 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697621145743689

Action Performed:

Open Request money & select manual tab
Enter amount & select any user
Hover on description menu item and observer there is no gap between description & show more option
Go back to step one & select distance tab
Hover on finish point and observe the space between finish point & add stop option
Expected Result:

There should be some gap between description & show more option

Actual Result:

There is no gap between description & show more option

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/38435837/2f91fab2-f2db-4c2d-a532-1d1045021750

Android: mWeb Chrome

https://github.com/Expensify/App/assets/38435837/d3d40065-219a-48ab-bf30-9738ffef24c8

iOS: Native

https://github.com/Expensify/App/assets/38435837/bc4f4634-cce5-46cf-80a6-34ce5125de03

iOS: mWeb Safari

https://github.com/Expensify/App/assets/38435837/746346be-3588-448b-8543-c55059eb3bd1

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/38435837/f4ef5ba5-eb6f-4f69-8e06-ccf6ffb67b7f

MacOS: Desktop

https://github.com/Expensify/App/assets/38435837/cfd2dc04-e89b-46a6-b128-d56140bbd930

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e92101d63dc7fd51
Upwork Job ID: 1715163936897327104
Last Price Increase: 2023-10-20
Automatic offers:

Krishna2323 | Contributor | 27512429
krishna2323 | Reporter | 27512432

Issue Owner

Current Issue Owner: @m-natarajan

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Job added to Upwork: https://www.upwork.com/jobs/~01e92101d63dc7fd51

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

m-natarajan commented 1 year ago

Proposal by contributor reported the bug

Please re-state the problem that we are trying to solve in this issue.

No space between description & show more option

What is the root cause of that problem?

We don't apply any margin or padding to top of the show more container.

What changes do you think we should make in order to solve the problem?

We can either apply margin/padding bottom to description menu item or margin/padding top to the show more container. We are using 4px padding for "Add Stop" option and I think it will be the best option but we can discuss about it and then apply.

Result

samilabud commented 1 year ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

No space between the description & show more option

What is the root cause of that problem?

The components MenuItemWithTopDescription inside of OptionsSelector (in MoneyRequestConfirmationList component in src/components/MoneyRequestConfirmationList.js) are all aligned using a flex-direction row with the same distance when the 'show more' option is displayed has no margins.

What changes do you think we should make in order to solve the problem?

The best solution is adding the prop styles.mt2 in style as next, this going to add a margin-top of 2 and produce the space needed, this is the code needed (in file src/components/MoneyRequestConfirmationList.js line 619): <View style={[styles.flexRow, styles.justifyContentBetween, styles.mh3, styles.alignItemsCenter, styles.mb2, styles.mt2]}>

These are the results: Web:

Mac Desktop:

Android:

https://github.com/Expensify/App/assets/5216036/0d834be6-d1cb-4b77-a5b8-b306a9aea9bc

IPhone/IOS:

https://github.com/Expensify/App/assets/5216036/cc0bacf6-f2d5-466d-b389-4fcf05e824a6

Krishna2323 commented 1 year ago

Just to provide more context for my proposal:

We can add margin bottom on: https://github.com/Expensify/App/blob/732d48e23ac132b1f91fcd004d6941d1b0237c34/src/components/MoneyRequestConfirmationList.js#L619

Or we can margin/padding top on: https://github.com/Expensify/App/blob/732d48e23ac132b1f91fcd004d6941d1b0237c34/src/components/MoneyRequestConfirmationList.js#L619

For add stop button we are using 'pt1':

https://github.com/Expensify/App/blob/732d48e23ac132b1f91fcd004d6941d1b0237c34/src/components/DistanceRequest/DistanceRequestFooter.js#L100

yh-0218 commented 1 year ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

No space between the description & show more option

What is the root cause of that problem?

There is no margin-top https://github.com/Expensify/App/blob/86e75ad6c95cd5927800bb62b848857716da52f6/src/components/MoneyRequestConfirmationList.js#L619

What changes do you think we should make in order to solve the problem?

We need to add margin-top

<View style={[styles.flexRow, styles.justifyContentBetween, styles.mh3, styles.alignItemsCenter, styles.mv2]}>

https://github.com/Expensify/App/blob/86e75ad6c95cd5927800bb62b848857716da52f6/src/components/MoneyRequestConfirmationList.js#L619

What alternative solutions did you explore? (Optional)

narefyev91 commented 1 year ago

@shawnborton Design help needed here! Can you please check and suggestion - do we really need additional spacing between last button and Show More chip? This is how we currently have it now:

This is after any new padding coming in place (chip will take more space, and visually it show a bigger gap - when menu item is not in hover state):

If we need to add margin - can you please tell how much it should be. Thanks!

Pujan92 commented 1 year ago

We had it earlier and I think mistakenly removed in this PR https://github.com/Expensify/App/pull/28110/files#diff-dc0f934ad9e583b0f7ac049563a3dcacbfe314e9c16b5c6f8bba6e5a5225a86cL478 cc: @akinwale

We can use styles.mv2 here instead of styles.mb2 https://github.com/Expensify/App/blob/69cf29e32950f915ea888fe294dfdea6a9fabbb5/src/components/MoneyRequestConfirmationList.js#L619

akinwale commented 1 year ago

We had it earlier and I think mistakenly removed in this PR https://github.com/Expensify/App/pull/28110/files#diff-dc0f934ad9e583b0f7ac049563a3dcacbfe314e9c16b5c6f8bba6e5a5225a86cL478 cc: @akinwale

We can use styles.mv2 here instead of styles.mb2

https://github.com/Expensify/App/blob/69cf29e32950f915ea888fe294dfdea6a9fabbb5/src/components/MoneyRequestConfirmationList.js#L619

The idea from that PR was to remove the bottom margins from all push-to-page buttons. https://github.com/Expensify/App/issues/27052 for context.

Krishna2323 commented 1 year ago

@akinwale, I think we didn't wanted to remove the spacing between "show more" button.

akinwale commented 1 year ago

@akinwale, I think we didn't wanted to remove the spacing between "show more" button.

Yeah, I think the ideal solution here would be to add a top margin (or padding?) to the "show more" button. If there's another push-to-page button below "Description" (e.g. "Date" or "Merchant"), we don't want a bottom margin separating those.

narefyev91 commented 1 year ago

Proposal from @m-natarajan looks good to me https://github.com/Expensify/App/issues/30039#issuecomment-1771888313 All proposals are correct - in root case and area to apply a fix - just @m-natarajan was the faster one 🎀 👀 🎀 C+ reviewed

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @roryabraham, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

akinwale commented 1 year ago

Proposal from @m-natarajan looks good to me #30039 (comment) All proposals are correct - in root case and area to apply a fix - just @m-natarajan was the faster one 🎀 👀 🎀 C+ reviewed

@narefyev91 Small correction here. @m-natarajan is on the QA / Applause (I think?) team reposting the solution posted by the issue reporter, @Krishna2323.

melvin-bot[bot] commented 1 year ago

Current assignee @roryabraham is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

samilabud commented 1 year ago

@narefyev91 @roryabraham Is there any update related to who is assigned to resolve this bug?

narefyev91 commented 1 year ago

@narefyev91 @roryabraham Is there any update related to who is assigned to resolve this bug?

Hey - i think we waiting final decision from @roryabraham

adelekennedy commented 12 months ago

@roryabraham removing the overdue here

adelekennedy commented 11 months ago

@roryabraham bump on this

melvin-bot[bot] commented 11 months ago

@narefyev91, @roryabraham, @adelekennedy Eep! 4 days overdue now. Issues have feelings too...

roryabraham commented 11 months ago

Assigned to @m-natarajan

Krishna2323 commented 11 months ago

@roryabraham, I should be assigned here, @m-natarajan is from QA team, he/she just posted my proposal from slack. https://github.com/Expensify/App/issues/30039#issuecomment-1772850445

melvin-bot[bot] commented 11 months ago

@narefyev91 @m-natarajan @roryabraham @adelekennedy this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Krishna2323 commented 11 months ago

@roryabraham, can you pls assign me 😅. https://github.com/Expensify/App/issues/30039#issuecomment-1788548629

melvin-bot[bot] commented 11 months ago

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

melvin-bot[bot] commented 11 months ago

📣 @krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

roryabraham commented 11 months ago

Done, sorry @Krishna2323.

melvin-bot[bot] commented 11 months ago

@narefyev91, @roryabraham, @adelekennedy, @Krishna2323 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

adelekennedy commented 11 months ago

waiting on the PR

Krishna2323 commented 11 months ago

@narefyev91, PR ready.

melvin-bot[bot] commented 11 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 11 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.97-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/31048

If no regressions arise, payment will be issued on 2023-11-17. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@narefyev91 does not require payment (Contractor)
@Krishna2323 requires payment offer (Contributor)
@krishna2323 requires payment offer (Contributor)

melvin-bot[bot] commented 11 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@narefyev91] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@narefyev91] Determine if we should create a regression test for this bug.
[ ] [@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

adelekennedy commented 11 months ago

Payouts due:

Issue Reporter: $50 @Krishna2323 (pre bounty change) Contributor: $500 @Krishna2323 Contributor+: NA

Eligible for 50% #urgency bonus? N

Expensify / App