[HOLD for payment 2024-07-22] [$500] Distance - Search list displays old searched results in offline mode

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.88-3 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go offline
3. Click on FAB> Request money> Distance tab
4. Select Start point
5. Enter any letter into search field

Expected Result:

Search result should update according to entered letter

Actual Result:

Search list displays old searched results in offline mode

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] Windows: Chrome
• [x] MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

Windows: Chrome

https://github.com/Expensify/App/assets/78819774/7a45a7ba-2f20-41fc-a547-20c8ad1ed097

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a86156cf627cbc84
• Upwork Job ID: 1715774289180717056
• Last Price Increase: 2024-06-28
• Automatic offers:
• cooldev900 | Contributor | 27794398

Issue Owner

Current Issue Owner: @eVoloshchak

[neil-marcellini]

Let's keep this at a weekly cadence. The PR is coming along and it feels like it's finally close.

[mallenexpensify]

Added to #wave-collect and set Status as Release 1, since that's what's listed on the roadmap doc

[melvin-bot[bot]]

This issue has not been updated in over 15 days. @eVoloshchak, @cooldev900, @mallenexpensify, @neil-marcellini, @pac-guerreiro, @dubielzyk-expensify eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mallenexpensify]

• https://github.com/Expensify/App/pull/35045

Looks like it's being reverted.

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.77-11 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/35045

If no regressions arise, payment will be issued on 2024-06-06. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests
• @pac-guerreiro does not require payment (Contractor)

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@eVoloshchak] Determine if we should create a regression test for this bug.
• [ ] [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[neil-marcellini]

@eVoloshchak @pac-guerreiro the PR was reverted, so we need to try again. When can you have another PR up?

[pac-guerreiro]

@neil-marcellini I can provide one early next week 😄

[neil-marcellini]

Thanks for the PR @pac-guerreiro. Would you please list out each of the problems that were found when the PR went live and had to be reverted, along with how you're fixing them in the new PR?

It will make it easier to review and make sure that we're not going to repeat the same mistakes.

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.78-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/35045

If no regressions arise, payment will be issued on 2024-06-11. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests
• @pac-guerreiro does not require payment (Contractor)

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@eVoloshchak] Determine if we should create a regression test for this bug.
• [ ] [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[pac-guerreiro]

@neil-marcellini these are the issues that mentioned my previous PR:

1. https://github.com/Expensify/App/issues/42758

   • This behaviour was agreed in the previous PR in order to maintain a friendly UX, but if there's the need to change this behaviour, please let me know! cc @arosiclair

2. https://github.com/Expensify/App/issues/42767

   • I applied a fix for this which should restore the previous working UI/UX in all forms

3. https://github.com/Expensify/App/issues/42768

   • Same fix as above

[melvin-bot[bot]]

Payment Summary

Upwork Job

• Reviewer: @eVoloshchak owed $250 via NewDot
• Contributor: @pac-guerreiro is from an agency-contributor and not due payment

BugZero Checklist (@mallenexpensify)

• [ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• [ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1715774289180717056/hired)
• [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
• [ ] I have verified the payment summary above is correct

[melvin-bot[bot]]

@eVoloshchak, @mallenexpensify, @neil-marcellini, @pac-guerreiro, @dubielzyk-expensify Eep! 4 days overdue now. Issues have feelings too...

[mallenexpensify]

HOLD, pending regressions ~Contributor+: @eVoloshchak due $500 via NewDot.~

@eVoloshchak plz complete the BZ checklist above.

[neil-marcellini]

@mallenexpensify there were regressions so I think the payment summary is inaccurate. We're still working on re-doing the PR

[melvin-bot[bot]]

@eVoloshchak, @mallenexpensify, @neil-marcellini, @pac-guerreiro, @dubielzyk-expensify Huh... This is 4 days overdue. Who can take care of this?

[eVoloshchak]

https://github.com/Expensify/App/pull/43011 is close to being merged

[melvin-bot[bot]]

@eVoloshchak, @mallenexpensify, @neil-marcellini, @pac-guerreiro, @dubielzyk-expensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mallenexpensify]

@eVoloshchak 👀 on the PR, I think it's awaiting testing from ya

[melvin-bot[bot]]

@eVoloshchak, @mallenexpensify, @neil-marcellini, @pac-guerreiro, @dubielzyk-expensify Still overdue 6 days?! Let's take care of this!

[eVoloshchak]

Not overdue, PR is close to being merged Latest update: https://github.com/Expensify/App/pull/43011#issuecomment-2192246195

[melvin-bot[bot]]

⚠️ This issue has had its price increased by 4x or more. Please review the issue and ensure the price is correct.

[melvin-bot[bot]]

Upwork job price has been updated to $500

[melvin-bot[bot]]

@eVoloshchak, @mallenexpensify, @neil-marcellini, @pac-guerreiro, @dubielzyk-expensify Huh... This is 4 days overdue. Who can take care of this?

[neil-marcellini]

@mallenexpensify the PR was merged so this is awaiting payment now. Looks like the automation failed, would you please handle it manually?

[mallenexpensify]

Contributor+: @eVoloshchak due $500 via NewDot

With many changes for offline distance bugs, do we want a new test case for this? I'm unsure

cc @paultsimura since it's an offline distance issue.

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.6-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/35045
• https://github.com/Expensify/App/pull/43011

If no regressions arise, payment will be issued on 2024-07-22. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests
• @pac-guerreiro does not require payment (Contractor)

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@eVoloshchak] Determine if we should create a regression test for this bug.
• [ ] [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot[bot]]

Payment Summary

Upwork Job

• Reviewer: @eVoloshchak owed $250 via NewDot
• Contributor: @pac-guerreiro is from an agency-contributor and not due payment

BugZero Checklist (@mallenexpensify)

• [ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• [ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1715774289180717056/hired)
• [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
• [ ] I have verified the payment summary above is correct

[melvin-bot[bot]]

@eVoloshchak, @mallenexpensify, @neil-marcellini, @pac-guerreiro, @dubielzyk-expensify Eep! 4 days overdue now. Issues have feelings too...

[mallenexpensify]

@eVoloshchak plz complete the BZ checklist above.

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: N/A, this functionality wasn't implemented initially
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: this was already discussed in https://expensify.slack.com/archives/C01GTK53T8Q/p1716990791744559

Regression Test Proposal

1. Click on FAB> Submit Expense > Distance tab
2. Select different locations several times to populate the predefined places list
3. Turn off the internet connection
4. Select Start point
5. Start typing into the search field, verify the list is updated according to the search query

Do we agree 👍 or 👎

[mallenexpensify]

Contributor+: @eVoloshchak due $500 via NewDot

Test case

• https://github.com/Expensify/Expensify/issues/415742

Thanks all!

[JmillsExpensify]

$500 approved for @eVoloshchak