Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.53k stars 2.88k forks source link

[$500] Currency - Dot (.) cannot be added into amount field if MRO currency selected #30136

Closed lanitochka17 closed 1 year ago

lanitochka17 commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.88-3 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Click on FAB> Request money> Manual
  3. Click Currency
  4. Select MRO
  5. Type any number and dot in amount field

Expected Result:

Dot (.) should be entered and seen into amount field

Actual Result:

Dot (.) cannot be added into amount field if MRO currency selected

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari https://github.com/Expensify/App/assets/78819774/73697018-98cb-4850-9d97-1b6a729fd321
MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013d5909ed29d6d625
  • Upwork Job ID: 1715845386362593280
  • Last Price Increase: 2023-10-28
melvin-bot[bot] commented 1 year ago

Job added to Upwork: https://www.upwork.com/jobs/~013d5909ed29d6d625

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

abdel-h66 commented 1 year ago

Seems like this currency does not have decimals allowed. "decimals": 0,

{
    "symbol": "UM",
    "name": "Mauritania Ougulya",
    "decimals": 0,
    "retired": true,
    "retirementDate": "2018-07-11",
    "ISO4217": "478"
}
peymancyb commented 1 year ago

I do also confirm and agree with @abdel-h66, based on the current config, the currency does not accept decimals which is the reason of not being able to use (.).

=> View currencyList.json

https://github.com/Expensify/App/assets/18486930/78656eba-6845-4019-b596-56d0e8593db0

melvin-bot[bot] commented 1 year ago

📣 @peymancyb! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
peymancyb commented 1 year ago

Contributor details Your Expensify account email: paymanghazvini@yahoo.com Upwork Profile Link: https://www.upwork.com/freelancers/~015502e3fbe636dad6

melvin-bot[bot] commented 1 year ago

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

shubham1206agra commented 1 year ago

This is what I got

The Mauritanian Ouguiya (MRO) is the official currency of Mauritania. In the context of currency, you typically cannot have less than 1 unit of the currency in a monetary transaction. The Ouguiya is subdivided into smaller units, with the most common denominations being the ouguiya and the khoums. One ouguiya is equivalent to 5 khoums.

So, for practical purposes, in monetary transactions, you would typically deal with whole numbers of ouguiyas or khoums, and amounts are not expressed as fractions of an ouguiya. For example, you might have 10 ouguiyas or 50 khoums, but you wouldn't typically have something like "0.5 MRO" in a standard transaction.

burczu commented 1 year ago

@dylanexpensify I've just checked what @shubham1206agra wrote in their comment and it seems to be kinda correct - in Mauritania there is only one coin that is less than 1 Ouguiya called Khoum which is 1/5 of Ouguiya. That's why, I guess, we have decimals disabled in the App for MRO currency, because it would hard to deal with it.

So I think this may not be a bug, actually.

melvin-bot[bot] commented 1 year ago

@burczu, @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] commented 1 year ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

dylanexpensify commented 1 year ago

agree! thank you!