[HOLD] [LOW] [Splits] IOU - Re-creating Split Bill with anonymous gmail members causes IOU to crash

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.88-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

1. Open New Expensify app
2. Log in with an expensifail account
3. Create Split Bill with gmail accounts with which there was no conversation history before
4. In the created group DM with these members, request the Split Bill again

Expected Result:

Re-creating Split Bill with anonymous gmail members should register IOU with no errors for both the re-request and the first

Actual Result:

Re-creating Split Bill with anonymous gmail members causes IOU to crash

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] Windows: Chrome
• [x] MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

Windows: Chrome

https://github.com/Expensify/App/assets/78819774/d058135b-bade-4af3-a726-e08bcc53cd5f

MacOS: Desktop

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @youssef-lr

Issue Owner

Current Issue Owner: @youssef-lr

[melvin-bot[bot]]

@youssef-lr, @stephanieelliott Whoops! This issue is 2 days overdue. Let's get this updated quick!

[stephanieelliott]

Hey @youssef-lr is there an update on the PR?

[youssef-lr]

It's under review @stephanieelliott. I added a hold on this issue, which should also fix this one.

[stephanieelliott]

Oop Melvin was kirking out earlier -- this is not overdue!

[stephanieelliott]

Still held on https://github.com/Expensify/Expensify/issues/328013

[stephanieelliott]

Still held on https://github.com/Expensify/Expensify/issues/328013

[melvin-bot[bot]]

@youssef-lr, @stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[youssef-lr]

Not overdue, remaining PRs in the works.

[youssef-lr]

Same as above.

[stephanieelliott]

Moving this to Weekly to match the K2 of the issue we're held on

[stephanieelliott]

Still held

[stephanieelliott]

Still held on https://github.com/Expensify/Expensify/issues/328013

[youssef-lr]

Web-E is close to getting merged, just addressed one final coment.

[youssef-lr]

Hmm I thought this would be fixed, but we have a new issue where invited new accounts still show up as "Hidden", with their login not being saved, we're unable to get the existing chat locally so it fails in the backend.

https://github.com/Expensify/App/assets/9680864/45103aa2-19fb-4067-8ad1-3898030f7712

@puneetlath given that I've invited these accounts, shouldn't they be known to me?

[stephanieelliott]

Bumping in case the mention got buried under the image -- any thoughts on the above @puneetlath?

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[puneetlath]

@youssef-lr yes, they should be. Maybe we aren't properly setting the inviterID via the split flow.

[youssef-lr]

Thanks @puneetlath, I'll look into that this week.

[stephanieelliott]

Hey @youssef-lr we should take this off hold now, yea?

Also, not sure if it helps but I did a deep dive on Hidden account behavior a few weeks ago and shared the notes here. Obviously doesn't explain the crashing, but it does lay out some scenarios where a user may display as hidden.

[youssef-lr]

I think this is definitely due to the 'Hidden' issue, and I agree we can take this off hold. The proper solution would be that any account we start a chat with using their email should never show up as Hidden to us, but the solution to this is not straightforward unfortunately and we haven't decided yet how to fix it, there is a long thread here about it.

Another option would be to make the split backend take just accountIDs and not emails, I think this would be more straightforward to implement. I'll dive deeper into this this week and report back here.

[melvin-bot[bot]]

@youssef-lr, @stephanieelliott Huh... This is 4 days overdue. Who can take care of this?

[youssef-lr]

No update yet.

[youssef-lr]

Same. Haven't found time for this yet.

[stephanieelliott]

Gonna move this back to Weekly since it's been re-prioiritized to LOW

[melvin-bot[bot]]

This issue has not been updated in over 15 days. @youssef-lr, @stephanieelliott eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[stephanieelliott]

Noting here that I'll be OOO til May 2. I'll leave myself assigned here since there hasn't been much movement, but if you need a BZ before then just reapply the Bug label to get someone else and I will pick it back up from them when I return!

[youssef-lr]

This can be put on HOLD for this issue, which will make the split commands use accountIDs and will fix this.

[stephanieelliott]

We're still holding for #323235

[youssef-lr]

Still held

[stephanieelliott]

Held now on https://github.com/Expensify/Expensify/issues/357867. I am going to be OOO til July 10 but not expecting much movement on this so will keep it assigned. If it needs attention in the meantime please reapply the BZ label

[stephanieelliott]

Still held on https://github.com/Expensify/Expensify/issues/357867

[youssef-lr]

Still held

[youssef-lr]

This is paused

[stephanieelliott]

Still held on https://github.com/Expensify/Expensify/issues/357867

[youssef-lr]

Same

[youssef-lr]

Same

[stephanieelliott]

Still held, looks like the blocking PR is moving though