[$500] IOU Report - User is sent to blinking/flashing screen after opening sent IOR request

lanitochka17 commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.90-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

Using two accounts, using User A, send IOU request to User B
Using User B, open IOU preview and click on individual request(Red Dot appears with report on LHN)
Log out and back in User B and open request

Expected Result:

User is able to open request and view IOU details

Actual Result:

Blinking page is shown after clicking on report "Hmm, nothing is here" occurs on occasion instead of blinking page or red dot in LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] Windows: Chrome
[x] MacOS: Desktop

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/78819774/23008d7a-3ed4-4ccc-a5ff-7e35f6229c35

Android: mWeb Chrome

https://github.com/Expensify/App/assets/78819774/2560a869-394c-4dfe-96c1-1800c6c0dad1

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/78819774/11b552ec-4119-4d7b-a1a7-a8f8617f23b6

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0134567ff2a3f3bab0
Upwork Job ID: 1716926610572148736
Last Price Increase: 2023-10-31

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

OSBotify commented 1 year ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

AndrewGable commented 1 year ago

Can you reproduce @greg-schroeder ?

AndrewGable commented 1 year ago

I think @danielrvidal says he is seeing this in production, can you confirm @lanitochka17 ?

AndrewGable commented 1 year ago

Demoting to normal bug as this is happening on production according to this!

melvin-bot[bot] commented 1 year ago

Job added to Upwork: https://www.upwork.com/jobs/~0134567ff2a3f3bab0

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

Jenemark commented 1 year ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

The application blinks when clicking report on the LHN, the indicator also turns red.

What is the root cause of that problem?

The root cause seems to be on the side of OnyxData, when running the app in localhost it works as expected. Can also be tested by copying the curl for the HTTP request and changing staging with your localhost:8082. (Do this in Postman, Insomnia, etc...) The http always seems to fail on non localhost. Even if the page is actually showing, the response body returns with an error.

The error body from the HTTP response:

    "code": 666,
    "jsonCode": 404,
    "type": "Expensify\\Libs\\Error\\ExpError",
    "UUID": "b9114bf5-a67c-44a3-b0f3-b4a27fab05f2",
    "message": "Policy does not exist or you do not have access. Try refreshing the page.",
    "title": "Policy Inaccessible",
    "data": {
        "onyxData": [
            {
                "onyxMethod": "merge",
                "key": "report_4361403564968695",
                "value": {
                    "errorFields": {
                        "createChat": {
                            "1698219760662790": "Policy does not exist or you do not have access. Try refreshing the page."
                        }
                    }
                }
            }
        ]
    },
    "htmlMessage": "",
    "onyxData": [
        {
            "onyxMethod": "merge",
            "key": "report_4361403564968695",
            "value": {
                "errorFields": {
                    "createChat": {
                        "1698219760662790": "Policy does not exist or you do not have access. Try refreshing the page."
                    }
                }
            }
        }
    ],
    "requestID": "81b8d2ff582e10b1-CPH"
}

What changes do you think we should make in order to solve the problem?

This could be a certificate or policy issue on the backend endpoint not allowing access from the staging/production. Without having access to the backend an actual fix for this will be hard to implement.

What alternative solutions did you explore? (Optional)

hungvu193 commented 1 year ago

Here's the issue about retry logic and I think it's being handled here: https://github.com/Expensify/App/issues/13667

greg-schroeder commented 1 year ago

@hungvu193 are you suggesting we hold for the linked issue?

hungvu193 commented 1 year ago

@hungvu193 are you suggesting we hold for the linked issue?

I believe so, but can you please post this issue into that thread, just to confirm.

melvin-bot[bot] commented 1 year ago

@AndrewGable, @hoangzinh, @greg-schroeder Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] commented 1 year ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

AndrewGable commented 1 year ago

Any updates here @hungvu193 @hoangzinh or @greg-schroeder ? Thanks

hoangzinh commented 1 year ago

It looks like a BE issue, after relogin, when userB opens the IOU report, BE returns the error "Policy does not exist or you do not have access. Try refreshing the page." for the API command OpenReport

Screenshot 2023-11-01 at 08 49 16

The issue that @hungvu193 mentioned https://github.com/Expensify/App/issues/30282#issuecomment-1782606925 is another issue. It won't solve the root cause of this issue.

cc @greg-schroeder @AndrewGable

melvin-bot[bot] commented 12 months ago

@AndrewGable, @hoangzinh, @greg-schroeder Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] commented 12 months ago

Current assignee @hoangzinh is eligible for the Internal assigner, not assigning anyone new.

AndrewGable commented 12 months ago

Marking internal for now!

melvin-bot[bot] commented 12 months ago

@AndrewGable @hoangzinh @greg-schroeder this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

greg-schroeder commented 11 months ago

This is internal now as it's a BE issue, Expensify engineer will work on shortly

greg-schroeder commented 11 months ago

Same as above

melvin-bot[bot] commented 11 months ago

@AndrewGable @hoangzinh @greg-schroeder this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

hoangzinh commented 11 months ago

just wanna confirm @AndrewGable will work on this issue, won't he?

greg-schroeder commented 11 months ago

Yeah @AndrewGable do you mind giving an ETA on this one?

AndrewGable commented 11 months ago

I'll look at it soon-ish, I want to make sure it still happens before digging into too deep.

mvtglobally commented 11 months ago

Issue not reproducible during KI retests. (First week)

melvin-bot[bot] commented 11 months ago

@AndrewGable @hoangzinh @greg-schroeder this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

hoangzinh commented 11 months ago

@greg-schroeder @AndrewGable it looks like this issue has been fixed somewhere

https://github.com/Expensify/App/assets/9639873/98a3e357-c068-4353-b966-85c60663f71a

greg-schroeder commented 11 months ago

Ah, I think you're right.

greg-schroeder commented 11 months ago

I'm going to close, then.

Expensify / App