[$500] LHN - "No activity yet message showed in LHN rooms with conv history after coming back online

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.91-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

1. Create a new applause.expensifail account on staging.new.expensify.com
2. Disable the internet connection in the device
3. Tap on the green plus button (FAB) and create a new Workspace
4. Navigate to LHN
5. Enter any of the new rooms and send some messages
6. Go back online

Expected Result:

Last send message into workspace rooms should be visible in LHN when come back online

Actual Result:

"No activity yet" message showed in LHN under workspace rooms

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [x] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

https://github.com/Expensify/App/assets/78819774/63af195a-14d1-436e-9092-00ed120fd731

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014dee0189b20922e7
• Upwork Job ID: 1717286481120063488
• Last Price Increase: 2023-11-01

Issue Owner

Current Issue Owner: @youssef-lr

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~014dee0189b20922e7

[melvin-bot[bot]]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[bernhardoj]

Pretty sure this is a regression from https://github.com/Expensify/App/pull/29568 where we show the "No activity yet" if the report's actions/messages are not loaded yet (even though the report object has a last message text value lastMessageTextFromReport).

This affects a lot of reports (mainly chat rooms). You will see many room chats' last message text shown as "No activity yet" after re-login.

[alexpensify]

@s77rt - do you agree with this feedback from @bernhardoj?

[s77rt]

@alexpensify Yes! That makes sense to me. I have asked if that change was intended here. cc @youssef-lr

[youssef-lr]

Yeah this looks like a regression from my PR. I added this change for the case of split bills that contain a receipt, the other participant receives a last message text from the backend which says "split $0.0" when the receipt is still being scanned, even though this last message is actually a whisper to the creator of the split. So I think proper way is to get it fixed in the backend and we can revert my change at line 306.

[s77rt]

Should this be internal in that case?

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[s77rt]

Not overdue. Maybe internal? ^

[alexpensify]

@youssef-lr can you check if we should take this internal and edit the tags here? Thanks!

[melvin-bot[bot]]

Current assignee @s77rt is eligible for the Internal assigner, not assigning anyone new.

[youssef-lr]

Going to take this internal and assign it to myself

[alexpensify]

Sounds good @youssef-lr, I'm going to assign you the primary role in this GH.

[melvin-bot[bot]]

@alexpensify, @youssef-lr, @s77rt Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot[bot]]

@alexpensify @youssef-lr @s77rt this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot[bot]]

@alexpensify, @youssef-lr, @s77rt 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[youssef-lr]

I'm planning to work on this this week.

[melvin-bot[bot]]

@alexpensify, @youssef-lr, @s77rt Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot[bot]]

@alexpensify, @youssef-lr, @s77rt Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[youssef-lr]

Planning to get to this tomorrow.

[youssef-lr]

I sadly didn't get around to working on this and I'm going OOO tomorrow. I think for now we can revert this change which should fix this issue, we can work on fixing the backend issue afterwards.

[melvin-bot[bot]]

@alexpensify @youssef-lr @s77rt this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[alexpensify]

Ok, we will wait for you to get back from OOO.

[melvin-bot[bot]]

@alexpensify, @youssef-lr, @s77rt Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot[bot]]

@alexpensify @youssef-lr @s77rt this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

[melvin-bot[bot]]

@alexpensify, @youssef-lr, @s77rt 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot[bot]]

@alexpensify, @youssef-lr, @s77rt Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[melvin-bot[bot]]

@alexpensify, @youssef-lr, @s77rt 12 days overdue now... This issue's end is nigh!

[alexpensify]

Still waiting on @youssef-lr here and he is OOO, no update.

[melvin-bot[bot]]

This issue has not been updated in over 14 days. @alexpensify, @youssef-lr, @s77rt eroding to Weekly issue.

[alexpensify]

@youssef-lr are you able to pick this one back up?

[youssef-lr]

Yup, I'm on it, will provide an update by EOD tomorrow

[youssef-lr]

@alexpensify fixing this one in the backend turned out to be a bit complicated, I'm afraid fixing the query might significantly slow it down, I'm going to double check in eng-chat

[alexpensify]

Thanks for the update!

[youssef-lr]

I'm exploring an alternative solution, will report back here next week!

[alexpensify]

Thank you @youssef-lr!

Heads up, I will be offline from Friday, December 22, to Thursday, January 4, 2024. I will not be actively watching over this GitHub during that period. If anything urgent is needed here, please ask for help in the #expensify-open-source Slack Room-- thanks!

[youssef-lr]

No update yet, I'm still on it. I should have an update by EOW.

[youssef-lr]

It seems like the change we were planning to make is already in main, and still does not solve the issue. This seems like an issue with Onyx updates. I'm gonna keep investigating, but I think it's a low priority right now as the reproduction steps may not happen much in real world scenarios.

[youssef-lr]

No update yet.

[youssef-lr]

I haven't managed to get to this yet. I'm focusing on higher priority issues.

[youssef-lr]

No update yet, still a low priority.

[youssef-lr]

Same.

[youssef-lr]

No update yet.

[youssef-lr]

Same.

[youssef-lr]

No update yet

[youssef-lr]

Same.

[youssef-lr]

No update yet.

[youssef-lr]

No update yet, still a low priority.