search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.54k stars 2.89k forks source link

[HOLD for payment 2023-11-06] [HOLD for payment 2023-11-02] Android - Attachments- uploaded attachments can be seen only after scrolling up the page #30395

Closed lanitochka17 closed 1 year ago

lanitochka17 commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.91-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

  1. Launch app
  2. Tap on a report
  3. Tap on plus icon near compose box
  4. Tap attachments
  5. Upload any attachment pdf, or image
  6. Tap send
  7. Scroll up the page

Expected Result:

The attachment file uploaded must be fully visible The uploaded attachments must be visible without scrolling up the page

Actual Result:

The attachment file uploaded - pdf(up.mp4) not fully visible and image(attacks.mp4) only partially visible. The uploaded attachments can be seen only after scrolling up the page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native https://github.com/Expensify/App/assets/78819774/c2bf87c6-9a59-4872-98c1-6ad3221f7e09 https://github.com/Expensify/App/assets/78819774/bb332f6e-a85b-4a84-bfb0-eab7cd16011d
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @roryabraham
melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

OSBotify commented 1 year ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

marcaaron commented 1 year ago

I have a feeling this is related to the bidirectional pagination PR changes. Unfortunately, I am having trouble building the Android app in any capacity. It is completely broken for me.

marcaaron commented 1 year ago

Testing Android build with AdHoc https://github.com/Expensify/App/pull/30409

marcaaron commented 1 year ago

Confirmed the issue does not happen after revert. Maybe we can get a quick fix out though instead of actually reverting as the changes look great otherwise.

marcaaron commented 1 year ago

@janicduplessis may be able to help?

janicduplessis commented 1 year ago

👍 I'll have a look tomorrow

roryabraham commented 1 year ago

Going to see if I can get this one fixed quickly

roryabraham commented 1 year ago

Thinking about an autoScrollToTopThreshold of at least 56, to account for the full height of the uploading attachment... message:

image

May need to go a bit higher to also fix https://github.com/Expensify/App/issues/30423

melvin-bot[bot] commented 1 year ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] commented 1 year ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 year ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.91-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-02. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

melvin-bot[bot] commented 1 year ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

janicduplessis commented 1 year ago

Looks like a good solution, thx @roryabraham

melvin-bot[bot] commented 1 year ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.3.92-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-06. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

melvin-bot[bot] commented 1 year ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

roryabraham commented 1 year ago

BZ checklist complete, no payments due