Workspace - Process is looped when attempting to split Distance request in workspace chat

kbecciv commented 10 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.97.0 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Issue found when executing PR https://github.com/Expensify/App/pull/31025

Action Performed:

Navigate to staging.new.expensify.com
Go to workspace chat.
Click + > Request money > Distance.
Enter addresses and click Next.

Expected Result:

User is able to proceed beyond Split bill - Distance.

Actual Result:

User is unable to proceed beyond Split bill - Distance. The process is looped.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/e41638e8-e1a0-4326-83e6-a7698b0abfb9

View all open jobs on GitHub

OSBotify commented 10 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot[bot] commented 10 months ago

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

marcaaron commented 10 months ago

@neil-marcellini any ideas?

marcaaron commented 10 months ago

These two seem related to distance:

https://github.com/Expensify/App/pull/30754 https://github.com/Expensify/App/pull/30881

I can try reverting both.

marcaaron commented 10 months ago

I am pretty lost. This option doesn't seem to exist locally so I can't test why it's broken.

marcaaron commented 10 months ago

Ah you can split a distance request in a workspace chat. Did not realize this 👀

marcaaron commented 10 months ago

Pretty sure this was introduced here https://github.com/Expensify/App/pull/31025

marcaaron commented 10 months ago

I could not test this on production because the option didn't exist.

puneetlath commented 10 months ago

Ok so what happened here is:

before the option to split a bill was only available on Control workspaces
now the split bill option is available on all workspaces

On workspaces where you can split a bill, we've always had the distance option, so that bug exists on production. What is new is the ability to split a bill work all workspaces.

So I'm going to treat this not as a deploy blocker. I started a discussion about what the ideal behavior should be here: https://expensify.slack.com/archives/C02NZ2HGJAZ/p1699533520918679

marcaaron commented 10 months ago

Sounds good. Thanks for looking at that @puneetlath 🙇

melvin-bot[bot] commented 10 months ago

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 10 months ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

puneetlath commented 10 months ago

@kevinksullivan FYI based on this thread it sounds like this will be solved by the distance P2P project that @neil-marcellini is working on. https://expensify.slack.com/archives/C02NZ2HGJAZ/p1699533520918679

melvin-bot[bot] commented 10 months ago

@kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 10 months ago

@kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

kevinksullivan commented 10 months ago

Just read up on that thread, looks like we'll close this out then!

Expensify / App