[HOLD for payment 2023-11-30] [$500] IOU-Description is shown in preview in manual request while receipt is uploading.

izarutskaya commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.97-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause-Internal Team Slack conversation: @

Action Performed:

Go to https://staging.new.expensify.com/
Tap fab
Tap request money--- Manual
Enter an amount and tap next
Select a user
Tap on 3 dots and "add receipt"
Enter description
Tap request amount
Tap on IOU

Expected Result:

In IOU report, the description must not be shown in preview while receipt is uploading.

Actual Result:

In IOU report, the description is shown in preview in manual request while receipt is uploading.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/115492554/e0d51111-c360-4129-8c39-230ab22add88

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0136e412ae57e89702
Upwork Job ID: 1722554040572862464
Last Price Increase: 2023-11-09
Automatic offers:

DylanDylann | Contributor | 27670888

melvin-bot[bot] commented 1 year ago

Job added to Upwork: https://www.upwork.com/jobs/~0136e412ae57e89702

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

DylanDylann commented 1 year ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU-Description is shown in preview in manual request while receipt is uploading

What is the root cause of that problem?

This is the currently logic

    const shouldShowDescription = !_.isEmpty(description) && !shouldShowMerchant;

we don't have logic to check if receipt is canning

What changes do you think we should make in order to solve the problem?

Should add a logic to check if receipt is canning we will hide description like this

    const shouldShowDescription = !_.isEmpty(description) && !shouldShowMerchant && !isScanning

What alternative solutions did you explore? (Optional)

We also consider to add isScanning condition to definition of shouldShowMerchant too

PiyushChandra17 commented 1 year ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU-Description is shown in preview in manual request while receipt is uploading

What is the root cause of that problem?

We are not checking for,

https://github.com/Expensify/App/blob/16e40c949541b2b5c0fcec20a3ba308d743fbe77/src/components/ReportActionItem/MoneyRequestPreview.js#L164

Here,

https://github.com/Expensify/App/blob/16e40c949541b2b5c0fcec20a3ba308d743fbe77/src/components/ReportActionItem/MoneyRequestPreview.js#L174

Perhaps this is the root cause

What changes do you think we should make in order to solve the problem?

First things first check for isScanning upfront,

const shouldShowDescription = !isScanning && !_.isEmpty(description) && !shouldShowMerchant;

What alternative solutions did you explore? (Optional)

NA

allroundexperts commented 12 months ago

Thanks for your proposal @PiyushChandra17. I wasn't able to find it very different from what @DylanDylann proposed earlier.

@DylanDylann's proposal looks good.

🎀 👀 🎀 C+ reviewed

melvin-bot[bot] commented 12 months ago

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

MitchExpensify commented 12 months ago

Are we good to assign @DylanDylann , @marcochavezf ?

marcochavezf commented 12 months ago

Yup, thanks for the review @allroundexperts, the solution lgtm as well, assigning @DylanDylann 🚀

melvin-bot[bot] commented 12 months ago

📣 @allroundexperts Please request via NewDot manual requests for the Reviewer role ($500)

melvin-bot[bot] commented 12 months ago

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

DylanDylann commented 12 months ago

@allroundexperts PR https://github.com/Expensify/App/pull/31348 is ready to review

melvin-bot[bot] commented 11 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 11 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.2-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/31348

If no regressions arise, payment will be issued on 2023-11-30. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@allroundexperts does not require payment (Eligible for Manual Requests)
@DylanDylann requires payment offer (Contributor)

melvin-bot[bot] commented 11 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@allroundexperts] Determine if we should create a regression test for this bug.
[ ] [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

MitchExpensify commented 11 months ago

Payment summary:

$500 - @allroundexperts, C+, NewDot $500 - @DylanDylann, C, Upwork

allroundexperts commented 11 months ago

Checklist

https://github.com/Expensify/App/pull/26603
https://github.com/Expensify/App/pull/26603/files#r1405482536
N/A
Regression test would be helpful. The steps given in the OP look good enough to me!

MitchExpensify commented 11 months ago

Paid and contract ended, @DylanDylann

Added request for new test here: https://github.com/Expensify/Expensify/issues/343038

Closing as payment for @allroundexperts will occur on NewDot

Thanks every one!

JmillsExpensify commented 11 months ago

$500 payment approved for @allroundexperts based on this comment.

Expensify / App