Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.33k stars 2.76k forks source link

[$500] Scan - "Receipt scanning failed. Please enter the details manually" is visible to requestee #31140

Closed lanitochka17 closed 7 months ago

lanitochka17 commented 10 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.97-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

  1. [User A] Go to chat with User B > + > Request money > Scan
  2. [User A] Create a Scan request with a receipt that will fail the smartscanning
  3. [User B] Open the Scan request details page when the smartscanning fails Note that User B can see the Receipt scanning failed message which also asks User A to enter the details manually

Expected Result:

"Receipt scanning failed. Please enter the details manually" message will not appear to User B

Actual Result:

"Receipt scanning failed. Please enter the details manually" message appears to User B. It is giving the impression that User B is asked to enter the details manually, when the message is aimed at User A

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6270183_1699546745794!IMG_0726

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d0904e9e5de86b0d
  • Upwork Job ID: 1722652686187794432
  • Last Price Increase: 2023-11-30
dylanexpensify commented 7 months ago

Payment summary:

Please request!

youssef-lr commented 7 months ago

@eVoloshchak did we have an App PR for this, or only a backend fix?

JmillsExpensify commented 7 months ago

Holding on approving until we get clarity.

eVoloshchak commented 7 months ago

I thought we did update the system message to Receipt scanning failed. Enter the details manually on front end, but looking at https://github.com/Expensify/App/issues/31140#issuecomment-1828000293, this was done on the back end I don't think I'm eligible for payment on this one, apologies for the confusion everyone

youssef-lr commented 7 months ago

All good, thanks for confirming!

JmillsExpensify commented 7 months ago

No worries! Thanks