[HOLD for payment 2023-12-07] [$500] Address - Blue border appears around the row and the field is not focused when using Tab key

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.98-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

1. Navigate to staging.new.expensify.com
2. Go to Settings > Profile > Personal details > Address
3. Click on any field
4. Navigate to the next field with tab key

Expected Result:

The next field will be focused with just one click

Actual Result:

A blue border appears around the field and the next field is not focused. It is only focused after pressing Tab key for the second time This issue also happens in other area of the app that involve entering value

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/85a2b1e3-7aa6-460e-a468-b398c566ccbc

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e6211747d5d8420e
• Upwork Job ID: 1723065952129036288
• Last Price Increase: 2023-11-17
• Automatic offers:
• Ollyws | Reviewer | 27794733
• tienifr | Contributor | 27794734

[melvin-bot[bot]]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01e6211747d5d8420e

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Blue border appears around the row and the field is not focused when using Tab key. This issue happens to all TextInput components.

What is the root cause of that problem?

The container wrapping text input is intentionally set with tabIndex=-1 to avoid navigating by tab to focus on itself.

https://github.com/Expensify/App/blob/3939beaf7969fb04bc46083b395a45118a406b05/src/components/TextInput/BaseTextInput/index.js#L258

However inside WebGenericPressable, we do not pass tabIndex properly:

https://github.com/Expensify/App/blob/3939beaf7969fb04bc46083b395a45118a406b05/src/components/Pressable/GenericPressable/index.tsx#L16

Previously we used focusable to determine tabIndex. However, now focusable is replaced with tabIndex due to RNW upgrade. Therefore, if tabIndex is used, we should prioritize it and should not depend merely on focusable (deprecated) and accessible.

What changes do you think we should make in order to solve the problem?

Pass tabIndex like this:

tabIndex={props.tabIndex ?? (!accessible || !focusable ? -1 : 0)}

What alternative solutions did you explore? (Optional)

NA

[s-alves10]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Blue border appears on the row when pressing tab key in the address page

What is the root cause of that problem?

To prevent focusing by tab, we set tabIndex=-1 below https://github.com/Expensify/App/blob/3939beaf7969fb04bc46083b395a45118a406b05/src/components/TextInput/BaseTextInput/index.js#L258

but tabIndex is changed here https://github.com/Expensify/App/blob/3939beaf7969fb04bc46083b395a45118a406b05/src/components/Pressable/GenericPressable/index.tsx#L16

This is the root cause

What changes do you think we should make in order to solve the problem?

I think we need to use props.tabIndex if exists Update https://github.com/Expensify/App/blob/3939beaf7969fb04bc46083b395a45118a406b05/src/components/Pressable/GenericPressable/index.tsx#L16 to

            tabIndex={props.tabIndex ?? (!accessible || !focusable) ? -1 : 0}

This works as expected

What alternative solutions did you explore? (Optional)

[isabelastisser]

Hey @Ollyws, can you please review the proposals above? Thanks!

[isabelastisser]

@Ollyws please provide an update. Thanks!

[erquhart]

This is a regression caused by #31118, the fix for #31098.

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[jeet-dhandha]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Issue is that we are not able to focus on next textinput.

What is the root cause of that problem?

• In WebGenericPressable ( https://github.com/Expensify/App/blob/main/src/components/Pressable/GenericPressable/index.tsx ) we are not forwarding tabIndex prop when it is defined from parent component.
• We have few implementations of GenericPressable where we are passing it but haven't checked if its being forwarded or not.
• Like in this commit:
  • https://github.com/Expensify/App/commit/465f0a817dfe5c9ffb50b71accff13a4fdfa81d1

What changes do you think we should make in order to solve the problem?

• We should check if tabIndex is undefined or not and then forward it. We are checking if it is undefined or not as we might want to focus it by passing 0 as tabIndex. And thus we can't use short hand operator || like this tabIndex={props.tabIndex || (!accessible || !focusable ? -1 : 0)} as it will not forward 0 as tabIndex.

const tabIndex = props.tabIndex !== undefined ? props.tabIndex : !accessible || !focusable ? -1 : 0;

tabIndex={tabIndex}

What alternative solutions did you explore? (Optional)

• If we are sure we don't want Pressable in BaseTextInput/index.js then we pass accessible={false} like we did in CheckboxWithLabel.
  • https://github.com/Expensify/App/blob/91ef64083723d1ef98351f6f0e6eafeea6950117/src/components/CheckboxWithLabel.js#L112-L115

This also resolves our issue but i wasn't sure if this could affect other parts of the code or not.

[melvin-bot[bot]]

@Ollyws, @isabelastisser Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot[bot]]

@Ollyws, @isabelastisser Huh... This is 4 days overdue. Who can take care of this?

[Ollyws]

@tienifr's proposal looks good to me.

🎀👀🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @deetergp, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot[bot]]

📣 @Ollyws 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[melvin-bot[bot]]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[tienifr]

PR ready for review https://github.com/Expensify/App/pull/31810.

[isabelastisser]

@Ollyws any updates here?

[Ollyws]

PR is merged.

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.5-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/31810

If no regressions arise, payment will be issued on 2023-12-07. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter
• [x] Contributor that fixed the issue
• [x] Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment offer (Reviewer)
• @tienifr requires payment offer (Contributor)

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@Ollyws] Determine if we should create a regression test for this bug.
• [ ] [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[isabelastisser]

@Ollyws can you please complete the list above? Thanks!

[isabelastisser]

@Ollyws and @tienifr please accept the offers in Upwork and I will process the payments. Thanks!

@Ollyws requires payment offer (Reviewer) @tienifr requires payment offer (Contributor)

[tienifr]

@isabelastisser I accepted, thanks!

[isabelastisser]

Bump @Ollyws to complete the checklist above. Thanks!

[isabelastisser]

Hey @Ollyws, can you please complete the checklist above? Thanks!

[Ollyws]

BugZero Checklist:

• [x] The PR that introduced the bug has been identified. Link to the PR:

This started occuring due to the RNW upgrade but we can't really call it a regression as it's out of our hands.

• [x] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

N/A

• [x] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

N/A

• [x] Determine if we should create a regression test for this bug.

This is a minor visual issue that doesn't really affect the flow in any significant way so I don't think a regression test is necessary here.

[isabelastisser]

Thanks! @Ollyws, please accept the offer in Upwork.

[Ollyws]

Accepted, thanks!

[Ollyws]

@isabelastisser The job is still open and unpaid on upwork for me if you could take a look, thanks!

[isabelastisser]

All set!