search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.53k stars 2.88k forks source link

Wallet - Error appears when system attempts to verify Onfido information #31237

Closed kbecciv closed 11 months ago

kbecciv commented 12 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.98.0 Reproducible in staging?: y Reproducible in production?: can not test on production If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Issue found when executing PR https://github.com/Expensify/App/pull/30791

Action Performed:

Pre-requisite: user must be logged in.

  1. Go to Wallet.
  2. Tap on "Enable Wallet" button.
  3. Complete the process by adding a bank account and complete the Onfido process.
  4. Wait for system confirmation.

Expected Result:

The system should approve or reject the information provided on Onfido page.

Actual Result:

Error appears when system attempts to verify Onfido information

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

image

View all open jobs on GitHub

OSBotify commented 12 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
melvin-bot[bot] commented 12 months ago

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

anuraagdjain commented 12 months ago

The issue was not posted on Upwork, but I still tried replicating this. I did my ID verification on my iOS web browser while the staging app was running on my machine. There was no way for the error to be shown on Onfido page in my mobile as it says me to check the status on the desktop app. I initially was seeing the walletActivationPending text and after verification failed I saw walletActivationFailed.

If the message was shown while the verification was happening in the background, then the issue could be in this logic here . We need to modify the condition if(!isPendingOnfidoResult && hasFailedOnfido) so we don't see the error message while verification is happening.

melvin-bot[bot] commented 12 months ago

📣 @anuraagdjain! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format: 
    Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
bondydaa commented 12 months ago

@kbecciv looks like we had some big incident this weekend around the time you created this, can you test again now and see if you still have issues?

kbecciv commented 12 months ago

@bondydaa The issue is still being reproduced IMG_1501

bondydaa commented 12 months ago

@marcaaron @nkuoch @MariaHCD since ya'll were involved with https://github.com/Expensify/Web-Expensify/pull/39342, any ideas here?

@kbecciv what email/login is this from so we can look up logs?

MariaHCD commented 11 months ago

That error is expected if the Onfido verification failed. Once we have the email that was used for testing, we can confirm whether the Onfido check failed (and why)

kbecciv commented 11 months ago

@bondydaa Email provided - https://expensify.slack.com/archives/C9YU7BX5M/p1699979315601279?thread_ts=1699977627.556279&cid=C9YU7BX5M

bondydaa commented 11 months ago

ran the query that looks up the wallet for a user.

dbondy@db2.rno:~$ sudo readdb.sh -line "select bankAccountID from bankaccounts WHERE accountID=16011227 and state in (0,1);"
bankAccountID = 3161713

dbondy@db2.rno:~$ sudo readdb.sh -line "select * from bankaccounts where bankaccountid=3161713;"
       created = 2023-11-10 21:10:42
 bankAccountID = 3161713
     accountID = 16011227
       deleted = 0
 accountNumber = v10:65E17A87E7994DDA4CBCEA0297EE9B58
 routingNumber = 031101114
      checking = 1
   addressName = Expensify Wallet
additionalData = {"accountHistory":[{"stateChangeDate":"1699650642506979","stateChangeTo":"Pending"}],"country":"US","currency":"USD","fieldsType":"local"}
   addressCity = false
  addressState = false
    addressZip =
 defaultCredit = 0
         state = 0
  validateCode =
     processor =
          type = 0

I can't see the original images/video on the OP image

but from the looks of it there is an error while trying to do the validation checks?

bondydaa commented 11 months ago

i'm not seeing any logs for onfido and that bank accountid

image

bondydaa commented 11 months ago

I tested this myself on a test account and it seemed to work.

Looking for requests for applausetester+vd_1110@applause.expensifail.com that I see in my network tab I'm not seeing anything of these image image

looks like there are some for applausetester+vd_ios1110@applause.expensifail.com and applausetester+vd_1109@applause.expensifail.com image

which have these logs:

2023-11-11 04:01:55 864 applausetester+vd_ios1110@applause.expensifail.com  undefined   db1.lax 8243a3033d6f5c71-MIA    Bank account 3163628 didn't need validation
2023-11-11 04:01:55 864 applausetester+vd_ios1110@applause.expensifail.com  undefined   db1.lax 8243a3033d6f5c71-MIA    Not retrieving copies for Plaid test account that has thousands of copies
2023-11-11 04:01:55 917 applausetester+vd_ios1110@applause.expensifail.com  /api.php    staging-www1.lax    8243a3033d6f5c71-MIA    [BankAccountSetup] Onfido_API - Calling Onfido to perform facial_similarity check ~~ applicantID: 'ff04d9ec-ef5f-4f03-8bf5-83a30bb807a0' bankAccountID: '3163628' accountID: '16012072' variant: 'video'
2023-11-11 04:01:56 782 applausetester+vd_ios1110@applause.expensifail.com  /api.php    staging-www1.lax    8243a3033d6f5c71-MIA    [BankAccountSetup] Onfido_API - Retrieved Onfido check ~~ url: 'https://api.onfido.com/v3/checks/09dfa915-26fb-4177-9c3c-d96772b4abaa' response: '{"id":"09dfa915-26fb-4177-9c3c-d96772b4abaa","created_at":"2023-11-11T04:01:56Z","status":"in_progress","redirect_uri":null,"result":null,"sandbox":false,"tags":["bankAccountID_3163628","accountID_16012072","env_staging"],"results_uri":"https:\/\/dashboard.onfido.com\/checks\/09dfa915-26fb-4177-9c3c-d96772b4abaa","form_uri":null,"paused":false,"version":"3.0","report_ids":["d09ee167-75f3-461a-ae3f-168cfe862519","74eb8c32-3840-4b78-82da-f77ad06fd864"],"href":"\/v3\/checks\/09dfa915-26fb-4177-9c3c-d96772b4abaa","applicant_id":"ff04d9ec-ef5f-4f03-8bf5-83a30bb807a0","applicant_provides_data":false}'
2023-11-11 04:01:56 782 applausetester+vd_ios1110@applause.expensifail.com  /api.php    staging-www1.lax    8243a3033d6f5c71-MIA    Onfido_API - Listing Onfido reports ~~ checkID: '09dfa915-26fb-4177-9c3c-d96772b4abaa'
2023-11-11 04:01:57 001 applausetester+vd_ios1110@applause.expensifail.com  /api.php    staging-www1.lax    8243a3033d6f5c71-MIA    [BankAccountSetup] Onfido_API - Retrieved Onfido check reports ~~ checkID: '09dfa915-26fb-4177-9c3c-d96772b4abaa' response: '{"reports":[{"id":"d09ee167-75f3-461a-ae3f-168cfe862519","created_at":"2023-11-11T04:01:56+00:00","href":"\/v3\/reports\/d09ee167-75f3-461a-ae3f-168cfe862519","status":"awaiting_data","breakdown":[],"properties":[],"check_id":"09dfa915-26fb-4177-9c3c-d96772b4abaa","name":"facial_similarity_video","documents":[]},{"id":"74eb8c32-3840-4b78-82da-f77ad06fd864","created_at":"2023-11-11T04:01:56+00:00","href":"\/v3\/reports\/74eb8c32-3840-4b78-82da-f77ad06fd864","status":"awaiting_data","breakdown":[],"properties":[],"check_id":"09dfa915-26fb-4177-9c3c-d96772b4abaa","name":"document","documents":[{"id":"4e035f49-0b76-416b-8af7-e17e448749ee"},{"id":"85d34d79-bb7b-4dc4-9557-000d29d45875"}]}]}'
2023-11-11 04:01:58 205 applausetester+vd_ios1110@applause.expensifail.com  /api.php    staging-www1.lax    8243a3033d6f5c71-MIA    [BankAccountSetup] Onfido_API - Retrieved Onfido check ~~ url: 'https://api.onfido.com/v3/checks/09dfa915-26fb-4177-9c3c-d96772b4abaa' response: '{"id":"09dfa915-26fb-4177-9c3c-d96772b4abaa","created_at":"2023-11-11T04:01:56Z","status":"in_progress","redirect_uri":null,"result":null,"sandbox":false,"tags":["bankAccountID_3163628","accountID_16012072","env_staging"],"results_uri":"https:\/\/dashboard.onfido.com\/checks\/09dfa915-26fb-4177-9c3c-d96772b4abaa","form_uri":null,"paused":false,"version":"3.0","report_ids":["d09ee167-75f3-461a-ae3f-168cfe862519","74eb8c32-3840-4b78-82da-f77ad06fd864"],"href":"\/v3\/checks\/09dfa915-26fb-4177-9c3c-d96772b4abaa","applicant_id":"ff04d9ec-ef5f-4f03-8bf5-83a30bb807a0","applicant_provides_data":false}'
2023-11-11 04:01:58 205 applausetester+vd_ios1110@applause.expensifail.com  /api.php    staging-www1.lax    8243a3033d6f5c71-MIA    Onfido_API - Listing Onfido reports ~~ checkID: '09dfa915-26fb-4177-9c3c-d96772b4abaa'
2023-11-11 04:01:58 441 applausetester+vd_ios1110@applause.expensifail.com  /api.php    staging-www1.lax    8243a3033d6f5c71-MIA    [BankAccountSetup] Onfido_API - Retrieved Onfido check reports ~~ checkID: '09dfa915-26fb-4177-9c3c-d96772b4abaa' response: '{"reports":[{"id":"d09ee167-75f3-461a-ae3f-168cfe862519","created_at":"2023-11-11T04:01:56+00:00","href":"\/v3\/reports\/d09ee167-75f3-461a-ae3f-168cfe862519","status":"awaiting_data","breakdown":[],"properties":[],"check_id":"09dfa915-26fb-4177-9c3c-d96772b4abaa","name":"facial_similarity_video","documents":[]},{"id":"74eb8c32-3840-4b78-82da-f77ad06fd864","created_at":"2023-11-11T04:01:56+00:00","href":"\/v3\/reports\/74eb8c32-3840-4b78-82da-f77ad06fd864","status":"awaiting_data","breakdown":[],"properties":[],"check_id":"09dfa915-26fb-4177-9c3c-d96772b4abaa","name":"document","documents":[{"id":"4e035f49-0b76-416b-8af7-e17e448749ee"},{"id":"85d34d79-bb7b-4dc4-9557-000d29d45875"}]}]}'
2023-11-11 04:01:59 645 applausetester+vd_ios1110@applause.expensifail.com  /api.php    staging-www1.lax    8243a3033d6f5c71-MIA    [BankAccountSetup] Onfido_API - Retrieved Onfido check ~~ url: 'https://api.onfido.com/v3/checks/09dfa915-26fb-4177-9c3c-d96772b4abaa' response: '{"id":"09dfa915-26fb-4177-9c3c-d96772b4abaa","created_at":"2023-11-11T04:01:56Z","status":"in_progress","redirect_uri":null,"result":null,"sandbox":false,"tags":["bankAccountID_3163628","accountID_16012072","env_staging"],"results_uri":"https:\/\/dashboard.onfido.com\/checks\/09dfa915-26fb-4177-9c3c-d96772b4abaa","form_uri":null,"paused":false,"version":"3.0","report_ids":["d09ee167-75f3-461a-ae3f-168cfe862519","74eb8c32-3840-4b78-82da-f77ad06fd864"],"href":"\/v3\/checks\/09dfa915-26fb-4177-9c3c-d96772b4abaa","applicant_id":"ff04d9ec-ef5f-4f03-8bf5-83a30bb807a0","applicant_provides_data":false}'
2023-11-11 04:01:59 645 applausetester+vd_ios1110@applause.expensifail.com  /api.php    staging-www1.lax    8243a3033d6f5c71-MIA    Onfido_API - Listing Onfido reports ~~ checkID: '09dfa915-26fb-4177-9c3c-d96772b4abaa'
2023-11-11 04:01:59 846 applausetester+vd_ios1110@applause.expensifail.com  /api.php    staging-www1.lax    8243a3033d6f5c71-MIA    [BankAccountSetup] Onfido_API - Retrieved Onfido check reports ~~ checkID: '09dfa915-26fb-4177-9c3c-d96772b4abaa' response: '{"reports":[{"id":"d09ee167-75f3-461a-ae3f-168cfe862519","created_at":"2023-11-11T04:01:56+00:00","href":"\/v3\/reports\/d09ee167-75f3-461a-ae3f-168cfe862519","status":"awaiting_data","breakdown":[],"properties":[],"check_id":"09dfa915-26fb-4177-9c3c-d96772b4abaa","name":"facial_similarity_video","documents":[]},{"id":"74eb8c32-3840-4b78-82da-f77ad06fd864","created_at":"2023-11-11T04:01:56+00:00","href":"\/v3\/reports\/74eb8c32-3840-4b78-82da-f77ad06fd864","status":"awaiting_data","breakdown":[],"properties":[],"check_id":"09dfa915-26fb-4177-9c3c-d96772b4abaa","name":"document","documents":[{"id":"4e035f49-0b76-416b-8af7-e17e448749ee"},{"id":"85d34d79-bb7b-4dc4-9557-000d29d45875"}]}]}'
2023-11-11 04:02:01 046 applausetester+vd_ios1110@applause.expensifail.com  /api.php    staging-www1.lax    8243a3033d6f5c71-MIA    [BankAccountSetup] Onfido_API - Retrieved Onfido check ~~ url: 'https://api.onfido.com/v3/checks/09dfa915-26fb-4177-9c3c-d96772b4abaa' response: '{"id":"09dfa915-26fb-4177-9c3c-d96772b4abaa","created_at":"2023-11-11T04:01:56Z","status":"in_progress","redirect_uri":null,"result":null,"sandbox":false,"tags":["bankAccountID_3163628","accountID_16012072","env_staging"],"results_uri":"https:\/\/dashboard.onfido.com\/checks\/09dfa915-26fb-4177-9c3c-d96772b4abaa","form_uri":null,"paused":false,"version":"3.0","report_ids":["d09ee167-75f3-461a-ae3f-168cfe862519","74eb8c32-3840-4b78-82da-f77ad06fd864"],"href":"\/v3\/checks\/09dfa915-26fb-4177-9c3c-d96772b4abaa","applicant_id":"ff04d9ec-ef5f-4f03-8bf5-83a30bb807a0","applicant_provides_data":false}'
2023-11-11 04:02:01 046 applausetester+vd_ios1110@applause.expensifail.com  /api.php    staging-www1.lax    8243a3033d6f5c71-MIA    Onfido_API - Listing Onfido reports ~~ checkID: '09dfa915-26fb-4177-9c3c-d96772b4abaa'
2023-11-11 04:02:01 516 applausetester+vd_ios1110@applause.expensifail.com  /api.php    staging-www1.lax    8243a3033d6f5c71-MIA    [BankAccountSetup] Onfido_API - Retrieved Onfido check reports ~~ checkID: '09dfa915-26fb-4177-9c3c-d96772b4abaa' response: '{"reports":[{"id":"d09ee167-75f3-461a-ae3f-168cfe862519","created_at":"2023-11-11T04:01:56+00:00","href":"\/v3\/reports\/d09ee167-75f3-461a-ae3f-168cfe862519","status":"awaiting_data","breakdown":[],"properties":[],"check_id":"09dfa915-26fb-4177-9c3c-d96772b4abaa","name":"facial_similarity_video","documents":[]},{"id":"74eb8c32-3840-4b78-82da-f77ad06fd864","created_at":"2023-11-11T04:01:56+00:00","href":"\/v3\/reports\/74eb8c32-3840-4b78-82da-f77ad06fd864","status":"awaiting_data","breakdown":[],"properties":[],"check_id":"09dfa915-26fb-4177-9c3c-d96772b4abaa","name":"document","documents":[{"id":"4e035f49-0b76-416b-8af7-e17e448749ee"},{"id":"85d34d79-bb7b-4dc4-9557-000d29d45875"}]}]}'
2023-11-11 04:02:02 724 applausetester+vd_ios1110@applause.expensifail.com  /api.php    staging-www1.lax    8243a3033d6f5c71-MIA    [BankAccountSetup] Onfido_API - Retrieved Onfido check ~~ url: 'https://api.onfido.com/v3/checks/09dfa915-26fb-4177-9c3c-d96772b4abaa' response: '{"id":"09dfa915-26fb-4177-9c3c-d96772b4abaa","created_at":"2023-11-11T04:01:56Z","status":"in_progress","redirect_uri":null,"result":null,"sandbox":false,"tags":["bankAccountID_3163628","accountID_16012072","env_staging"],"results_uri":"https:\/\/dashboard.onfido.com\/checks\/09dfa915-26fb-4177-9c3c-d96772b4abaa","form_uri":null,"paused":false,"version":"3.0","report_ids":["d09ee167-75f3-461a-ae3f-168cfe862519","74eb8c32-3840-4b78-82da-f77ad06fd864"],"href":"\/v3\/checks\/09dfa915-26fb-4177-9c3c-d96772b4abaa","applicant_id":"ff04d9ec-ef5f-4f03-8bf5-83a30bb807a0","applicant_provides_data":false}'
2023-11-11 04:02:02 724 applausetester+vd_ios1110@applause.expensifail.com  /api.php    staging-www1.lax    8243a3033d6f5c71-MIA    Onfido_API - Listing Onfido reports ~~ checkID: '09dfa915-26fb-4177-9c3c-d96772b4abaa'
2023-11-11 04:02:02 934 applausetester+vd_ios1110@applause.expensifail.com  /api.php    staging-www1.lax    8243a3033d6f5c71-MIA    [BankAccountSetup] Onfido_API - Retrieved Onfido check reports ~~ checkID: '09dfa915-26fb-4177-9c3c-d96772b4abaa' response: '{"reports":[{"id":"d09ee167-75f3-461a-ae3f-168cfe862519","created_at":"2023-11-11T04:01:56+00:00","href":"\/v3\/reports\/d09ee167-75f3-461a-ae3f-168cfe862519","status":"awaiting_data","breakdown":[],"properties":[],"check_id":"09dfa915-26fb-4177-9c3c-d96772b4abaa","name":"facial_similarity_video","documents":[]},{"id":"74eb8c32-3840-4b78-82da-f77ad06fd864","created_at":"2023-11-11T04:01:56+00:00","href":"\/v3\/reports\/74eb8c32-3840-4b78-82da-f77ad06fd864","status":"awaiting_data","breakdown":[],"properties":[],"check_id":"09dfa915-26fb-4177-9c3c-d96772b4abaa","name":"document","documents":[{"id":"4e035f49-0b76-416b-8af7-e17e448749ee"},{"id":"85d34d79-bb7b-4dc4-9557-000d29d45875"}]}]}'
2023-11-11 04:02:04 226 applausetester+vd_ios1110@applause.expensifail.com  /api.php    staging-www1.lax    8243a3033d6f5c71-MIA    [BankAccountSetup] Onfido_API - Retrieved Onfido check ~~ url: 'https://api.onfido.com/v3/checks/09dfa915-26fb-4177-9c3c-d96772b4abaa' response: '{"id":"09dfa915-26fb-4177-9c3c-d96772b4abaa","created_at":"2023-11-11T04:01:56Z","status":"in_progress","redirect_uri":null,"result":null,"sandbox":false,"tags":["bankAccountID_3163628","accountID_16012072","env_staging"],"results_uri":"https:\/\/dashboard.onfido.com\/checks\/09dfa915-26fb-4177-9c3c-d96772b4abaa","form_uri":null,"paused":false,"version":"3.0","report_ids":["74eb8c32-3840-4b78-82da-f77ad06fd864","d09ee167-75f3-461a-ae3f-168cfe862519"],"href":"\/v3\/checks\/09dfa915-26fb-4177-9c3c-d96772b4abaa","applicant_id":"ff04d9ec-ef5f-4f03-8bf5-83a30bb807a0","applicant_provides_data":false}'
2023-11-11 04:02:04 226 applausetester+vd_ios1110@applause.expensifail.com  /api.php    staging-www1.lax    8243a3033d6f5c71-MIA    Onfido_API - Listing Onfido reports ~~ checkID: '09dfa915-26fb-4177-9c3c-d96772b4abaa'
2023-11-11 04:02:04 458 applausetester+vd_ios1110@applause.expensifail.com  /api.php    staging-www1.lax    8243a3033d6f5c71-MIA    [BankAccountSetup] Onfido_API - Retrieved Onfido check reports ~~ checkID: '09dfa915-26fb-4177-9c3c-d96772b4abaa' response: '{"reports":[{"id":"74eb8c32-3840-4b78-82da-f77ad06fd864","created_at":"2023-11-11T04:01:56+00:00","href":"\/v3\/reports\/74eb8c32-3840-4b78-82da-f77ad06fd864","status":"awaiting_approval","breakdown":[],"properties":[],"check_id":"09dfa915-26fb-4177-9c3c-d96772b4abaa","name":"document","documents":[{"id":"4e035f49-0b76-416b-8af7-e17e448749ee"},{"id":"85d34d79-bb7b-4dc4-9557-000d29d45875"}]},{"id":"d09ee167-75f3-461a-ae3f-168cfe862519","created_at":"2023-11-11T04:01:56+00:00","href":"\/v3\/reports\/d09ee167-75f3-461a-ae3f-168cfe862519","status":"awaiting_data","breakdown":[],"properties":[],"check_id":"09dfa915-26fb-4177-9c3c-d96772b4abaa","name":"facial_similarity_video","documents":[]}]}'
2023-11-11 04:02:05 652 applausetester+vd_ios1110@applause.expensifail.com  /api.php    staging-www1.lax    8243a3033d6f5c71-MIA    [BankAccountSetup] Onfido_API - Retrieved Onfido check ~~ url: 'https://api.onfido.com/v3/checks/09dfa915-26fb-4177-9c3c-d96772b4abaa' response: '{"id":"09dfa915-26fb-4177-9c3c-d96772b4abaa","created_at":"2023-11-11T04:01:56Z","status":"in_progress","redirect_uri":null,"result":null,"sandbox":false,"tags":["bankAccountID_3163628","accountID_16012072","env_staging"],"results_uri":"https:\/\/dashboard.onfido.com\/checks\/09dfa915-26fb-4177-9c3c-d96772b4abaa","form_uri":null,"paused":false,"version":"3.0","report_ids":["74eb8c32-3840-4b78-82da-f77ad06fd864","d09ee167-75f3-461a-ae3f-168cfe862519"],"href":"\/v3\/checks\/09dfa915-26fb-4177-9c3c-d96772b4abaa","applicant_id":"ff04d9ec-ef5f-4f03-8bf5-83a30bb807a0","applicant_provides_data":false}'
2023-11-11 04:02:05 652 applausetester+vd_ios1110@applause.expensifail.com  /api.php    staging-www1.lax    8243a3033d6f5c71-MIA    Onfido_API - Listing Onfido reports ~~ checkID: '09dfa915-26fb-4177-9c3c-d96772b4abaa'
2023-11-11 04:02:05 896 applausetester+vd_ios1110@applause.expensifail.com  /api.php    staging-www1.lax    8243a3033d6f5c71-MIA    [BankAccountSetup] Onfido_API - Retrieved Onfido check reports ~~ checkID: '09dfa915-26fb-4177-9c3c-d96772b4abaa' response: '{"reports":[{"id":"74eb8c32-3840-4b78-82da-f77ad06fd864","created_at":"2023-11-11T04:01:56+00:00","href":"\/v3\/reports\/74eb8c32-3840-4b78-82da-f77ad06fd864","status":"awaiting_approval","breakdown":[],"properties":[],"check_id":"09dfa915-26fb-4177-9c3c-d96772b4abaa","name":"document","documents":[{"id":"4e035f49-0b76-416b-8af7-e17e448749ee"},{"id":"85d34d79-bb7b-4dc4-9557-000d29d45875"}]},{"id":"d09ee167-75f3-461a-ae3f-168cfe862519","created_at":"2023-11-11T04:01:56+00:00","href":"\/v3\/reports\/d09ee167-75f3-461a-ae3f-168cfe862519","status":"awaiting_data","breakdown":[],"properties":[],"check_id":"09dfa915-26fb-4177-9c3c-d96772b4abaa","name":"facial_similarity_video","documents":[]}]}'
2023-11-11 04:02:05 897 applausetester+vd_ios1110@applause.expensifail.com  /api.php    staging-www1.lax    8243a3033d6f5c71-MIA    BankAccountAPI - We could not retrieve Onfido check after 6 seconds! ~~ status: 'in_progress' checkURL: 'https://api.onfido.com/v3/checks/09dfa915-26fb-4177-9c3c-d96772b4abaa' response: '{"id":"09dfa915-26fb-4177-9c3c-d96772b4abaa","created_at":"2023-11-11T04:01:56Z","status":"in_progress","redirect_uri":null,"result":null,"sandbox":false,"tags":["bankAccountID_3163628","accountID_16012072","env_staging"],"results_uri":"https:\/\/dashboard.onfido.com\/checks\/09dfa915-26fb-4177-9c3c-d96772b4abaa","form_uri":null,"paused":false,"version":"3.0","report_ids":["74eb8c32-3840-4b78-82da-f77ad06fd864","d09ee167-75f3-461a-ae3f-168cfe862519"],"href":"\/v3\/checks\/09dfa915-26fb-4177-9c3c-d96772b4abaa","applicant_id":"ff04d9ec-ef5f-4f03-8bf5-83a30bb807a0","applicant_provides_data":false,"reports":[{"id":"74eb8c32-3840-4b78-82da-f77ad06fd864","created_at":"2023-11-11T04:01:56+00:00","href":"\/v3\/reports\/74eb8c32-3840-4b78-82da-f77ad06fd864","status":"awaiting_approval","breakdown":[],"properties":[],"check_id":"09dfa915-26fb-4177-9c3c-d96772b4abaa","name":"document","documents":[{"id":"4e035f49-0b76-416b-8af7-e17e448749ee"},{"id":"85d34d79-bb7b-4dc4-9557-000d29d45875"}]},{"id":"d09ee167-75f3-461a-ae3f-168cfe862519","created_at":"2023-11-11T04:01:56+00:00","href":"\/v3\/reports\/d09ee167-75f3-461a-ae3f-168cfe862519","status":"awaiting_data","breakdown":[],"properties":[],"check_id":"09dfa915-26fb-4177-9c3c-d96772b4abaa","name":"facial_similarity_video","documents":[]}]}'
2023-11-11 04:02:05 898 applausetester+vd_ios1110@applause.expensifail.com  /api.php    staging-www1.lax    8243a3033d6f5c71-MIA    Bedrock\Client - Starting a request ~~ command: 'ActivateWallet' clusterName: 'auth' headers: '[authToken: '<REDACTED>' verifications: '[externalApiResponses: '[requestorIdentityID: '[apiResult: '[id-number: '2026549069' qualifiers: '[qualifier: '[key: 'resultcode.newer.record.found' message: 'Newer Record Found']']' reason: 'Tested via external APIs' results: '[key: 'result.match' message: 'ID Located']' summary-result: '[key: 'id.success' message: 'PASS']']' status: 'pass' timestamp: '2023-11-11 03:59:08']' requestorIdentityOnfido: '[status: 'in_progress' apiResult: '[reason: 'Tested via external APIs' face: '[id: 'af9f6e41-0c4b-4f32-b679-324fda133892' variant: 'VIDEO']' document: '[front: '[id: '85d34d79-bb7b-4dc4-9557-000d29d45875']' back: '[id: '4e035f49-0b76-416b-8af7-e17e448749ee']']' applicantID: 'ff04d9ec-ef5f-4f03-8bf5-83a30bb807a0' id: '09dfa915-26fb-4177-9c3c-d96772b4abaa' created_at: '2023-11-11T04:01:56+00:00' href: '/v3/checks/09dfa915-26fb-4177-9c3c-d96772b4abaa' status: 'in_progress' results_uri: 'https://dashboard.onfido.com/checks/09dfa915-26fb-4177-9c3c-d96772b4abaa' applicant_id: 'ff04d9ec-ef5f-4f03-8bf5-83a30bb807a0' tags: '[0: 'bankAccountID_3163628' 1: 'accountID_16012072' 2: 'env_staging']' applicant_provides_data: '' report_ids: '[0: 'd09ee167-75f3-461a-ae3f-168cfe862519' 1: '74eb8c32-3840-4b78-82da-f77ad06fd864']']' timestamp: '2023-11-11 04:01:56']']']' personalDetails: '<REDACTED>' currentStep: 'OnfidoStep' hasAcceptedTerms: '' logParam: 'applausetester+vd_ios1110@applause.expensifail.com' urlToNewDot: 'https://staging.new.expensify.com/' maxNumberOfUpdates: '500' requestID: '8243a3033d6f5c71-MIA' lastIP: '181.208.202.127' writeConsistency: 'ASYNC' priority: '500' timeout: '290000']'

which mostly looks like it worked and looking up that bankaccountid it does have the correct info

dbondy@db2.rno:~$ sudo readdb.sh -line "select * from bankaccounts where bankaccountid=3163628;"
       created = 2023-11-11 03:57:16
 bankAccountID = 3163628
     accountID = 16012072
       deleted = 0
 accountNumber = v10:9BAE53C85EE885C5E09BE50B8BCA93D5
 routingNumber = 031101114
      checking = 1
   addressName = Expensify Wallet
additionalData = {"accountHistory":[{"stateChangeDate":"1699675036909237","stateChangeTo":"Pending"}],"country":"US","currency":"USD","fieldsType":"local","verifications":{"externalApiResponses":{"requestorIdentityID":{"apiResult":{"id-number":"2026549069","qualifiers":{"qualifier":{"key":"resultcode.newer.record.found","message":"Newer Record Found"}},"reason":"Tested via external APIs","results":{"key":"result.match","message":"ID Located"},"summary-result":{"key":"id.success","message":"PASS"}},"status":"pass","timestamp":"2023-11-11 03:59:08"},"requestorIdentityOnfido":{"apiResult":{"applicantID":"ff04d9ec-ef5f-4f03-8bf5-83a30bb807a0","applicant_id":"ff04d9ec-ef5f-4f03-8bf5-83a30bb807a0","applicant_provides_data":false,"created_at":"2023-11-11T04:01:56Z","document":{"back":{"id":"4e035f49-0b76-416b-8af7-e17e448749ee"},"front":{"id":"85d34d79-bb7b-4dc4-9557-000d29d45875"}},"download_uri":"https://onfido.com/dashboard/pdf/information_requests/573025543","face":{"id":"af9f6e41-0c4b-4f32-b679-324fda133892","variant":"VIDEO"},"fixableErrors":["originalDocumentNeeded"],"form_uri":null,"href":"/v2/applicants/ff04d9ec-ef5f-4f03-8bf5-83a30bb807a0/checks/09dfa915-26fb-4177-9c3c-d96772b4abaa","id":"09dfa915-26fb-4177-9c3c-d96772b4abaa","paused":false,"reason":"Tested via external APIs","redirect_uri":null,"report_ids":["d09ee167-75f3-461a-ae3f-168cfe862519","74eb8c32-3840-4b78-82da-f77ad06fd864"],"report_type_groups":["13208"],"reports":[{"breakdown":{"age_validation":{"breakdown":{"minimum_accepted_age":{"properties":[],"result":"clear"}},"result":"clear"},"compromised_document":{"result":"clear"},"data_comparison":{"breakdown":{"date_of_birth":{"properties":[],"result":null},"date_of_expiry":{"properties":[],"result":null},"document_numbers":{"properties":[],"result":null},"document_type":{"properties":[],"result":null},"first_name":{"properties":[],"result":null},"gender":{"properties":[],"result":null},"issuing_country":{"properties":[],"result":null},"last_name":{"properties":[],"result":null}},"result":null},"data_consistency":{"breakdown":{"date_of_birth":{"properties":[],"result":null},"date_of_expiry":{"properties":[],"result":null},"document_numbers":{"properties":[],"result":null},"document_type":{"properties":[],"result":null},"first_name":{"properties":[],"result":null},"gender":{"properties":[],"result":null},"issuing_country":{"properties":[],"result":null},"last_name":{"properties":[],"result":null},"nationality":{"properties":[],"result":null}},"result":null},"data_validation":{"breakdown":{"date_of_birth":{"properties":[],"result":"clear"},"document_expiration":{"properties":[],"result":"consider"},"document_numbers":{"properties":{"document_number":"clear"},"result":"clear"},"expiry_date":{"properties":[],"result":"clear"},"gender":{"properties":[],"result":"clear"},"mrz":{"properties":[],"result":null}},"result":"consider"},"image_integrity":{"breakdown":{"colour_picture":{"properties":[],"result":"clear"},"conclusive_document_quality":{"properties":{"abnormal_document_features":"clear","corner_removed":"clear","digital_document":"clear","missing_back":"clear","obscured_data_points":"clear","obscured_security_features":"clear","punctured_document":"clear","watermarks_digital_text_overlay":"clear"},"result":"clear"},"image_quality":{"properties":[],"result":"clear"},"supported_document":{"properties":[],"result":"clear"}},"result":"clear"},"police_record":{"result":null},"visual_authenticity":{"breakdown":{"digital_tampering":{"properties":[],"result":"clear"},"face_detection":{"properties":[],"result":"clear"},"fonts":{"properties":[],"result":"consider"},"original_document_present":{"properties":{"document_on_printed_paper":"clear","photo_of_screen":"consider","scan":"clear","screenshot":"clear"},"result":"consider"},"other":{"properties":[],"result":"consider"},"picture_face_integrity":{"properties":[],"result":"consider"},"security_features":{"properties":[],"result":"consider"},"template":{"properties":[],"result":"clear"}},"result":"consider"}},"check_id":"09dfa915-26fb-4177-9c3c-d96772b4abaa","created_at":"2023-11-11T04:01:56+00:00","documents":[{"id":"4e035f49-0b76-416b-8af7-e17e448749ee"},{"id":"85d34d79-bb7b-4dc4-9557-000d29d45875"}],"href":"/v3/reports/74eb8c32-3840-4b78-82da-f77ad06fd864","id":"74eb8c32-3840-4b78-82da-f77ad06fd864","name":"document","properties":{"date_of_birth":["1990-09-16"],"date_of_expiry":["2021-01-21"],"document_numbers":[{"type":"document_number","value":"AB123456"}],"document_type":["driving_licence"],"first_name":["JANE"],"gender":["Female"],"issuing_country":["USA"],"issuing_date":["2018-07-02"],"issuing_state":["OH"],"last_name":["DOE"],"real_id_compliance":[true]},"result":"consider","status":"complete","sub_result":"suspected"},{"breakdown":{"face_comparison":{"breakdown":{"face_match":{"properties":{"score":0.1449},"result":"consider"}},"result":"consider"},"image_integrity":{"breakdown":{"face_detected":{"properties":[],"result":"clear"},"source_integrity":{"properties":[],"result":"clear"}},"result":"clear"},"visual_authenticity":{"breakdown":{"liveness_detected":{"properties":[],"result":"clear"},"spoofing_detection":{"properties":{"score":0.9964},"result":"clear"}},"result":"clear"}},"check_id":"09dfa915-26fb-4177-9c3c-d96772b4abaa","created_at":"2023-11-11T04:01:56+00:00","documents":[],"href":"/v3/reports/d09ee167-75f3-461a-ae3f-168cfe862519","id":"d09ee167-75f3-461a-ae3f-168cfe862519","name":"facial_similarity_video","properties":[],"result":"consider","status":"complete"}],"result":"consider","results_uri":"https://dashboard.onfido.com/checks/09dfa915-26fb-4177-9c3c-d96772b4abaa","sandbox":false,"status":"complete","tags":["bankAccountID_3163628","accountID_16012072","env_staging"],"type":"express","version":"3.0"},"status":"consider","timestamp":"2023-11-11 04:14:11"}}},"legalFirstName":"Alberta","legalLastName":"Charleson","dob":"1980-01-01","addressCity":"Alger","addressState":"OH","addressStreet":"123 Place Street","addressZipCode":"45812","currentStep":"TermsStep"}
   addressCity = false
  addressState = false
    addressZip =
 defaultCredit = 0
         state = 0
  validateCode =
     processor =
          type = 0

Seems like something broke before we could call onfido for applausetester+vd_1110@applause.expensifail.com

i do see requests here for OpenPlaidBankAccountSelector image

bondydaa commented 11 months ago

oh but those are all from the 10th.

bondydaa commented 11 months ago

went back to the thread to confirm a question i had

bondydaa commented 11 months ago

I'm going to remove the deploy blocker from this, since I tested on staging and couldn't reproduce it might be something specific to the applause testing account but we don't need to block on it I don't think.

MariaHCD commented 11 months ago

For applausetester+vd_1110@applause.expensifail.com, I don't think the KYC process was ever started. Looking at the additionalData, there is no currentStep at all, it should've been set to OnfidoStep if this user passed the AdditionalDetailsStep and started the Onfido verification. Additionally, from Slack, the Enable wallet button is visible and upon clicking it, the user is taken to add their personal bank account indicating that the KYC process was never started. We do not allow a user to start wallet KYC unless they have a PBA setup.

For applausetester+vd_ios1110@applause.expensifail.com, looking at the Onfido check from the additionalData, this account failed Onfido:

Screenshot 2023-11-15 at 12 20 23 PM

In this case, this account will not be able to continue with the wallet KYC process. This is expected behavior for now, we have some ideas of allowing a user to retry Onfido at least once but that is not in place just yet.

So I think we're good to close this one out. Thoughts, @bondydaa?

bondydaa commented 11 months ago

:thumbsup: yep agreed