[$500] [HOLD for payment 2023-11-30] Web - Referral - 'Got it' button does not take you back to the Previous page after a reload

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.1.5 Reproducible in staging?: y Reproducible in production?: new feature If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

1. Click on FAB > Request Money > switch to Manual
2. Enter the amount and click on Next
3. Click on 'Request money, get $250' to go to the referral page
4. Reload the page
5. Click on the 'Got it' Button

Expected Result:

Click on the 'Got it' Button takes you back to the Manual page

Actual Result:

Click on the 'Got it' Button takes you back to the main chat.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [x] Android: mWeb Chrome
• [ ] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/e9241618-b661-44da-8fab-ea3c274badc2

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0114db822bdf934768
• Upwork Job ID: 1730235291142729728
• Last Price Increase: 2023-11-30

[melvin-bot[bot]]

Triggered auto assignment to @grgia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Referral - 'Got it' button does not take you back to the Previous page after a reload

What is the root cause of that problem?

Currently, when clicking Got it button, we will call Navigation.goBack(). https://github.com/Expensify/App/blob/0cca90ab9aa7fd9467ef45ca35c4d0ad3c3334ae/src/pages/ReferralDetailsPage.js#L89 So if we reload page navigation history will be lost, It cause this bug. The same bug also happen when we click back button https://github.com/Expensify/App/blob/0cca90ab9aa7fd9467ef45ca35c4d0ad3c3334ae/src/pages/ReferralDetailsPage.js#L63

What changes do you think we should make in order to solve the problem?

We should define new goBack function in the ReferralDetailsPage We should use referralContentType in route to detect which is previous page and navigate to this page directly:

• If contentType is startChat, goBack function will be navigating to StartChatPage
• Similar to other page

What alternative solutions did you explore? (Optional)

• NA

[luacmartins]

@DylanDylann are you able to work on a PR within the next hour?

[Tony-MK]

@luacmartins I am available, only if dylan is away. Should I post a prospal?

[luacmartins]

sure, go ahead

[Tony-MK]

@luacmartins It seems that I can't come up with a better proposal than Dylan's. If I do post a proposal, most likely it will be the same as Dylans.

[luacmartins]

We got a fix merged and CPed

[DylanDylann]

@DylanDylann are you able to work on a PR within the next hour?

@luacmartins It was 2:42 AM in my time, so I wasn't available to raise a quick PR. Thanks so much for your PR. Could you assign me to this issue for compensation?

[melvin-bot[bot]]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.2-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/31658

If no regressions arise, payment will be issued on 2023-11-30. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• [ ] External issue reporter
• [ ] Contributor that fixed the issue
• [ ] Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @DylanDylann requires payment

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [x] [@luacmartins] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/30372
• [x] [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30372#issuecomment-1824785700
• [x] [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A this is in the navigations guidelines
• [x] [@DylanDylann] Determine if we should create a regression test for this bug.
• [x] [@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [x] [@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~0114db822bdf934768

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[conorpendergrast]

It looks like @DylanDylann is the only person to be compensated here. @luacmartins given you assigned @DylanDylann to the issue, I'm taking that as an endorsement of the solution and that partial compensation is needed here (as @DylanDylann didn't create the PR directly). I'm going to move ahead with 50% compensation (so that's 50% of $500 = $250)

[conorpendergrast]

Payouts due:

• [x] Contributor: $250 @DylanDylann - offer

Upwork job is here.

[conorpendergrast]

Paid @DylanDylann!

@luacmartins From the checklist, as you filled out the first three steps, do you think we need a regression test?

Once we confirm that and complete the checklist, we'll be set to close this out

[luacmartins]

No need for regression test since Applause already caught this issue during regression.

[luacmartins]

Closing issue as per comment above. Thanks everyone!

[conorpendergrast]

Damn, you stole the satisfying bit.

And thanks! I am still not used to 90% of bugs coming directly from regression testing

[luacmartins]

Sorry haha I'll let you close it next time :)