[MEDIUM] Expensify Cards: All card pages link to the same Expensify Card

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.35k stars 2.77k forks source link

[MEDIUM] Expensify Cards: All card pages link to the same Expensify Card #31771

Closed grgia closed 5 months ago

grgia commented 10 months ago

When a user has Multiple Physical Expensify Cards in their cardList, all menuItems open the first card. This was originally designed with the incorrect assumption that a user would have max 2 cards, a physical and virtual card.

Solution Let's use the cardIDs of the card we're opening. We may need to discuss displaying "linked" virtual cards as part of this issue or tackle that as a separate issue.

You can see an example of this in this video -

https://user-images.githubusercontent.com/78819774/285047055-df59c466-6fcf-45e7-aff9-5dcc54210945.mp4

melvin-bot[bot] commented 9 months ago

@grgia Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] commented 9 months ago

@grgia Still overdue 6 days?! Let's take care of this!

melvin-bot[bot] commented 8 months ago

@grgia 10 days overdue. I'm getting more depressed than Marvin.

melvin-bot[bot] commented 8 months ago

@grgia 12 days overdue. Walking. Toward. The. Light...

grgia commented 8 months ago

@kevinksullivan for this issue I think the root cause is mainly the incorrect card data in the DB (i.e. multiple active cards). https://github.com/Expensify/App/issues/33515#issuecomment-1875710545

I don't think we can update the query to filter those out, so this might be a case where having an edge case like the current design of showing multiple cards with last four pan in newdot. Sorry for the confusion with this one!

For now I think we can:

condense everything into one eCard slot
if there are multiple active physical or virtual cards, show them all on the card page for now
work on fixing the DB in the linked issue to clear any cards that are deactivated in marqeta and not in our DB

How does that sound?

melvin-bot[bot] commented 8 months ago

@grgia Eep! 4 days overdue now. Issues have feelings too...

kevinksullivan commented 8 months ago

Let's hold on doing anyhting here for now and see where we land on the admin side of card management. Convo:

https://expensify.slack.com/archives/C05DWUDHVK7/p1704927942434149?thread_ts=1704920930.824409&cid=C05DWUDHVK7

grgia commented 8 months ago

sounds good holding !

grgia commented 8 months ago

still holding

grgia commented 6 months ago

still on HOLD

grgia commented 5 months ago

closing in favor of https://github.com/Expensify/App/issues/38468