[HOLD for payment 2023-12-07] [$500] IOU - Cannot proceed to next month and dates appear blank when last day of month is selected

kbecciv commented 7 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.3.0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

Navigate to staging.new.expensify.com.
Click FAB > Request money > Manual.
Enter amount, choose participant and proceed to confirmation page.
Click Show more > Date.
Choose the date 31st Oct.
Go to November.
Choose the date 30th Sept.
Go to October.

Expected Result:

In Step 6, user should be able to go to November. In Step 8, no blank dates will be shown.

Actual Result:

In Step 6, user is unable to go to November. In Step 8, blank dates are shown.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/51509968-5a3d-4b65-a4b4-7ba2d4ca964f

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01cc0d157099a8bbaa
Upwork Job ID: 1727778969100070912
Last Price Increase: 2023-11-23
Automatic offers:

s77rt | Reviewer | 27845856
paultsimura | Contributor | 27845858

melvin-bot[bot] commented 7 months ago

Job added to Upwork: https://www.upwork.com/jobs/~01cc0d157099a8bbaa

melvin-bot[bot] commented 7 months ago

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 7 months ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot[bot] commented 7 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

paultsimura commented 7 months ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

The issue is that in the CalendarPicker, we check if there are available dates next month by the following logic:

https://github.com/Expensify/App/blob/d521dd6783c382297e06a429701ae1936f808041/src/components/NewDatePicker/CalendarPicker/index.js#L130-L131

Here, if the next month has <= days than the selected day number, we compare the start of the day with the end of the same day (end of next month):

https://github.com/Expensify/App/blob/d521dd6783c382297e06a429701ae1936f808041/src/components/NewDatePicker/CalendarPicker/index.js#L187

What changes do you think we should make in order to solve the problem?

We should simplify this logic to avoid unnecessary chained calculations and only check if the max allowed date is after the end of the current month. This would mean that there are available dates next month – at least the props.maxDate will be available. We should also modify the navigation to the previous month in a similar way.

const hasAvailableDatesNextMonth = startOfDay(new Date(this.props.maxDate)) > endOfMonth(new Date(this.state.currentDateView));
const hasAvailableDatesPrevMonth = endOfDay(new Date(this.props.minDate)) < startOfMonth(new Date(this.state.currentDateView));

Also, we'll need to prevent the non-existing days from being falsely marked as "selected" when navigating, so we should also add a !!day (or even !isDisabled) check here:

const isSelected = !!day && isSameDay(parseISO(this.props.value), new Date(currentYearView, currentMonthView, day));

https://github.com/Expensify/App/blob/d521dd6783c382297e06a429701ae1936f808041/src/components/NewDatePicker/CalendarPicker/index.js#L218-L222

Result:

https://github.com/Expensify/App/assets/12595293/50ca2707-a004-4ac5-9af2-a917f211d0db

What alternative solutions did you explore? (Optional)

rakshitjain13 commented 7 months ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Cannot proceed to next month and dates appear blank when the last day of the month is selected

What is the root cause of that problem?

Here will check for next month button should show or not, we are checking with the start time of the max date (last date of the current month) which cause the problem https://github.com/Expensify/App/blob/7a68a3d1003130e63065bcbef253c912a3431c08/src/components/NewDatePicker/CalendarPicker/index.js#L130

What changes do you think we should make in order to solve the problem?

Here we should use the end of the day time instead of start time of max date

const hasAvailableDatesNextMonth = endOfDay(endOfMonth(new Date(this.props.maxDate))) > addMonths(new Date(this.state.currentDateView), 1);

What alternative solutions did you explore? (Optional)

NA

s77rt commented 7 months ago

@paultsimura Thanks for the proposal. Your RCA is correct and the solution looks good to me 👍.

PS: When raising a PR please add test case in CalendarPickerTest.js to prevent this from happening again.

🎀 👀 🎀 C+ reviewed Link to proposal

melvin-bot[bot] commented 7 months ago

Triggered auto assignment to @MonilBhavsar, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

s77rt commented 7 months ago

@rakshitjain13 Thanks for the proposal. Your RCA is correct. The suggested solution would work but it's not complete i.e. it does not fix the wrongly selected days

MonilBhavsar commented 7 months ago

Looks good. Agree we should simplify the logic

melvin-bot[bot] commented 7 months ago

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

melvin-bot[bot] commented 7 months ago

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

paultsimura commented 7 months ago

Thank you. The PR is ready for review: https://github.com/Expensify/App/pull/32073

melvin-bot[bot] commented 7 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 7 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.5-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/32073

If no regressions arise, payment will be issued on 2023-12-07. :confetti_ball:

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@paultsimura requires payment offer (Contributor)
@s77rt requires payment offer (Reviewer)

melvin-bot[bot] commented 7 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@s77rt] Determine if we should create a regression test for this bug.
[ ] [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

s77rt commented 7 months ago

The PR that introduced the bug has been identified: https://github.com/Expensify/App/pull/29984
The offending PR has been commented on: https://github.com/Expensify/App/pull/29984#discussion_r1404504775 and https://github.com/Expensify/App/pull/29984#discussion_r1404507378
A discussion in #expensify-bugs has been started: Not needed
Determine if we should create a regression test for this bug: No. We have added a unit test instead

miljakljajic commented 7 months ago

Both contracts paid and ended - thank you for your work!

Expensify / App