search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.34k stars 2.77k forks source link

[HOLD for payment 2024-01-22] [$250] [TS migration] Migrate 'SignInButtons' component to TypeScript #31980

Closed melvin-bot[bot] closed 8 months ago

melvin-bot[bot] commented 9 months ago

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/SignInButtons/IconButton.js 8
src/components/SignInButtons/GetUserLanguage.js 0
src/components/SignInButtons/GoogleSignIn/index.website.js 8
src/components/SignInButtons/GoogleSignIn/index.native.js 7
src/components/SignInButtons/GoogleSignIn/index.desktop.js 8
src/components/SignInButtons/AppleSignIn/index.website.js 10
src/components/SignInButtons/AppleSignIn/index.ios.js 6
src/components/SignInButtons/AppleSignIn/index.desktop.js 7
src/components/SignInButtons/AppleSignIn/index.android.js 7
src/components/SignInButtons/AppleAuthWrapper/index.js 0
src/components/SignInButtons/AppleAuthWrapper/index.ios.js 3
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014df343518e1f9fe5
  • Upwork Job ID: 1736777478874030080
  • Last Price Increase: 2023-12-18
  • Automatic offers:
    • shahinyan11 | Contributor | 28065558
melvin-bot[bot] commented 9 months ago

Job added to Upwork: https://www.upwork.com/jobs/~014df343518e1f9fe5

melvin-bot[bot] commented 9 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

melvin-bot[bot] commented 9 months ago

Upwork job price has been updated to $250

MahmudjonToraqulov commented 9 months ago

I would like to work on this

HezekielT commented 9 months ago

I would love to work on this.

ZhenjaHorbach commented 9 months ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

[TS migration] Migrate 'SignInButtons' component to TypeScript

What is the root cause of that problem?

Not problem (Technical ticket )

What changes do you think we should make in order to solve the problem?

We need to update these files using best practices using TS guide

https://github.com/Expensify/App/blob/main/contributingGuides/TS_STYLE.md

What alternative solutions did you explore? (Optional)

NA

shahinyan11 commented 9 months ago

I would like to work on this. I commented only under this issue

rayane-djouah commented 9 months ago

I would like to work on this issue

yh-0218 commented 9 months ago

I would like to work on this issue

djabdou commented 9 months ago

I would like to work on this

annscode commented 9 months ago

I would like to work on this issue

expertscoders commented 9 months ago

I'm available to work on this

Ekaterina-Kaschenko commented 9 months ago
  1. Create a types file in the root of each component (SignInButtons, ReportActionItemFragment, ReportActionItemMessageEdit).
  2. Define public and private interfaces/types in the types file and export the public ones for external use.
  3. Use the .ts extension for each file in the folders.
  4. Go through each file and apply appropriate types for incoming parameters (props).
  5. Specify types for generics where needed.
  6. Test all properly.

Also, we'd like to mention that it's not good to keep codes for server requests separately https://github.com/Expensify/App/blob/main/src/components/SignInButtons/AppleSignIn/index.ios.js#L12

melvin-bot[bot] commented 9 months ago

📣 @Ekaterina-Kaschenko! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format: 
    Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Tony-MK commented 9 months ago

Can I work on this migration?

anudeeps0306 commented 9 months ago

Contributor details Your Expensify account email: anudeep0306@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/~019df89cc58fc54b33

To proceed with the TypeScript migration, follow these steps:

1. File-by-File Migration:

2. Define Types in Types Files:

3. Specific Steps:

4. Testing and Validation:

melvin-bot[bot] commented 9 months ago

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

burczu commented 9 months ago

It looks like @shahinyan11 was first (not assigned or recommended yet to any other TS migration issue) here, so I think we can assign them.

🎀 👀 🎀 C+ reviewed

melvin-bot[bot] commented 9 months ago

Triggered auto assignment to @yuwenmemon, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

shahinyan11 commented 9 months ago

@burczu
@MahmudjonToraqulov already has assigned one here

burczu commented 9 months ago

@shahinyan11 Ahh, thanks for pointing this out - you are right. So the next is @HezekielT on the list.

shahinyan11 commented 9 months ago

@burczu
@HezekielT also has assigned

burczu commented 9 months ago

@shahinyan11 where? I've just checked all the TS migration issues on the list from Vit on slack

shahinyan11 commented 9 months ago

I'm the first one who hasn't been assigned yet

shahinyan11 commented 9 months ago

@burczu Here

Ekaterina-Kaschenko commented 9 months ago

No, I was the first one who technically explained the steps

burczu commented 9 months ago

@shahinyan11 Hmmm... I wonder what to do in this situation - @HezekielT is not assigned yet, they are only recommended by the C+. But I think they'll be assigned so I think it's safe to omit them here and assign you, @shahinyan11 instead.

burczu commented 9 months ago

@Ekaterina-Kaschenko Unfortunately, in this type of issues, we don't expect any kind of proposal - who comments first, gets the issue.

shahinyan11 commented 9 months ago

@burczu I think If HezekielT is first in somewhere then I should be assigned here .

burczu commented 9 months ago

@shahinyan11 You are already recommended to be assigned here... https://github.com/Expensify/App/issues/31980#issuecomment-1862308120

yaroslav-sydoryk commented 9 months ago

@burczu hi. you have an intresting approuch here, why are you looking for person who was first instead of one with tech details and proper planing of solution ? Aren't you aming for better quality for your code/project ?

melvin-bot[bot] commented 9 months ago

📣 @yaroslav-sydoryk! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format: 
    Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
burczu commented 9 months ago

@yaroslav-sydoryk The community was asked to quickly help with TS migration here: https://expensify.slack.com/archives/C01GTK53T8Q/p1702915376952599.

Quote from this slack message:

whoever bid first, they can implement it

Ekaterina-Kaschenko commented 9 months ago

@burczu there wasn't information about Slack community. We did all mentioned in the job details

image
shahinyan11 commented 9 months ago

@Ekaterina-Kaschenko Are you read the CONTRIBUTING.md . I suggest you to read this guide before submitting any proposal

Ekaterina-Kaschenko commented 9 months ago

@shahinyan11 @burczu my bad, thank you

melvin-bot[bot] commented 9 months ago

📣 @shahinyan11 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

shahinyan11 commented 9 months ago

I expect my review request to be ready for review by the end of tomorrow.

burczu commented 9 months ago

Hey @yuwenmemon! I'll be OOO till January 6th, and right after that I'm leaving the C+ role and joining Waves. Could you assign another C+ engineer to handle this issue from now on? Thanks.

melvin-bot[bot] commented 8 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

yuwenmemon commented 8 months ago

Sure thing! @rushatgabhane can you take a look?

melvin-bot[bot] commented 8 months ago

Triggered auto assignment to @NicMendonca (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

melvin-bot[bot] commented 8 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 8 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.24-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-22. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 8 months ago

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

rushatgabhane commented 8 months ago

TS migration. No regression steps needed.

rushatgabhane commented 8 months ago

@NicMendonca could you please add payment summary so it'll be paid on 22nd. Thank you 🙇

NicMendonca commented 8 months ago

BZ Summary: C: @shahinyan11 - $250 (paid via Upwork) C+: @rushatgabhane - $250 (paid via Expensify)

NicMendonca commented 8 months ago

@shahinyan11 you've been paid! @rushatgabhane don't forget to request payment!

JmillsExpensify commented 7 months ago

$250 payment approved for @rushatgabhane based on summary above.