Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.55k stars 2.89k forks source link

[HOLD for payment 2024-01-31] [TS migration] Migrate 'ReferralDetails' page to TypeScript #31991

Closed melvin-bot[bot] closed 9 months ago

melvin-bot[bot] commented 11 months ago

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/ReferralDetailsPage.js 20
melvin-bot[bot] commented 10 months ago

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

JKobrynski commented 10 months ago

Hi, I'm Julian from Callstack - expert contributor group - and I would like to take a look at this issue.

JKobrynski commented 10 months ago

The PR is ready for review!

melvin-bot[bot] commented 9 months ago

Triggered auto assignment to @tylerkaraszewski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot[bot] commented 9 months ago

Triggered auto assignment to @dylanexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

dylanexpensify commented 9 months ago

nice! quick and easy

melvin-bot[bot] commented 9 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 9 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.30-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-31. :confetti_ball:

melvin-bot[bot] commented 9 months ago

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

dylanexpensify commented 9 months ago

payment upcoming!

dylanexpensify commented 9 months ago

today!

dylanexpensify commented 9 months ago

ah no payment needed?

mananjadhav commented 9 months ago

@dylanexpensify I should've been paid for this issue as I reviewed the PR.

dylanexpensify commented 9 months ago

Payment summary:

Please request!

JmillsExpensify commented 9 months ago

$250 approved for @mananjadhav based on summary above.