[$500] All - Split Bill - Employee can successfully access IOU detail page

lanitochka17 commented 10 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.4-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Issue found when executing PR https://github.com/Expensify/App/pull/31291

Action Performed:

Navigate to staging.new.epxpensify.com 2.. Create a workspace
Open the #announce room
Do a split bill in the room
Log in on another device (with the same/different account, if you use a different account, make sure invite it to the workspace)
Visit the #announce room

Expected Result:

The split bill preview should show as a skeleton and a not found page should be shown when enter preview details

Actual Result:

Employee can successfully access IOU detail page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/067446e3-4342-4b2a-876f-3a0c639d69a4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013577bb1c6b9e9765
Upwork Job ID: 1729293708655165440
Last Price Increase: 2023-11-28

melvin-bot[bot] commented 10 months ago

Job added to Upwork: https://www.upwork.com/jobs/~013577bb1c6b9e9765

melvin-bot[bot] commented 10 months ago

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 10 months ago

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot[bot] commented 10 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

bernhardoj commented 10 months ago

@lanitochka17 I would like to do some clarification on the reproduction steps.

Log in on another device

If you are already logged in, you need to log out first.

Expected Result:

The split bill preview should show as a skeleton and a not found page should be shown when enter preview details

Sorry, but I forgot to update the test step in https://github.com/Expensify/App/pull/31291. We agree to disable the click when the IOU preview is still loading (shown as a skeleton), so the expected result should be:

The split bill preview should show as a skeleton and be disabled.

Can you please recheck this? Thanks!

melvin-bot[bot] commented 10 months ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] commented 10 months ago

Current assignee @hoangzinh is eligible for the Internal assigner, not assigning anyone new.

twisterdotcom commented 10 months ago

@lanitochka17 I think based on @bernhardoj's comment, we can close this?

melvin-bot[bot] commented 10 months ago

@twisterdotcom Be sure to fill out the Contact List!

Expensify / App