[$500] Chat – The emoji is not added to Frequently Used when react the message.

izarutskaya commented 11 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v1.4.4-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause-Internal Team Slack conversation: @

Action Performed:

Go to https://staging.new.expensify.com/
Log in with any account.
Navigate to a conversation that already has some messages.
Hover over any message
Verify there's a button to select an emoji to react the message
Click on the button
Verify the emoji picker opens
Select any emoji from the list
Hover over any message one more time.
Click on the button to select an emoji to react the message one more time.

Expected Result:

The emoji is added to Frequently Used when react the message

Actual Result:

The emoji is not added to Frequently Used when react the message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

https://github.com/Expensify/App/assets/115492554/eb903738-0dc6-4ed1-9e7d-c9ece37ad5e8

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~011b94505876eacdb3
Upwork Job ID: 1729457945037398016
Last Price Increase: 2023-12-19

melvin-bot[bot] commented 11 months ago

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 11 months ago

Job added to Upwork: https://www.upwork.com/jobs/~011b94505876eacdb3

melvin-bot[bot] commented 11 months ago

Bug0 Triage Checklist (Main S/O)

[x] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[x] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
[x] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
[x] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
[x] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot[bot] commented 11 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

dukenv0307 commented 11 months ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

The emoji is not added to Frequently Used when react the message

What is the root cause of that problem?

We're not calling the updateFrequentlyUsedEmojis when the emoji is selected to react to message.

What changes do you think we should make in order to solve the problem?

Call the updateFrequentlyUsedEmojis when the emoji is selected to react to message.

User.updateFrequentlyUsedEmojis(EmojiUtils.getFrequentlyUsedEmojis(emoji));

We can add to Report.toggleEmojiReaction here.

What alternative solutions did you explore? (Optional)

We should double check all emoji-related features and make sure to update the frequently used emojis list if they are used.

If the emoji reaction is undo-ed, we can consider decreasing it in the frequently used emoji list.

strepanier03 commented 11 months ago

allroundexperts commented 11 months ago

Seem to be related but not exactly the same. In the linked ticket, we're talking about the emoji picker in the status selector in user profile settings. I like the idea of moving this logic to the emoji picker itself by @DylanDylann here. Let's see what @0xmiroslav decides.

strepanier03 commented 11 months ago

Sounds good, I'll check that GH Monday to see if a decision has been made.

strepanier03 commented 11 months ago

Nothing yet, I'll check again tomorrow.

melvin-bot[bot] commented 11 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

strepanier03 commented 11 months ago

Nothing yet, will check again tomorrow.

melvin-bot[bot] commented 11 months ago

@strepanier03, @allroundexperts Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

strepanier03 commented 11 months ago

Still paused for an update on https://github.com/Expensify/App/issues/31802#issuecomment-1825061164

melvin-bot[bot] commented 11 months ago

@strepanier03 @allroundexperts this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 11 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 11 months ago

@strepanier03, @allroundexperts Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

0xmiros commented 11 months ago

I think we can close this as well based on https://github.com/Expensify/App/issues/31802#issuecomment-1859189580

melvin-bot[bot] commented 11 months ago

@strepanier03 @allroundexperts this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

melvin-bot[bot] commented 11 months ago

@strepanier03, @allroundexperts Still overdue 6 days?! Let's take care of this!

allroundexperts commented 11 months ago

@strepanier03 Can you please confirm this comment? If so, I think we can then close this ticket.

melvin-bot[bot] commented 11 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

strepanier03 commented 11 months ago

Sorry for the hold-up, I've been OoO.

I reviewed the comment linked and reviewed against our waves and agree this can be closed for focus as it's not a required part of any waves.

Expensify / App