search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

Split bill - Does nothing when clicking on "Split bill preview" #32122

Closed kbecciv closed 11 months ago

kbecciv commented 11 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.4.0 Reproducible in staging?: y Reproducible in production?: no (crash on production) If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Issue found when executing PR https://github.com/Expensify/App/pull/31291

Action Performed:

  1. Create a workspace if you don't have one
  2. Open the #announce room
  3. Do a split bill in the room
  4. Log in on another device (with the same/different account, if you use a different account, make sure invite it to the workspace)
  5. Visit the #announce room
  6. The split bill preview should show as a skeleton
  7. Press the preview

Expected Result:

Verify a not found page is shown and that no crash happens.

Actual Result:

Does nothing when clicking on "Split bill preview"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/41e60e65-81f2-4e9e-a7b2-eeba26f1cd21

View all open jobs on GitHub

github-actions[bot] commented 11 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
melvin-bot[bot] commented 11 months ago

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

bernhardoj commented 11 months ago

This is the expected behavior. See https://github.com/Expensify/App/issues/32078#issuecomment-1829140231

situchan commented 11 months ago

Seems expected but there should have been UX discussion with design team

iwiznia commented 11 months ago

Ah ok, so not a blocker and expected it seems. I am not sure what other thing we could do to improve UX... tagging @Expensify/design to get their opinions.

shawnborton commented 11 months ago

Hmm but the mouse is just a standard mouse cursor and not a pointer cursor, so from a visual feedback perspective, the user would know there is nothing to click on right?

iwiznia commented 11 months ago

Yep, that's right. So close it?

shawnborton commented 11 months ago

That's my vote, yup.